From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D3AC433DB for ; Fri, 15 Jan 2021 12:28:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FA5223884 for ; Fri, 15 Jan 2021 12:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbhAOM2u (ORCPT ); Fri, 15 Jan 2021 07:28:50 -0500 Received: from relay05.th.seeweb.it ([5.144.164.166]:44117 "EHLO relay05.th.seeweb.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbhAOM2t (ORCPT ); Fri, 15 Jan 2021 07:28:49 -0500 Received: from [192.168.1.101] (abaf224.neoplus.adsl.tpnet.pl [83.6.169.224]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 9F72A3EF0F; Fri, 15 Jan 2021 13:28:06 +0100 (CET) Subject: Re: [PATCH v4 1/2] arm64: dts: sdm845: add oneplus6/6t devices To: Caleb Connolly , Andy Gross , Bjorn Andersson , Rob Herring , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210114203057.64541-1-caleb@connolly.tech> <20210114203057.64541-2-caleb@connolly.tech> From: Konrad Dybcio Message-ID: <061f8c37-533f-b694-f9a8-393cb9a34e01@somainline.org> Date: Fri, 15 Jan 2021 13:28:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210114203057.64541-2-caleb@connolly.tech> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org Please move gpio-keys before reserved-memory to keep things sorted. > + vreg_l25a_3p3: ldo25 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3312000>; > + regulator-initial-mode = ; > + }; > + vdda_mipi_dsi0_1p2: Add a newline between the "};" and "vdda_mipi_dsi0_1p2:" to keep it consistent. After that, you can add: Reviewed-by: Konrad Dybcio