Phone-Devel Archive on lore.kernel.org.
 help / color / Atom feed
* [PATCH] qcom: spmi-regulator: Add support for ULT LV_P50 and ULT P300
@ 2021-02-25 21:35 Konrad Dybcio
  2021-03-01 14:23 ` Mark Brown
  2021-03-01 23:37 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Konrad Dybcio @ 2021-02-25 21:35 UTC (permalink / raw)
  To: phone-devel
  Cc: ~postmarketos/upstreaming, martin.botka,
	angelogioacchino.delregno, marijn.suijten, Konrad Dybcio,
	Andy Gross, Bjorn Andersson, Liam Girdwood, Mark Brown,
	linux-arm-msm, linux-kernel

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

The ULT LV_P50 shares the same configuration as the other ULT LV_Pxxx
and the ULT P300 shares the same as the other ULT Pxxx.

These two regulator types are found on PM8950 and its variants.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 drivers/regulator/qcom_spmi-regulator.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
index e62e1d72d943..00e1d8e9637e 100644
--- a/drivers/regulator/qcom_spmi-regulator.c
+++ b/drivers/regulator/qcom_spmi-regulator.c
@@ -1522,10 +1522,12 @@ static const struct spmi_regulator_mapping supported_regulators[] = {
 	SPMI_VREG(ULT_LDO, N600_ST, 0, INF, ULT_LDO, ult_ldo, ult_nldo, 10000),
 	SPMI_VREG(ULT_LDO, N900_ST, 0, INF, ULT_LDO, ult_ldo, ult_nldo, 10000),
 	SPMI_VREG(ULT_LDO, N1200_ST, 0, INF, ULT_LDO, ult_ldo, ult_nldo, 10000),
+	SPMI_VREG(ULT_LDO, LV_P50,   0, INF, ULT_LDO, ult_ldo, ult_pldo, 10000),
 	SPMI_VREG(ULT_LDO, LV_P150,  0, INF, ULT_LDO, ult_ldo, ult_pldo, 10000),
 	SPMI_VREG(ULT_LDO, LV_P300,  0, INF, ULT_LDO, ult_ldo, ult_pldo, 10000),
 	SPMI_VREG(ULT_LDO, LV_P450,  0, INF, ULT_LDO, ult_ldo, ult_pldo, 10000),
 	SPMI_VREG(ULT_LDO, P600,     0, INF, ULT_LDO, ult_ldo, ult_pldo, 10000),
+	SPMI_VREG(ULT_LDO, P300,     0, INF, ULT_LDO, ult_ldo, ult_pldo, 10000),
 	SPMI_VREG(ULT_LDO, P150,     0, INF, ULT_LDO, ult_ldo, ult_pldo, 10000),
 	SPMI_VREG(ULT_LDO, P50,     0, INF, ULT_LDO, ult_ldo, ult_pldo, 5000),
 };
-- 
2.30.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] qcom: spmi-regulator: Add support for ULT LV_P50 and ULT P300
  2021-02-25 21:35 [PATCH] qcom: spmi-regulator: Add support for ULT LV_P50 and ULT P300 Konrad Dybcio
@ 2021-03-01 14:23 ` Mark Brown
  2021-03-01 14:27   ` Konrad Dybcio
  2021-03-01 23:37 ` Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2021-03-01 14:23 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: phone-devel, ~postmarketos/upstreaming, martin.botka,
	angelogioacchino.delregno, marijn.suijten, Andy Gross,
	Bjorn Andersson, Liam Girdwood, linux-arm-msm, linux-kernel


[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

On Thu, Feb 25, 2021 at 10:35:13PM +0100, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> 
> The ULT LV_P50 shares the same configuration as the other ULT LV_Pxxx
> and the ULT P300 shares the same as the other ULT Pxxx.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] qcom: spmi-regulator: Add support for ULT LV_P50 and ULT P300
  2021-03-01 14:23 ` Mark Brown
@ 2021-03-01 14:27   ` Konrad Dybcio
  0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2021-03-01 14:27 UTC (permalink / raw)
  To: Mark Brown
  Cc: phone-devel, ~postmarketos/upstreaming, martin.botka,
	angelogioacchino.delregno, marijn.suijten, Andy Gross,
	Bjorn Andersson, Liam Girdwood, linux-arm-msm, linux-kernel


On 01.03.2021 15:23, Mark Brown wrote:
> On Thu, Feb 25, 2021 at 10:35:13PM +0100, Konrad Dybcio wrote:
>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>>
>> The ULT LV_P50 shares the same configuration as the other ULT LV_Pxxx
>> and the ULT P300 shares the same as the other ULT Pxxx.
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

Yeah, sorry for that.. We've had these changes for a veery long time and it now the fact that the commit title was sub-optimal went under our radar.. Hopefully won't happen again!


Konrad


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] qcom: spmi-regulator: Add support for ULT LV_P50 and ULT P300
  2021-02-25 21:35 [PATCH] qcom: spmi-regulator: Add support for ULT LV_P50 and ULT P300 Konrad Dybcio
  2021-03-01 14:23 ` Mark Brown
@ 2021-03-01 23:37 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-03-01 23:37 UTC (permalink / raw)
  To: Konrad Dybcio, phone-devel
  Cc: martin.botka, Andy Gross, linux-arm-msm,
	angelogioacchino.delregno, ~postmarketos/upstreaming,
	marijn.suijten, linux-kernel, Bjorn Andersson, Liam Girdwood

On Thu, 25 Feb 2021 22:35:13 +0100, Konrad Dybcio wrote:
> The ULT LV_P50 shares the same configuration as the other ULT LV_Pxxx
> and the ULT P300 shares the same as the other ULT Pxxx.
> 
> These two regulator types are found on PM8950 and its variants.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] qcom: spmi-regulator: Add support for ULT LV_P50 and ULT P300
      commit: b15d870510c0a3910c9980ebceab885a390af60c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 21:35 [PATCH] qcom: spmi-regulator: Add support for ULT LV_P50 and ULT P300 Konrad Dybcio
2021-03-01 14:23 ` Mark Brown
2021-03-01 14:27   ` Konrad Dybcio
2021-03-01 23:37 ` Mark Brown

Phone-Devel Archive on lore.kernel.org.

Archives are clonable:
	git clone --mirror https://lore.kernel.org/phone-devel/0 phone-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 phone-devel phone-devel/ https://lore.kernel.org/phone-devel \
		phone-devel@vger.kernel.org
	public-inbox-index phone-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.phone-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git