From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB49C433E0 for ; Wed, 10 Feb 2021 21:29:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B39D464ED3 for ; Wed, 10 Feb 2021 21:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232212AbhBJV3s (ORCPT ); Wed, 10 Feb 2021 16:29:48 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:34980 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232097AbhBJV3W (ORCPT ); Wed, 10 Feb 2021 16:29:22 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 787631C0B8A; Wed, 10 Feb 2021 22:28:36 +0100 (CET) Date: Wed, 10 Feb 2021 22:28:36 +0100 From: Pavel Machek To: Johan Hovold , Greg KH Cc: kernel list , phone-devel@vger.kernel.org, tony@atomide.com Subject: Re: [RFC/context] add serdev interfaces to n_gsm Message-ID: <20210210212836.GA18497@duo.ucw.cz> References: <20210107224530.GA23250@duo.ucw.cz> <20210131170639.GA21067@duo.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20210131170639.GA21067@duo.ucw.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > +config GNSS_MOTMDM > > > + tristate "Motorola Modem TS 27.010 serdev GNSS receiver support" > > > + depends on SERIAL_DEV_N_GSM > >=20 > > You need to post this driver together with the serdev-ngsm driver. This > > one cannot currently even be built without it, but we also need to see > > the greater picture here. >=20 > Well, here it is, for greater picture. But it is not ready. Current > problem I have is gsm_serdev_register_tty_port(). The way I do > platform device registration causes oops on module unload. Help with > that would be welcome I would not mind comments on parent patch and some help here. Basically I tried to work around limitation in=20 int serdev_device_add(struct serdev_device *serdev) { =2E.. /* Only a single slave device is currently supported. */ if (ctrl->serdev) { =2E.. return -EBUSY; Best regards, Pavel=20 --=20 http://www.livejournal.com/~pavelmachek --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYCRQBAAKCRAw5/Bqldv6 8g42AKCF3xaDusP/0QCXk30hrIxR+URjegCggiIRB9jUxIO3Cm4MVnT+SD+FDUs= =OUYv -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--