* [PATCH] thermal: qcom: tsens_v1: Enable sensor 3 on MSM8976
@ 2021-02-25 21:31 Konrad Dybcio
2021-03-17 18:23 ` Thara Gopinath
0 siblings, 1 reply; 2+ messages in thread
From: Konrad Dybcio @ 2021-02-25 21:31 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, martin.botka,
angelogioacchino.delregno, marijn.suijten, Konrad Dybcio,
Andy Gross, Bjorn Andersson, Amit Kucheria, Zhang Rui,
Daniel Lezcano, linux-arm-msm, linux-pm, linux-kernel
The sensor *is* in fact used and does report temperature.
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
drivers/thermal/qcom/tsens-v1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/qcom/tsens-v1.c b/drivers/thermal/qcom/tsens-v1.c
index 3c19a3800c6d..573e261ccca7 100644
--- a/drivers/thermal/qcom/tsens-v1.c
+++ b/drivers/thermal/qcom/tsens-v1.c
@@ -380,11 +380,11 @@ static const struct tsens_ops ops_8976 = {
.get_temp = get_temp_tsens_valid,
};
-/* Valid for both MSM8956 and MSM8976. Sensor ID 3 is unused. */
+/* Valid for both MSM8956 and MSM8976. */
struct tsens_plat_data data_8976 = {
.num_sensors = 11,
.ops = &ops_8976,
- .hw_ids = (unsigned int[]){0, 1, 2, 4, 5, 6, 7, 8, 9, 10},
+ .hw_ids = (unsigned int[]){0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10},
.feat = &tsens_v1_feat,
.fields = tsens_v1_regfields,
};
--
2.30.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal: qcom: tsens_v1: Enable sensor 3 on MSM8976
2021-02-25 21:31 [PATCH] thermal: qcom: tsens_v1: Enable sensor 3 on MSM8976 Konrad Dybcio
@ 2021-03-17 18:23 ` Thara Gopinath
0 siblings, 0 replies; 2+ messages in thread
From: Thara Gopinath @ 2021-03-17 18:23 UTC (permalink / raw)
To: Konrad Dybcio, phone-devel
Cc: ~postmarketos/upstreaming, martin.botka,
angelogioacchino.delregno, marijn.suijten, Andy Gross,
Bjorn Andersson, Amit Kucheria, Zhang Rui, Daniel Lezcano,
linux-arm-msm, linux-pm, linux-kernel
On 2/25/21 4:31 PM, Konrad Dybcio wrote:
> The sensor *is* in fact used and does report temperature.
I can't find any info that says otherwise. So,
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
Warm Regards
Thara
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> drivers/thermal/qcom/tsens-v1.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-v1.c b/drivers/thermal/qcom/tsens-v1.c
> index 3c19a3800c6d..573e261ccca7 100644
> --- a/drivers/thermal/qcom/tsens-v1.c
> +++ b/drivers/thermal/qcom/tsens-v1.c
> @@ -380,11 +380,11 @@ static const struct tsens_ops ops_8976 = {
> .get_temp = get_temp_tsens_valid,
> };
>
> -/* Valid for both MSM8956 and MSM8976. Sensor ID 3 is unused. */
> +/* Valid for both MSM8956 and MSM8976. */
> struct tsens_plat_data data_8976 = {
> .num_sensors = 11,
> .ops = &ops_8976,
> - .hw_ids = (unsigned int[]){0, 1, 2, 4, 5, 6, 7, 8, 9, 10},
> + .hw_ids = (unsigned int[]){0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10},
> .feat = &tsens_v1_feat,
> .fields = tsens_v1_regfields,
> };
>
--
Warm Regards
Thara
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-17 18:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 21:31 [PATCH] thermal: qcom: tsens_v1: Enable sensor 3 on MSM8976 Konrad Dybcio
2021-03-17 18:23 ` Thara Gopinath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).