* [PATCH 1/3] arm64: dts: imx8mq-librem5: Hog the correct gpio
2021-03-11 12:02 [PATCH 0/3] Librem 5 phone dts fixes Martin Kepplinger
@ 2021-03-11 12:02 ` Martin Kepplinger
2021-03-11 12:02 ` [PATCH 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on Martin Kepplinger
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2021-03-11 12:02 UTC (permalink / raw)
To: robh, shawnguo, kernel, festevam, krzk
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, phone-devel,
Guido Günther, Martin Kepplinger
From: Guido Günther <agx@sigxcpu.org>
There was an additional alias in the specifier it hogged line 27
instead of line 1.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 2d248304432b..460ef0d86540 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -286,8 +286,9 @@ &gpio1 {
pmic-5v-hog {
gpio-hog;
- gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
+ gpios = <1 GPIO_ACTIVE_HIGH>;
input;
+ lane-mapping = "pmic-5v";
};
};
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on
2021-03-11 12:02 [PATCH 0/3] Librem 5 phone dts fixes Martin Kepplinger
2021-03-11 12:02 ` [PATCH 1/3] arm64: dts: imx8mq-librem5: Hog the correct gpio Martin Kepplinger
@ 2021-03-11 12:02 ` Martin Kepplinger
2021-03-15 7:24 ` Shawn Guo
2021-03-11 12:02 ` [PATCH 3/3] arm64: defconfig: Enable the Hantro decoder Martin Kepplinger
2021-03-15 8:35 ` [PATCH v2 0/3] Librem 5 phone dts fixes Martin Kepplinger
3 siblings, 1 reply; 10+ messages in thread
From: Martin Kepplinger @ 2021-03-11 12:02 UTC (permalink / raw)
To: robh, shawnguo, kernel, festevam, krzk
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, phone-devel,
Sebastian Krzyszkowiak, Martin Kepplinger
From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Commit 66d3f246d79f ("arm64: dts: librem5: Don't mark buck3 as always on")
removed always-on marking from GPU regulator, which is great for power
saving - however it introduces additional i2c0 traffic which can be deadly
for devices from the Dogwood batch.
To workaround the i2c0 shutdown issue on Dogwood, this commit marks
buck3 as always-on again - but only for Dogwood (r3).
Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
index 0d38327043f8..cd3c3edd48fa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
@@ -28,6 +28,10 @@ &bq25895 {
ti,termination-current = <144000>; /* uA */
};
+&buck3_reg {
+ regulator-always-on;
+};
+
&proximity {
proximity-near-level = <25>;
};
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on
2021-03-11 12:02 ` [PATCH 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on Martin Kepplinger
@ 2021-03-15 7:24 ` Shawn Guo
0 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2021-03-15 7:24 UTC (permalink / raw)
To: Martin Kepplinger
Cc: robh, kernel, festevam, krzk, kernel, devicetree,
linux-arm-kernel, linux-kernel, phone-devel,
Sebastian Krzyszkowiak
On Thu, Mar 11, 2021 at 01:02:58PM +0100, Martin Kepplinger wrote:
> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
>
> Commit 66d3f246d79f ("arm64: dts: librem5: Don't mark buck3 as always on")
I cannot find this commit.
Shawn
> removed always-on marking from GPU regulator, which is great for power
> saving - however it introduces additional i2c0 traffic which can be deadly
> for devices from the Dogwood batch.
>
> To workaround the i2c0 shutdown issue on Dogwood, this commit marks
> buck3 as always-on again - but only for Dogwood (r3).
>
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
> index 0d38327043f8..cd3c3edd48fa 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
> @@ -28,6 +28,10 @@ &bq25895 {
> ti,termination-current = <144000>; /* uA */
> };
>
> +&buck3_reg {
> + regulator-always-on;
> +};
> +
> &proximity {
> proximity-near-level = <25>;
> };
> --
> 2.30.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm64: defconfig: Enable the Hantro decoder
2021-03-11 12:02 [PATCH 0/3] Librem 5 phone dts fixes Martin Kepplinger
2021-03-11 12:02 ` [PATCH 1/3] arm64: dts: imx8mq-librem5: Hog the correct gpio Martin Kepplinger
2021-03-11 12:02 ` [PATCH 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on Martin Kepplinger
@ 2021-03-11 12:02 ` Martin Kepplinger
2021-03-15 8:35 ` [PATCH v2 0/3] Librem 5 phone dts fixes Martin Kepplinger
3 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2021-03-11 12:02 UTC (permalink / raw)
To: robh, shawnguo, kernel, festevam, krzk
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, phone-devel,
Guido Günther, Martin Kepplinger
From: Fabio Estevam <festevam@gmail.com>
Enable the Hantro decoder driver so it can be enabled by
default on i.MX8M and Rockchip platforms.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/configs/defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 1f673b00c5f5..1a5669a73c01 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -919,6 +919,9 @@ CONFIG_VIRTIO_MMIO=y
CONFIG_XEN_GNTDEV=y
CONFIG_XEN_GRANT_DEV_ALLOC=y
CONFIG_MFD_CROS_EC_DEV=y
+CONFIG_STAGING=y
+CONFIG_STAGING_MEDIA=y
+CONFIG_VIDEO_HANTRO=m
CONFIG_CHROME_PLATFORMS=y
CONFIG_CROS_EC=y
CONFIG_CROS_EC_I2C=y
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 0/3] Librem 5 phone dts fixes
2021-03-11 12:02 [PATCH 0/3] Librem 5 phone dts fixes Martin Kepplinger
` (2 preceding siblings ...)
2021-03-11 12:02 ` [PATCH 3/3] arm64: defconfig: Enable the Hantro decoder Martin Kepplinger
@ 2021-03-15 8:35 ` Martin Kepplinger
2021-03-15 8:35 ` [PATCH v2 1/3] arm64: dts: imx8mq-librem5: Hog the correct gpio Martin Kepplinger
` (3 more replies)
3 siblings, 4 replies; 10+ messages in thread
From: Martin Kepplinger @ 2021-03-15 8:35 UTC (permalink / raw)
To: martin.kepplinger
Cc: devicetree, festevam, kernel, kernel, krzk, linux-arm-kernel,
linux-kernel, phone-devel, robh, shawnguo
Two fixes for the Librem 5 phone descriptions and one resend of
https://lore.kernel.org/linux-arm-kernel/20200915141622.14736-1-festevam@gmail.com/
that enables the hantro vpu staging driver. Feel free to ignore that one
if we want to wait for it to be out of staging.
revision history
----------------
v2: (thanks Shawn)
* fix commit hash in commit message
v1:
* https://lore.kernel.org/phone-devel/20210311120259.3310499-1-martin.kepplinger@puri.sm/T/
Fabio Estevam (1):
arm64: defconfig: Enable the Hantro decoder
Guido Günther (1):
arm64: dts: imx8mq-librem5: Hog the correct gpio
Sebastian Krzyszkowiak (1):
arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 3 ++-
arch/arm64/configs/defconfig | 3 +++
3 files changed, 9 insertions(+), 1 deletion(-)
--
2.30.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v2 1/3] arm64: dts: imx8mq-librem5: Hog the correct gpio
2021-03-15 8:35 ` [PATCH v2 0/3] Librem 5 phone dts fixes Martin Kepplinger
@ 2021-03-15 8:35 ` Martin Kepplinger
2021-03-15 8:35 ` [PATCH v2 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on Martin Kepplinger
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2021-03-15 8:35 UTC (permalink / raw)
To: martin.kepplinger
Cc: devicetree, festevam, kernel, kernel, krzk, linux-arm-kernel,
linux-kernel, phone-devel, robh, shawnguo, Guido Günther
From: Guido Günther <agx@sigxcpu.org>
There was an additional alias in the specifier it hogged line 27
instead of line 1.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 2d248304432b..460ef0d86540 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -286,8 +286,9 @@ &gpio1 {
pmic-5v-hog {
gpio-hog;
- gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
+ gpios = <1 GPIO_ACTIVE_HIGH>;
input;
+ lane-mapping = "pmic-5v";
};
};
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on
2021-03-15 8:35 ` [PATCH v2 0/3] Librem 5 phone dts fixes Martin Kepplinger
2021-03-15 8:35 ` [PATCH v2 1/3] arm64: dts: imx8mq-librem5: Hog the correct gpio Martin Kepplinger
@ 2021-03-15 8:35 ` Martin Kepplinger
2021-03-15 8:35 ` [PATCH v2 3/3] arm64: defconfig: Enable the Hantro decoder Martin Kepplinger
2021-03-17 7:59 ` [PATCH v2 0/3] Librem 5 phone dts fixes Shawn Guo
3 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2021-03-15 8:35 UTC (permalink / raw)
To: martin.kepplinger
Cc: devicetree, festevam, kernel, kernel, krzk, linux-arm-kernel,
linux-kernel, phone-devel, robh, shawnguo,
Sebastian Krzyszkowiak
From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Commit 99e71c029213 ("arm64: dts: imx8mq-librem5: Don't mark buck3 as always on")
removed always-on marking from GPU regulator, which is great for power
saving - however it introduces additional i2c0 traffic which can be deadly
for devices from the Dogwood batch.
To workaround the i2c0 shutdown issue on Dogwood, this commit marks
buck3 as always-on again - but only for Dogwood (r3).
Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
index 0d38327043f8..cd3c3edd48fa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
@@ -28,6 +28,10 @@ &bq25895 {
ti,termination-current = <144000>; /* uA */
};
+&buck3_reg {
+ regulator-always-on;
+};
+
&proximity {
proximity-near-level = <25>;
};
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 3/3] arm64: defconfig: Enable the Hantro decoder
2021-03-15 8:35 ` [PATCH v2 0/3] Librem 5 phone dts fixes Martin Kepplinger
2021-03-15 8:35 ` [PATCH v2 1/3] arm64: dts: imx8mq-librem5: Hog the correct gpio Martin Kepplinger
2021-03-15 8:35 ` [PATCH v2 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on Martin Kepplinger
@ 2021-03-15 8:35 ` Martin Kepplinger
2021-03-17 7:59 ` [PATCH v2 0/3] Librem 5 phone dts fixes Shawn Guo
3 siblings, 0 replies; 10+ messages in thread
From: Martin Kepplinger @ 2021-03-15 8:35 UTC (permalink / raw)
To: martin.kepplinger
Cc: devicetree, festevam, kernel, kernel, krzk, linux-arm-kernel,
linux-kernel, phone-devel, robh, shawnguo, Guido Günther
From: Fabio Estevam <festevam@gmail.com>
Enable the Hantro decoder driver so it can be enabled by
default on i.MX8M and Rockchip platforms.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/configs/defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 1f673b00c5f5..1a5669a73c01 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -919,6 +919,9 @@ CONFIG_VIRTIO_MMIO=y
CONFIG_XEN_GNTDEV=y
CONFIG_XEN_GRANT_DEV_ALLOC=y
CONFIG_MFD_CROS_EC_DEV=y
+CONFIG_STAGING=y
+CONFIG_STAGING_MEDIA=y
+CONFIG_VIDEO_HANTRO=m
CONFIG_CHROME_PLATFORMS=y
CONFIG_CROS_EC=y
CONFIG_CROS_EC_I2C=y
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/3] Librem 5 phone dts fixes
2021-03-15 8:35 ` [PATCH v2 0/3] Librem 5 phone dts fixes Martin Kepplinger
` (2 preceding siblings ...)
2021-03-15 8:35 ` [PATCH v2 3/3] arm64: defconfig: Enable the Hantro decoder Martin Kepplinger
@ 2021-03-17 7:59 ` Shawn Guo
3 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2021-03-17 7:59 UTC (permalink / raw)
To: Martin Kepplinger
Cc: devicetree, festevam, kernel, kernel, krzk, linux-arm-kernel,
linux-kernel, phone-devel, robh
On Mon, Mar 15, 2021 at 09:35:28AM +0100, Martin Kepplinger wrote:
> Two fixes for the Librem 5 phone descriptions and one resend of
> https://lore.kernel.org/linux-arm-kernel/20200915141622.14736-1-festevam@gmail.com/
> that enables the hantro vpu staging driver. Feel free to ignore that one
> if we want to wait for it to be out of staging.
>
> revision history
> ----------------
> v2: (thanks Shawn)
> * fix commit hash in commit message
>
> v1:
> * https://lore.kernel.org/phone-devel/20210311120259.3310499-1-martin.kepplinger@puri.sm/T/
>
> Fabio Estevam (1):
> arm64: defconfig: Enable the Hantro decoder
>
> Guido Günther (1):
> arm64: dts: imx8mq-librem5: Hog the correct gpio
>
> Sebastian Krzyszkowiak (1):
> arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on
Applied all, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread