phone-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@pengutronix.de, festevam@gmail.com,
	krzk@kernel.org, kernel@puri.sm, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Subject: Re: [PATCH 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on
Date: Mon, 15 Mar 2021 15:24:30 +0800	[thread overview]
Message-ID: <20210315072429.GQ11246@dragon> (raw)
In-Reply-To: <20210311120259.3310499-3-martin.kepplinger@puri.sm>

On Thu, Mar 11, 2021 at 01:02:58PM +0100, Martin Kepplinger wrote:
> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> 
> Commit 66d3f246d79f ("arm64: dts: librem5: Don't mark buck3 as always on")

I cannot find this commit.

Shawn

> removed always-on marking from GPU regulator, which is great for power
> saving - however it introduces additional i2c0 traffic which can be deadly
> for devices from the Dogwood batch.
> 
> To workaround the i2c0 shutdown issue on Dogwood, this commit marks
> buck3 as always-on again - but only for Dogwood (r3).
> 
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
> index 0d38327043f8..cd3c3edd48fa 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
> @@ -28,6 +28,10 @@ &bq25895 {
>  	ti,termination-current = <144000>;  /* uA */
>  };
>  
> +&buck3_reg {
> +	regulator-always-on;
> +};
> +
>  &proximity {
>  	proximity-near-level = <25>;
>  };
> -- 
> 2.30.1
> 

  reply	other threads:[~2021-03-15  7:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 12:02 [PATCH 0/3] Librem 5 phone dts fixes Martin Kepplinger
2021-03-11 12:02 ` [PATCH 1/3] arm64: dts: imx8mq-librem5: Hog the correct gpio Martin Kepplinger
2021-03-11 12:02 ` [PATCH 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on Martin Kepplinger
2021-03-15  7:24   ` Shawn Guo [this message]
2021-03-11 12:02 ` [PATCH 3/3] arm64: defconfig: Enable the Hantro decoder Martin Kepplinger
2021-03-15  8:35 ` [PATCH v2 0/3] Librem 5 phone dts fixes Martin Kepplinger
2021-03-15  8:35   ` [PATCH v2 1/3] arm64: dts: imx8mq-librem5: Hog the correct gpio Martin Kepplinger
2021-03-15  8:35   ` [PATCH v2 2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on Martin Kepplinger
2021-03-15  8:35   ` [PATCH v2 3/3] arm64: defconfig: Enable the Hantro decoder Martin Kepplinger
2021-03-17  7:59   ` [PATCH v2 0/3] Librem 5 phone dts fixes Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315072429.GQ11246@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.krzyszkowiak@puri.sm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).