From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7993CC43219 for ; Fri, 13 May 2022 09:26:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231823AbiEMJ0k (ORCPT ); Fri, 13 May 2022 05:26:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379070AbiEMJ0V (ORCPT ); Fri, 13 May 2022 05:26:21 -0400 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [IPv6:2001:4b7a:2000:18::168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F18713CF4 for ; Fri, 13 May 2022 02:25:59 -0700 (PDT) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 01CE13F4CB; Fri, 13 May 2022 11:25:52 +0200 (CEST) Date: Fri, 13 May 2022 11:25:51 +0200 From: Marijn Suijten To: Krzysztof Kozlowski Cc: phone-devel@vger.kernel.org, Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] arm64: dts: qcom: Add PM6125 PMIC Message-ID: <20220513092551.hvz5jvej57cgvavj@SoMainline.org> Mail-Followup-To: Marijn Suijten , Krzysztof Kozlowski , phone-devel@vger.kernel.org, Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220511220613.1015472-1-marijn.suijten@somainline.org> <20220511220613.1015472-6-marijn.suijten@somainline.org> <7c7f7036-e3ad-c9db-2c31-749e2d01e83d@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c7f7036-e3ad-c9db-2c31-749e2d01e83d@linaro.org> Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On 2022-05-13 10:24:04, Krzysztof Kozlowski wrote: > On 12/05/2022 00:06, Marijn Suijten wrote: > > This PMIC is commonly used on boards with an SM6125 SoC and looks very > > similar in layout to the PM6150. > > > > Downstream declares more nodes to be available, but these have been > > omitted from this patch: the pwm/lpg block is unused on my reference > > device making it impossible to test/validate, and the spmi-clkdiv does > > not have a single device-tree binding using this driver yet, hence > > inclusion is better postponed until ie. audio which uses these clocks is > > brought up. > > > > Signed-off-by: Marijn Suijten > > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: Konrad Dybcio > > Two reviews on first patch... :) Same story here, we review each-others patches in advance and it'd be annoying to have them re-send their approval through the mailing list; only for me/us to pick it up in a v2. > > + > > + pmic@1 { > > + compatible = "qcom,pm6125", "qcom,spmi-pmic"; > > + reg = <0x1 SPMI_USID>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > No children, so this should not be needed, I think. The size-cells or the entire node? There's a PWM/LPG block here according to downstream DT, but my device doesn't use it so I can't test that it is valid. I can add it anyway, presuming reviewers here have the ability to validate it for me with a reference manual. - Marijn