From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA12C05027 for ; Tue, 14 Mar 2023 18:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbjCNSjE (ORCPT ); Tue, 14 Mar 2023 14:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbjCNSjA (ORCPT ); Tue, 14 Mar 2023 14:39:00 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75FABAB895 for ; Tue, 14 Mar 2023 11:38:33 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id ek18so34755377edb.6 for ; Tue, 14 Mar 2023 11:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678819077; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AuNgNT8D0EuAh1HyRh/9mY626Vq0K4RuneWS+CDoRGU=; b=Z7HmxYoFox3cYFH2X6pUtjUx/WnphBH2dLE5baDvxTm+8HmhZ51ONlfq1+vZizz00h MoqUdQkitikl3II9OovJ4SC3MFkTFAw46SGbkPz15Owf5BiDozeQi6p+8f2X38Cq76E7 ElMQL463kCFMmYsVcz/MNnLTUiOizY4q/YfXVpNmJUQTUV50vj7E2uSLbW0e0vtrO7w+ cpmAQJaoQ2fbNB28vatFWPR8oM9oLnenPp4BKV0GvkSPZPN08f+OdibGUcu50pUufVfY oFtfomlpuUB2xBSXPjQjskd1kssmf6ASvqK/W45Nhl4a1QjhmRPD1Sg3oNi0diUB9M/T ISjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678819077; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AuNgNT8D0EuAh1HyRh/9mY626Vq0K4RuneWS+CDoRGU=; b=PY3kp6deX1ArrLuteSICvtNih2zZhCEbGx6Fr6XzPJttZZsAGEdV+0Vdzv++mQ7X9x WTEBN1GrAMOTvxw3PkFpSn2DxJa2jDjOVQ0FaJJHfgw5gGIPxC+l8k7RxWMTGfdUhD5Z q96YomO84K2WeAolgpyhVIjh93MmTJy9c5RL01nUxk/cQfkz25DPoJABPwBhrvMLnhBb a384KV5uav9VHrF3BP0OaB46xifVoBlFX8ZXgFqDCkBq/kePIVnrUGGulNYaG3u1H5gV SrFbo/X+xkh431lobvrNTVkwot9LX0AT1oVDie3PV+0IT2FbGaTunsIpAE73X/+Xn120 +3SQ== X-Gm-Message-State: AO0yUKV0K0P6vsS3NikAqgUQULb2TdUHJVRmdcP2T+ZUp6CDSf+tqRv0 lHCCdaY77+oH9A9JoYKwFlMCuA== X-Google-Smtp-Source: AK7set82bOBTZKdRnxAk1qFAzf9YFnq6NVKrvZuczwCT2pLIE3So1K51eTrLk738WixzMw0wwDDxJg== X-Received: by 2002:a17:906:1b10:b0:870:baa6:6762 with SMTP id o16-20020a1709061b1000b00870baa66762mr3679366ejg.14.1678819076802; Tue, 14 Mar 2023 11:37:56 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:59be:4b3f:994b:e78c? ([2a02:810d:15c0:828:59be:4b3f:994b:e78c]) by smtp.gmail.com with ESMTPSA id c20-20020a50f614000000b004d8d2735251sm1436152edn.43.2023.03.14.11.37.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 11:37:56 -0700 (PDT) Message-ID: <7fc9a289-5317-6a40-73f1-b816083af8d1@linaro.org> Date: Tue, 14 Mar 2023 19:37:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] media: dt-bindings: ov2685: convert to dtschema Content-Language: en-US From: Krzysztof Kozlowski To: Rob Herring , Luca Weiss Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , ~postmarketos/upstreaming@lists.sr.ht, Krzysztof Kozlowski , linux-media@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Shunqian Zheng , phone-devel@vger.kernel.org References: <20230206-ov2685-dtschema-v1-1-9e4da3474c10@z3ntu.xyz> <167572017056.1564123.13342855865502188090.robh@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On 14/03/2023 19:37, Krzysztof Kozlowski wrote: > On 06/02/2023 22:50, Rob Herring wrote: >> >> On Mon, 06 Feb 2023 21:23:16 +0100, Luca Weiss wrote: >>> Convert the text-based dt-bindings to yaml. >>> >>> Changes from original txt: >>> * Take wording for various properties from other yaml bindings, this >>> removes e.g. volt amount from schema since it isn't really relevant >>> and the datasheet is a better source. >>> * Don't make reset-gpios a required property since it can be tied to >>> DOVDD instead. >>> >>> Signed-off-by: Luca Weiss >>> --- >>> .../devicetree/bindings/media/i2c/ov2685.txt | 41 --------- >>> .../devicetree/bindings/media/i2c/ovti,ov2685.yaml | 101 +++++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 3 files changed, 102 insertions(+), 41 deletions(-) >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'clocks' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'clock-names' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'dvdd-supply' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'avdd-supply' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'dovdd-supply' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml > > These are errors from the bindings, so they must be fixed. If you do not > want to fix the rockchip bindings, just drop or replace the sensor in them. Or one more: add some fake stubs. They do not matter anyway... Best regards, Krzysztof