From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4674BC433DB for ; Sat, 30 Jan 2021 16:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19D5864E0A for ; Sat, 30 Jan 2021 16:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230360AbhA3QUl (ORCPT ); Sat, 30 Jan 2021 11:20:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232262AbhA3Pnx (ORCPT ); Sat, 30 Jan 2021 10:43:53 -0500 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [IPv6:2001:4b7a:2000:18::168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50AD6C061786 for ; Sat, 30 Jan 2021 07:42:41 -0800 (PST) Received: from [192.168.1.101] (abaf219.neoplus.adsl.tpnet.pl [83.6.169.219]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 542643EBA4; Sat, 30 Jan 2021 16:42:38 +0100 (CET) Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: msm8916-alcatel-idol347: Add framebuffer support To: Vincent Knecht , phone-devel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Rob Herring , Andy Gross , Bjorn Andersson , Sam Ravnborg , Krzysztof Kozlowski , Arnd Bergmann , Shawn Guo , Daniel Palmer , Oleksij Rempel , allen , Max Merchel , Kuninori Morimoto , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20210130105717.2628781-1-vincent.knecht@mailoo.org> <20210130105717.2628781-5-vincent.knecht@mailoo.org> From: Konrad Dybcio Message-ID: <8edef364-e60e-2bc1-ffef-1f30dd2fffaf@somainline.org> Date: Sat, 30 Jan 2021 16:42:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210130105717.2628781-5-vincent.knecht@mailoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On 30.01.2021 11:57, Vincent Knecht wrote: > Add simple-framebuffer support and related reserved-memory block. > > Signed-off-by: Vincent Knecht > --- > .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts > index 540b1fa4b260..e4d22cec8ff0 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts > +++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts > @@ -3,6 +3,7 @@ > /dts-v1/; > > #include "msm8916-pm8916.dtsi" > +#include > #include > #include > > @@ -16,6 +17,36 @@ aliases { > > chosen { > stdout-path = "serial0"; > + > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + framebuffer0: framebuffer@83200000 { > + status = "okay"; > + compatible = "simple-framebuffer"; > + reg = <0x0 0x83200000 0x0 (720 * 1280 * 3)>; > + width = <720>; > + height = <1280>; > + stride = <(720 * 3)>; > + format = "r8g8b8"; > + power-domains = <&gcc MDSS_GDSC>; > + clocks = <&gcc GCC_MDSS_AHB_CLK>, > + <&gcc GCC_MDSS_VSYNC_CLK>, > + <&gcc GCC_MDSS_AXI_CLK>, > + <&gcc GCC_MDSS_MDP_CLK>, > + <&gcc GCC_MDSS_BYTE0_CLK>, > + <&gcc GCC_MDSS_PCLK0_CLK>, I'm not sure about BYTE/PCLK, it used to cause issues at least on my boards, but if it works for you, I guess it's only good. > + <&gcc GCC_MDSS_ESC0_CLK>, > + <&xo_board>; Fake XO seems redundant here. > + }; > + }; > + > + reserved-memory { > + continuous_splash: framebuffer@83000000 { > + reg = <0x0 0x83000000 0x0 0x1400000>; > + no-map; > + }; > }; > > gpio-keys { > Konrad