From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F450C433DB for ; Mon, 15 Mar 2021 19:18:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7141D64F44 for ; Mon, 15 Mar 2021 19:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233286AbhCOTSR (ORCPT ); Mon, 15 Mar 2021 15:18:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233280AbhCOTR6 (ORCPT ); Mon, 15 Mar 2021 15:17:58 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6353C06174A for ; Mon, 15 Mar 2021 12:17:57 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id p24so7496504ota.11 for ; Mon, 15 Mar 2021 12:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jaDJIbozHDomrvNHrqpon9HkLzG9r5TbsaSE94cHoXY=; b=n2V75PXggd6ZrjEgxJY17yUaCpyHvKCxlE1N8m6Y1gEka8kJuhPnBs9/VdgWyyet9J 1nUuQ2uXPGXBTs+6pxODo5CLF6rmeB/JdE8wq1nxO7onQBFPT1+DZHGSV9AK31OKElMe dN83YB+3uSr3Ii44IQhW+HzStDj8seXFzDcji+rCH1DNsLCxRlmbFmU6ufDcO0yUDKPY R8Fae2qMuu3taYVmcPXfsMkGyoaa12dWDAlFHwzKRWWvoUs8at/9iXdGXJhKV28rNDF2 dohtG1PlWiXCNoQ8hPvTNfNGAxy2J86VunLFwdbIAfzzpqhY8vWwHiXKLg8rYHMW0UTB aRKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jaDJIbozHDomrvNHrqpon9HkLzG9r5TbsaSE94cHoXY=; b=oiDkNpJEP/0Yj519oX8cUUfMjVp4DeH3/dyOyUPXbkg5EUs0hIgoJcYjrr39vy2ibP Jv14ifn89Fso1WiErbuYeBnIlbL46lq/FF/yVhFX7bgcL0Zc/90AXT6B9a1xZw8lBQ5c Vh6cQIeR02qL1XtZ0VyVncPb3VPK5AEFqGTOniR76ZXTT4MHkJuyVgw1s6W38uFLRVzB mTSTLDAzOln+EBPl88vfR5XtpB7pnhAKc8DArlV8hEL11hc3Efvq+kfl3R1YUiOs+jC7 Xf1qJ/mrqSasNb9U/uXQTU0Y+hyWJn6kDGTNHvKpcPsH6X52gUVIsO2dobc2jUzFGnfv 6Xqg== X-Gm-Message-State: AOAM531eSE6PgVM6ewxCDUHGFW1zK5l9tpqpb/TxLM6Qwz6dVIe92TyQ 9KaaP9tg20xakYU2cXb74aoPWsmdGK86IuIiT1pWAQ== X-Google-Smtp-Source: ABdhPJw7m9FtaQnuJGDdSC12kGTvOQr6etwvoPeE1fqnJsiPEMefAdL97cCH5GhLabo/CTgr3Rcss3VDoANIwhdOJbk= X-Received: by 2002:a05:6830:1513:: with SMTP id k19mr479331otp.51.1615835877310; Mon, 15 Mar 2021 12:17:57 -0700 (PDT) MIME-Version: 1.0 References: <20210310163024.393578-1-caleb@connolly.tech> <20210310163024.393578-2-caleb@connolly.tech> In-Reply-To: <20210310163024.393578-2-caleb@connolly.tech> From: Bhupesh Sharma Date: Tue, 16 Mar 2021 00:47:46 +0530 Message-ID: Subject: Re: [PATCH 1/3] arm64: dts: qcom: sm8150: add other QUP nodes To: Caleb Connolly Cc: Andy Gross , Bjorn Andersson , Rob Herring , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org Hello Caleb, On Wed, 10 Mar 2021 at 22:02, Caleb Connolly wrote: > > Add the first and third qupv3 nodes used to hook > up peripherals on some devices. > > Signed-off-by: Caleb Connolly > --- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index e5bb17bc2f46..03e05d98daf2 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -577,6 +577,18 @@ gcc: clock-controller@100000 { > <&sleep_clk>; > }; > > + qupv3_id_0: geniqup@8c0000 { > + compatible = "qcom,geni-se-qup"; > + reg = <0x0 0x008c0000 0x0 0x6000>; > + clock-names = "m-ahb", "s-ahb"; > + clocks = <&gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>, > + <&gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + status = "disabled"; > + }; > + > qupv3_id_1: geniqup@ac0000 { > compatible = "qcom,geni-se-qup"; > reg = <0x0 0x00ac0000 0x0 0x6000>; > @@ -598,6 +610,19 @@ uart2: serial@a90000 { > }; > }; > > + qupv3_id_2: geniqup@cc0000 { > + compatible = "qcom,geni-se-qup"; > + reg = <0x0 0x00cc0000 0x0 0x6000>; > + > + clock-names = "m-ahb", "s-ahb"; > + clocks = <&gcc GCC_QUPV3_WRAP_2_M_AHB_CLK>, > + <&gcc GCC_QUPV3_WRAP_2_S_AHB_CLK>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + status = "disabled"; > + }; > + > config_noc: interconnect@1500000 { > compatible = "qcom,sm8150-config-noc"; > reg = <0 0x01500000 0 0x7400>; LGTM, so: Reviewed-by: Bhupesh Sharma