From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BD1C433DB for ; Thu, 14 Jan 2021 22:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D7282339E for ; Thu, 14 Jan 2021 22:38:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730607AbhANWiM (ORCPT ); Thu, 14 Jan 2021 17:38:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730575AbhANWiL (ORCPT ); Thu, 14 Jan 2021 17:38:11 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 678B0C061575; Thu, 14 Jan 2021 14:37:31 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id r9so14486238ioo.7; Thu, 14 Jan 2021 14:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4qLi4Dg+g0R8VVN/tPzeo2VYp9du8E2CQ9jumM2kylY=; b=NtqJtobesGpygwwHl27SLj7KgMDYD0qtl1D5q8Nmm2wV3x8Ucca6+xgsshGaup/SNQ aG7ZxHs8AK37B2SX+ZKtWjTaZ2ux9jKIqo9UglY86v5u+ormp/fjckWHn5fOcKUjCrkG oWPEGNe4ggbEXV/MkouOsZh1nd/WLTAF++ifhve+NaZ2GJOs3pK46HhbxhRVkI8UuDzc gF4PrmfODCHNmGOeFfz0+vyAefyKXE8wCk6gbspznmeD3IQYi+0TuooHr+Oj82jacfLP OkmYREy+giTCsaJWXiZJtexkPbmi4+vmy0Jro9BFH9Xoe5i2nlpqMUcotF0namByg8wN UQJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4qLi4Dg+g0R8VVN/tPzeo2VYp9du8E2CQ9jumM2kylY=; b=FrL2uWqOPCPXfunY2RgJR/HfTqByuW/HZjPbX0UtAGJYuQsR47hU9ORXyNugW0u8tK k/pwgS/s/KOulnwSUy3VQOz8wtyN5OzztbjIEriYQJSFNfNm0wWwkV90G7XxFixCekEt ZS3eDCZCCK2Si8vU9aDNjhdBzY80ezQHIzXuNRDqntNWq9BMLMt3WKEplVsDEJ/wEQJN xwK8wBdbCuRG3B8TUuONwtYbKHxoZJcdeQllreaI+TQh5ofJ/2n/4nrh9reUWD1WQnFz xpchhM0vLJ5wns7lSZpt8Ygaa9LwL9ht22SUmLErc8nFwV6Q/IshS+g67Ib38Tvfh1Xe 5uCw== X-Gm-Message-State: AOAM531ddyKlytlKFexXygPcqDlXwE+bHlAmTK0PahSLAHWG293xCGVy 5jhDVxByAkms27xvE09nvANhjxoHiSBVvmkHgzT6bt/VZrw= X-Google-Smtp-Source: ABdhPJxAE3niWU3lMdhyD6iZZ//AvuDx07evfAw+VuR6wmjklOvnVeCLdNX4LfeC8wYdvKKrdETMSGGhrNGKnwhmnFU= X-Received: by 2002:a05:6e02:1b8b:: with SMTP id h11mr8628774ili.32.1610663850911; Thu, 14 Jan 2021 14:37:30 -0800 (PST) MIME-Version: 1.0 References: <20210114221059.483390-1-angelogioacchino.delregno@somainline.org> <20210114221059.483390-6-angelogioacchino.delregno@somainline.org> In-Reply-To: <20210114221059.483390-6-angelogioacchino.delregno@somainline.org> From: Jeffrey Hugo Date: Thu, 14 Jan 2021 15:37:20 -0700 Message-ID: Subject: Re: [PATCH v2 05/11] clk: qcom: gcc-msm8998: Mark gpu_cfg_ahb_clk as critical To: AngeloGioacchino Del Regno Cc: MSM , konrad.dybcio@somainline.org, marijn.suijten@somainline.org, martin.botka@somainline.org, phone-devel@vger.kernel.org, lkml , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , linux-clk@vger.kernel.org, DTML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On Thu, Jan 14, 2021 at 3:13 PM AngeloGioacchino Del Regno wrote: > > The GPU IOMMU depends on this clock and the hypervisor will crash > the SoC if this clock gets disabled because the secure contexts > that have been set on this IOMMU by the bootloader will become > unaccessible (or they get reset). > Mark this clock as critical to avoid this issue when the Adreno > GPU is enabled. > You should go review the last attempt to do this - https://lkml.org/lkml/2019/12/17/881