From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B3DBC4320A for ; Thu, 2 Sep 2021 13:05:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64538610E6 for ; Thu, 2 Sep 2021 13:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344729AbhIBNGg (ORCPT ); Thu, 2 Sep 2021 09:06:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344693AbhIBNGg (ORCPT ); Thu, 2 Sep 2021 09:06:36 -0400 Received: from relay05.th.seeweb.it (relay05.th.seeweb.it [IPv6:2001:4b7a:2000:18::166]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37760C061575 for ; Thu, 2 Sep 2021 06:05:38 -0700 (PDT) Received: from Marijn-Arch-Book.localdomain (D57D4C6E.static.ziggozakelijk.nl [213.125.76.110]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id CC4D03F215; Thu, 2 Sep 2021 15:05:35 +0200 (CEST) Date: Thu, 2 Sep 2021 15:05:34 +0200 From: Marijn Suijten To: Stephen Boyd Cc: Bjorn Andersson , linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Andy Gross , Michael Turquette , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Dmitry Baryshkov , Abhinav Kumar , Jonathan Marek , Matthias Kaehlcke , Douglas Anderson , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock Message-ID: References: <20210830182445.167527-1-marijn.suijten@somainline.org> <20210830182445.167527-3-marijn.suijten@somainline.org> <163047455623.42057.15513441659841056105@swboyd.mtv.corp.google.com> <163055439497.405991.16122720273000010218@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163055439497.405991.16122720273000010218@swboyd.mtv.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On 2021-09-01 20:46:34, Stephen Boyd wrote: > Quoting Marijn Suijten (2021-09-01 01:57:15) > > On 2021-08-31 22:35:56, Stephen Boyd wrote: > > > Quoting Marijn Suijten (2021-08-30 11:24:45) > > > > The DSI PHY/PLL was relying on a global "xo" clock to be found, but the > > > > real clock is named "xo_board" in the DT. The standard nowadays is to > > > > never use global clock names anymore but require the firmware (DT) to > > > > provide every clock binding explicitly with .fw_name. The DSI PLLs have > > > > since been converted to this mechanism (specifically 14nm for SDM660) > > > > and this transient clock can now be removed. > > > > > > > > This issue was originally discovered in: > > > > https://lore.kernel.org/linux-arm-msm/386db1a6-a1cd-3c7d-a88e-dc83f8a1be96@somainline.org/ > > > > and prevented the removal of "xo" at that time. > > > > > > > > Signed-off-by: Marijn Suijten > > > > --- > > > > > > Presumably this wants to go with the first one. > > > > What are you referring to with "the first one"? This patch can only go > > in after patch 1/2 of this series, unless you are suggesting to squash > > it with Bjorns cleanup and making sure that lands after the fix in the > > DSI? > > The first patch in this series. Are you suggesting to squash this patch into the first patch in this series? Note that the first patch touches drm/msm/dsi, the second (this) patch touches clk/qcom.