From: Vincent Knecht <vincent.knecht@mailoo.org>
To: phone-devel@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
Stephan Gerhold <stephan@gerhold.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
Linus Walleij <linus.walleij@linaro.org>,
Michael Srba <Michael.Srba@seznam.cz>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] Input: add MStar MSG2638 touchscreen driver
Date: Wed, 07 Apr 2021 23:47:55 +0200 [thread overview]
Message-ID: <cfba65e2a8cc2cbcee7cf088a53a226788619b04.camel@mailoo.org> (raw)
In-Reply-To: <20210305153815.126937-2-vincent.knecht@mailoo.org>
Le vendredi 05 mars 2021 à 16:38 +0100, Vincent Knecht a écrit :
> Add support for the msg2638 touchscreen IC from MStar.
> Firmware handling, wakeup gestures and other specialties are not supported.
> This driver reuses zinitix.c structure, while the checksum and irq handler
> functions are based on out-of-tree driver for Alcatel Idol 3 (4.7").
>
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
> Changed in v6:
> - minor formatting changes
> - mention wakeup gestures not being supported (yet?) in commit message
> - do not scale coordinates in the driver (Dmitry)
> - multiple suggestions from Linus W.
> - include linux/gpio/consumer.h instead of linux/gpio.h
> - rename delay defines to include time unit like _MS and _US
> - rename `error` variable to `ret`
> - move enable_irq() call from msg2638_power_on() to msg2638_start()
> - remove CONFIG_OF #ifdef around of_device_id struct
Hello,
just a little gentle ping: do I need to change anything to get this merged ?
So far seems to work fine with idol347 port of postmarketOS :-)
next prev parent reply other threads:[~2021-04-07 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 15:38 [PATCH v6 1/2] dt-bindings: input/touchscreen: add bindings for msg2638 Vincent Knecht
2021-03-05 15:38 ` [PATCH v6 2/2] Input: add MStar MSG2638 touchscreen driver Vincent Knecht
2021-03-10 23:18 ` Linus Walleij
2021-04-07 21:47 ` Vincent Knecht [this message]
2021-04-09 22:17 ` Dmitry Torokhov
2021-03-08 22:18 ` [PATCH v6 1/2] dt-bindings: input/touchscreen: add bindings for msg2638 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfba65e2a8cc2cbcee7cf088a53a226788619b04.camel@mailoo.org \
--to=vincent.knecht@mailoo.org \
--cc=Michael.Srba@seznam.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).