platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David E. Box" <david.e.box@linux.intel.com>
To: Joe Perches <joe@perches.com>,
	hdegoede@redhat.com, mgross@linux.intel.com,
	andriy.shevchenko@linux.intel.com
Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86/intel: Move Intel PMT drivers to new subfolder
Date: Tue, 27 Jul 2021 07:53:41 -0700	[thread overview]
Message-ID: <00527c09b0d4f22652f9cd5c2fde4e091df2d610.camel@linux.intel.com> (raw)
In-Reply-To: <45ccb9e8c610678e72f461b1e9d61de0a4c9bc79.camel@perches.com>

On Mon, 2021-07-26 at 20:36 -0700, Joe Perches wrote:
> On Mon, 2021-07-26 at 19:25 -0700, David E. Box wrote:
> > Move all Intel Platform Monitoring Technology drivers to
> > drivers/platform/x86/intel/pmt.
> []
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -9494,7 +9494,7 @@ INTEL PMT DRIVER
> >  M:     "David E. Box" <david.e.box@linux.intel.com>
> >  S:     Maintained
> >  F:     drivers/mfd/intel_pmt.c
> > -F:     drivers/platform/x86/intel_pmt_*
> > +F:     drivers/platform/x86/intel/pmt/*
> 
> Unless you are suggesting you are not maintainer of any files
> in any subdirectories below this directory, you should not use
> a *
> 
> F:      drivers/platform/x86/intel/pmt/

Ack

> 
> > diff --git a/drivers/platform/x86/intel/Makefile
> > b/drivers/platform/x86/intel/Makefile
> []
> > @@ -7,3 +7,4 @@
> >  obj-$(CONFIG_INTEL_CHT_INT33FE)                += int33fe/
> >  obj-$(CONFIG_INTEL_SKL_INT3472)                += int3472/
> >  obj-$(CONFIG_INTEL_PMC_CORE)           += pmc/
> > +obj-y                                  += pmt/
> 
> This seems odd.  Perhaps:
> 
> obj-$(CONFIG_PMT_CLASS)                         += pmt/

This would work.

Thanks



      reply	other threads:[~2021-07-27 14:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27  2:25 [PATCH v2] platform/x86/intel: Move Intel PMT drivers to new subfolder David E. Box
2021-07-27  3:36 ` Joe Perches
2021-07-27 14:53   ` David E. Box [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00527c09b0d4f22652f9cd5c2fde4e091df2d610.camel@linux.intel.com \
    --to=david.e.box@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).