Re: [PATCH v3 00/20] Intel platform driver code movement

From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Kate Hsuan <hpa@redhat.com>, Alex Hung <alex.hung@canonical.com>,
	Mark Gross <mgross@linux.intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	AceLan Kao <acelan.kao@canonical.com>,
	Jithu Joseph <jithu.joseph@intel.com>,
	Maurice Ma <maurice.ma@intel.com>,
	Sujith Thomas <sujith.thomas@intel.com>,
	Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
	Zha Qipeng <qipeng.zha@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"David E . Box" <david.e.box@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dell.Client.Kernel@dell.com,
	Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v3 00/20] Intel platform driver code movement
Date: Thu, 19 Aug 2021 15:34:37 +0200	[thread overview]
Message-ID: <07cfd37a-cce6-56f2-0ff1-d4daeccfc67c@redhat.com> (raw)
In-Reply-To: <a5e52890-c162-ab48-4858-3eb0e971e5a1@redhat.com>

Hi,

On 8/19/21 3:31 PM, Hans de Goede wrote:
> Hi,
> 
> On 8/19/21 2:14 PM, Andy Shevchenko wrote:
>> On Thu, Aug 19, 2021 at 3:03 PM Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>>> On Thu, Aug 19, 2021 at 1:48 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>>
>>>
>>>> Thank you for your patch-series, I've applied the series to my
>>>> review-hans branch:
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>>>>
>>>> With the changes mentioned in replies to individual patches.
>>>
>>> Can we postpone this a bit, please?
>>>
>>> I have a few comments here and there. I'll send asap.
>>
>> Hmm... It seems it will take less time if I simply take what you have
>> in your repo and produce a v4.
>> Would it work?
> 
> That is fine by me, I might be better to just do a small follow-up patch
> though, given that you seem to only have a few small remarks.
> 
> But if you prefer to do a v4 that is fine too. I was planning on
> keeping this in review-hans for a while anyways.
> 
> I did notice the couple of stray changes which you pointed out but
> they get corrected by other commits (or are removal of extra whitespace
> left-over from other commits), so I decided that they were harmless
> since the end-result Makefile / Kconfig files were good.

p.s.

Note that drivers/platform/x86/intel_ips.h is deliberately not moved
(for now) since it is also used by the i915 driver.

My plan is to merge a follow-up patch moving that through drm-intel-next
once 5.15-rc1 is out.

Regards,

Hans