From: Hans de Goede <hdegoede@redhat.com>
To: Mark Gross <markgross@kernel.org>, Andy Shevchenko <andy@kernel.org>
Cc: platform-driver-x86@vger.kernel.org,
kernel test robot <lkp@intel.com>, Tom Rix <trix@redhat.com>
Subject: Re: [PATCH v2] platform/x86: x86-android-tablets: Add depends on PMIC_OPREGION
Date: Sat, 11 Mar 2023 12:06:59 +0100 [thread overview]
Message-ID: <089d973c-c878-3750-2b37-808213ac2f50@redhat.com> (raw)
In-Reply-To: <20230309094035.18736-1-hdegoede@redhat.com>
Hi,
On 3/9/23 10:40, Hans de Goede wrote:
> Add a depends on PMIC_OPREGION to x86-android-tablets Kconfig to fix
> the following build error:
>
> ERROR: modpost: "intel_soc_pmic_exec_mipi_pmic_seq_element"
> [drivers/platform/x86/x86-android-tablets/x86-android-tablets.ko] undefined!
>
> Fixes: 9b1d2662b8c5 ("platform/x86: x86-android-tablets: Add touchscreen support for Lenovo Yoga Tab 3 Pro YT3-X90F")
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303091711.howZNrIY-lkp@intel.com/
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> - Add Fixes tag
I've pushed this out to the pdx86/for-next branch now.
Regards,
Hans
> ---
> drivers/platform/x86/x86-android-tablets/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/x86-android-tablets/Kconfig b/drivers/platform/x86/x86-android-tablets/Kconfig
> index 2b3daca5380b..6603461d4273 100644
> --- a/drivers/platform/x86/x86-android-tablets/Kconfig
> +++ b/drivers/platform/x86/x86-android-tablets/Kconfig
> @@ -5,7 +5,7 @@
>
> config X86_ANDROID_TABLETS
> tristate "X86 Android tablet support"
> - depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB
> + depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB && PMIC_OPREGION
> help
> X86 tablets which ship with Android as (part of) the factory image
> typically have various problems with their DSDTs. The factory kernels
prev parent reply other threads:[~2023-03-11 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 9:40 [PATCH v2] platform/x86: x86-android-tablets: Add depends on PMIC_OPREGION Hans de Goede
2023-03-11 11:06 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=089d973c-c878-3750-2b37-808213ac2f50@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=lkp@intel.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).