From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25CF5C19F2B for ; Wed, 27 Jul 2022 04:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240325AbiG0EYp (ORCPT ); Wed, 27 Jul 2022 00:24:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240334AbiG0EYm (ORCPT ); Wed, 27 Jul 2022 00:24:42 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3B7853C8F5 for ; Tue, 26 Jul 2022 21:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658895880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yok+W8J1zKJN3VSngD/6A5xyt1kdGDnR3MRcZGx2JdM=; b=EEa1dTbUHCLVoUMUwqn5beN/6drv9TsHCmYZ6D55zq2qfen1T2U5tkZyOr1Z54gzb4B/Fd CJXtU5V9n7bLJw74L0DVMhh3ka8iX4P+PBZg3f1mQYMpidXVdqll9YeAPVm1qLz2H3sd5+ j8fd9MSi41MUCnpsLXR0N6VIeG4K9D8= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-p47RdKZNNdyg1dDonuhX4Q-1; Wed, 27 Jul 2022 00:24:36 -0400 X-MC-Unique: p47RdKZNNdyg1dDonuhX4Q-1 Received: by mail-pg1-f197.google.com with SMTP id r142-20020a632b94000000b0041a18177a5dso7326255pgr.10 for ; Tue, 26 Jul 2022 21:24:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Yok+W8J1zKJN3VSngD/6A5xyt1kdGDnR3MRcZGx2JdM=; b=F2Zb8fjzzcCZ+SPC7b39nfL3tU9PaAtqDkEGHTMXsCrjV76pla1ceBTbR0yah3BjrX CrFbAT40UijbHRFCJ7xcpQhCtMqAdJ5eDUjxJ5QmbwmzyxxdNlU8LaFi3y5fHJoFZZlB 4EtFaVTux+vU5tMIbnqEFQ6LFb3h7DpgVMmX8j3L7YuwNHcPn9q2yEMTve8xPrK0LG3v UXwnFORCgC3kbVrTE9VR4dcq3u+0AQMV5ScwXqYu1VhzhJPiYRHgxKiKRt+zD/XVu+zz 2+cZYFkeuilTvqH7/DSLRUWNjR87BVTjG8Vjpe8b2V7iAeQKW0BkarxJbfDcRof54OZY FjlA== X-Gm-Message-State: AJIora+8MB6EYBuezmhY03thhSV1EDIUsZJ8X9AWsRnPupExOMCbqHM3 x7CVrkoWS9IdYeMVOAX230Hc7F4OncqKx6ADO+ZKLcmX5AnIzdj+2GDtUWlyhaxnC3yUEfu4tly gy24IlZRUF3PZV1bzBGKYLDBVN98MMPi1zA== X-Received: by 2002:a17:90a:ea90:b0:1f2:81cd:1948 with SMTP id h16-20020a17090aea9000b001f281cd1948mr2513894pjz.172.1658895875897; Tue, 26 Jul 2022 21:24:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1shgnF0FTkAghWAebt2dLxHjIMnalV8dd87lEKXX5Ir9vcvUUz2DeWLC6lS50voh4OTJ1rbZA== X-Received: by 2002:a17:90a:ea90:b0:1f2:81cd:1948 with SMTP id h16-20020a17090aea9000b001f281cd1948mr2513861pjz.172.1658895875684; Tue, 26 Jul 2022 21:24:35 -0700 (PDT) Received: from [10.72.12.96] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id ik1-20020a170902ab0100b0016c48c52ce4sm12556176plb.204.2022.07.26.21.24.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 21:24:33 -0700 (PDT) Message-ID: <113b77e4-ccc5-7a92-60db-26c25c184e20@redhat.com> Date: Wed, 27 Jul 2022 12:24:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v13 17/42] virtio_ring: packed: introduce vring_free_packed Content-Language: en-US To: Xuan Zhuo , virtualization@lists.linux-foundation.org Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , "Michael S. Tsirkin" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com References: <20220726072225.19884-1-xuanzhuo@linux.alibaba.com> <20220726072225.19884-18-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220726072225.19884-18-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org 在 2022/7/26 15:22, Xuan Zhuo 写道: > Free the structure struct vring_vritqueue_packed. > > Subsequent patches require it. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang > --- > drivers/virtio/virtio_ring.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 58355e1ac7d7..891900b31c3d 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -1835,6 +1835,28 @@ static struct vring_desc_extra *vring_alloc_desc_extra(unsigned int num) > return desc_extra; > } > > +static void vring_free_packed(struct vring_virtqueue_packed *vring_packed, > + struct virtio_device *vdev) > +{ > + if (vring_packed->vring.desc) > + vring_free_queue(vdev, vring_packed->ring_size_in_bytes, > + vring_packed->vring.desc, > + vring_packed->ring_dma_addr); > + > + if (vring_packed->vring.driver) > + vring_free_queue(vdev, vring_packed->event_size_in_bytes, > + vring_packed->vring.driver, > + vring_packed->driver_event_dma_addr); > + > + if (vring_packed->vring.device) > + vring_free_queue(vdev, vring_packed->event_size_in_bytes, > + vring_packed->vring.device, > + vring_packed->device_event_dma_addr); > + > + kfree(vring_packed->desc_state); > + kfree(vring_packed->desc_extra); > +} > + > static struct virtqueue *vring_create_virtqueue_packed( > unsigned int index, > unsigned int num,