From: Hans de Goede <hdegoede@redhat.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
mgross@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, sfr@canb.auug.org.au
Subject: Re: [PATCH v2] platform/x86: ISST: Fix optimization with use of numa
Date: Thu, 12 Aug 2021 09:41:53 +0200 [thread overview]
Message-ID: <119ab09f-9aab-9980-c1d3-72decff43488@redhat.com> (raw)
In-Reply-To: <20210811033633.1204567-1-srinivas.pandruvada@linux.intel.com>
Hi,
On 8/11/21 5:36 AM, Srinivas Pandruvada wrote:
> When numa is used to map CPU to PCI device, the optimized path to read
> from cached data is not working and still calls _isst_if_get_pci_dev().
>
> The reason is that when caching the mapping, numa information is not
> available as it is read later. So move the assignment of
> isst_cpu_info[cpu].numa_node before calling _isst_if_get_pci_dev().
>
> Fixes: aa2ddd242572 ("platform/x86: ISST: Use numa node id for cpu pci dev mapping")
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> v2:
> Fixed "Fixes tag" as suggested by Stephen Rothwell
Thanks, but I just fixed this myself in the pdx86/for-next tree and I've
done a forced-push of for-next with the fixed Fixes tag.
Either way this is resolved now :)
Regards,
Hans
>
> Update:
> The fixes tag was wrong
> This patch can wait for next merge window as these systems are not
> shipped.
>
> drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> index 6f0cc679c8e5..8a4d52a9028d 100644
> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> @@ -379,6 +379,8 @@ static int isst_if_cpu_online(unsigned int cpu)
> u64 data;
> int ret;
>
> + isst_cpu_info[cpu].numa_node = cpu_to_node(cpu);
> +
> ret = rdmsrl_safe(MSR_CPU_BUS_NUMBER, &data);
> if (ret) {
> /* This is not a fatal error on MSR mailbox only I/F */
> @@ -397,7 +399,6 @@ static int isst_if_cpu_online(unsigned int cpu)
> return ret;
> }
> isst_cpu_info[cpu].punit_cpu_id = data;
> - isst_cpu_info[cpu].numa_node = cpu_to_node(cpu);
>
> isst_restore_msr_local(cpu);
>
>
prev parent reply other threads:[~2021-08-12 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 3:36 [PATCH v2] platform/x86: ISST: Fix optimization with use of numa Srinivas Pandruvada
2021-08-12 7:41 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=119ab09f-9aab-9980-c1d3-72decff43488@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).