From: Dave Hansen <dave.hansen@intel.com>
To: Martin Fernandez <martin.fernandez@eclypsium.com>,
linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, ardb@kernel.org,
dvhart@infradead.org, andy@infradead.org,
gregkh@linuxfoundation.org, rafael@kernel.org,
daniel.gutson@eclypsium.com, hughsient@gmail.com,
alison.schofield@intel.com, alex@eclypsium.com
Subject: Re: [PATCH 2/5] Extend pg_data_t to hold information about memory encryption
Date: Fri, 5 Nov 2021 16:30:57 -0700 [thread overview]
Message-ID: <12d32040-4869-f28f-550a-f85adec7eaa1@intel.com> (raw)
In-Reply-To: <20211105212724.2640-3-martin.fernandez@eclypsium.com>
On 11/5/21 2:27 PM, Martin Fernandez wrote:
> @@ -869,6 +869,8 @@ typedef struct pglist_data {
> unsigned long min_slab_pages;
> #endif /* CONFIG_NUMA */
>
> + bool crypto_capable;
When adding to a data structure, please take a moment and familiarize
yourself with it. For instance, would it make sense to have an
'enum pgdat_flags' for this as opposed to a bool?
Or, if you place it up next to the CONFIG_COMPACTION
proactive_compact_trigger, can it share storage? Placing it next to a
ulong is probably the worst place it can go.
next prev parent reply other threads:[~2021-11-05 23:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 21:27 [PATCH 0/5] x86: Show in sysfs if a memory node is able to do encryption Martin Fernandez
2021-11-05 21:27 ` [PATCH 1/5] Extend memblock to support memory encryption Martin Fernandez
2021-11-05 23:08 ` Dave Hansen
2021-11-05 21:27 ` [PATCH 2/5] Extend pg_data_t to hold information about " Martin Fernandez
2021-11-05 23:30 ` Dave Hansen [this message]
2021-11-05 21:27 ` [PATCH 3/5] Extend e820_table " Martin Fernandez
2021-11-05 23:39 ` Dave Hansen
2021-11-08 18:40 ` Martin Fernandez
2021-11-08 21:13 ` Dave Hansen
2021-11-09 19:16 ` Martin Fernandez
2021-11-05 21:27 ` [PATCH 4/5] Mark e820_entries as crypto capable from EFI memmap Martin Fernandez
2021-11-06 0:02 ` Dave Hansen
2021-11-05 21:27 ` [PATCH 5/5] Show in sysfs if a memory node is able to do encryption Martin Fernandez
2021-11-06 0:04 ` Dave Hansen
2021-11-06 0:49 ` [PATCH 0/5] x86: " Dave Hansen
2021-11-06 21:35 ` Williams, Dan J
2021-11-07 17:58 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12d32040-4869-f28f-550a-f85adec7eaa1@intel.com \
--to=dave.hansen@intel.com \
--cc=alex@eclypsium.com \
--cc=alison.schofield@intel.com \
--cc=andy@infradead.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=daniel.gutson@eclypsium.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=hughsient@gmail.com \
--cc=linux-efi@vger.kernel.org \
--cc=luto@kernel.org \
--cc=martin.fernandez@eclypsium.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).