From: Luke Jones <luke@ljones.dev>
To: Hans de Goede <hdegoede@redhat.com>
Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method")
Date: Tue, 16 Aug 2022 18:23:13 +1200 [thread overview]
Message-ID: <14bed619e6a884f37403ec58aead34ff86525f26.camel@ljones.dev> (raw)
In-Reply-To: <657998b3-0f26-9a66-8191-713715622c01@redhat.com>
On Mon, 2022-08-15 at 15:40 +0200, Hans de Goede wrote:
> Hi,
>
> On 8/15/22 15:25, Hans de Goede wrote:
> > Hi Luke,
> >
> > On 8/13/22 00:25, Luke D. Jones wrote:
> > > The dgpu_disable attribute was not documented, this adds the
> > > required documentation.
> > >
> > > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> >
> > Thanks for the patch. Note that the Fixes tag should be above your
> > signed-off-by and then the patch should otherwise have a normal
> > subject + body. I've changed the commit msg to the following
> > while merging this:
> >
> > """
> > platform/x86: asus-wmi: Document the dgpu_disable sysfs attribute
> >
> > The dgpu_disable attribute was not documented, this adds the
> > required documentation.
> >
> > Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method")
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > """
>
> While merging this I noticed that this is also using spaces
> instead of tabs for indentation, where as the rest of
> the file is using tabs.
>
> I've also fixed this up while merging, but next time
> please make sure to use spaces.
>
> I will make similar spaces -> tabs changes to patch 2/6 and 3/6
>
I ran these through ./scripts/checkpatch.pl... I'm really not sure what
happened. I'll triple-check that in future.
> Regards,
>
> Hans
>
>
>
>
> > > ---
> > > Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> > >
> > > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > index 04885738cf15..0f932fd60f4a 100644
> > > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > @@ -57,3 +57,12 @@ Description:
> > > * 0 - default,
> > > * 1 - overboost,
> > > * 2 - silent
> > > +
> > > +What: /sys/devices/platform/<platform>/dgpu_disable
> > > +Date: Aug 2022
> > > +KernelVersion: 5.17
> > > +Contact: "Luke Jones" <luke@ljones.dev>
> > > +Description:
> > > + Disable discrete GPU:
> > > + * 0 - Enable dGPU,
> > > + * 1 - Disable dGPU,
> > > \ No newline at end of file
> >
> > Next time please make sure the file always ends with a newline
> > even in intermediate patches.
> >
> > Regards,
> >
> > Hans
> >
> >
>
next prev parent reply other threads:[~2022-08-16 8:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 22:25 [PATCH 0/6] asus-wmi: cleanup dgpu_disable, egpu_enable, panel_od Luke D. Jones
2022-08-12 22:25 ` [PATCH 1/6] Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method") Luke D. Jones
2022-08-15 13:25 ` Hans de Goede
2022-08-15 13:40 ` Hans de Goede
2022-08-16 6:23 ` Luke Jones [this message]
2022-08-16 6:21 ` Luke Jones
2022-08-12 22:25 ` [PATCH 2/6] Fixes: 382b91db8044 ("asus-wmi: Add egpu enable method") Luke D. Jones
2022-08-12 22:25 ` [PATCH 3/6] Fixes: ca91ea34778f ("asus-wmi: Add panel overdrive functionality") Luke D. Jones
2022-08-12 22:25 ` [PATCH 4/6] asus-wmi: Refactor disable_gpu attribute Luke D. Jones
2022-08-12 22:25 ` [PATCH 5/6] asus-wmi: Refactor egpu_enable attribute Luke D. Jones
2022-08-12 22:25 ` [PATCH 6/6] asus-wmi: Refactor panel_od attribute Luke D. Jones
2022-08-15 15:02 ` [PATCH 0/6] asus-wmi: cleanup dgpu_disable, egpu_enable, panel_od Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14bed619e6a884f37403ec58aead34ff86525f26.camel@ljones.dev \
--to=luke@ljones.dev \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).