Re: [External] Re: [PATCH] Add support for DYTC MMC_GET BIOS API.

[Mark Pearson <markpearson@lenovo.com>]

On 06/04/2021 09:50, Hans de Goede wrote:
> Hi,
> 
> On 4/6/21 4:22 AM, Mark Pearson wrote:
>> The BIOS team have added a new API that allows us to retrieve the 
>> current performance profile without having to disable/enable CQL 
>> mode. Adding the changes to use this API.
>> 
>> Tested on P15 and X1C8
>> 
>> Signed-off-by: Mark Pearson <markpearson@lenovo.com> --- 
>> drivers/platform/x86/thinkpad_acpi.c | 24 ++++++++++++++++++++++-- 
>> 1 file changed, 22 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/platform/x86/thinkpad_acpi.c
>> b/drivers/platform/x86/thinkpad_acpi.c index 0d9e2ddbf..4eb1ad443
>> 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++
>> b/drivers/platform/x86/thinkpad_acpi.c @@ -10050,6 +10050,7 @@
>> static struct ibm_struct proxsensor_driver_data = { */
>> 
<snip>

>> @@ -10271,6 +10280,17 @@ static int tpacpi_dytc_profile_init(struct
>> ibm_init_struct *iibm) if (dytc_version >= 5) { 
>> dbg_printk(TPACPI_DBG_INIT, "DYTC version %d: thermal mode
>> available\n", dytc_version); +		/* +		 * Check if MMC_GET
>> functionality available +		 * Version > 6 and return success from
>> MMC_GET command +		 */ +		dytc_mmc_get_available = false; +		if
>> (dytc_version >= 6) { +			err = dytc_command(DYTC_CMD_MMC_GET,
>> &output); +			if (!err && ((output & DYTC_ERR_MASK) ==
>> DYTC_ERR_SUCCESS)) +				dytc_mmc_get_available = true; +		} +		err
>> = dytc_command(DYTC_CMD_QUERY, &output);
> 
> It seems this last:
> 
> err = dytc_command(DYTC_CMD_QUERY, &output);
> 
> Line snuck in as a copy and paste error? Or is this intentional ?
> 
> If this is intentional, may I ask why this is done / needed ?
> 
Well that's embarrassing - that is left over from some debug I
was running and it shouldn't be there.

I'll submit a new version with that removed.

Apologies - should have caught that one before pushing for review

Mark