From: Luke Jones <luke@ljones.dev>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-kernel@vger.kernel.org, hadess@hadess.net,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3 0/1] asus-wmi: add platform_profile support
Date: Mon, 16 Aug 2021 11:00:01 +1200 [thread overview]
Message-ID: <18LWXQ.AIB2DGCZUVMW@ljones.dev> (raw)
In-Reply-To: <a918bfe0-03c4-e7d3-8a99-efb1d11333e4@redhat.com>
On Sun, Aug 15 2021 at 15:48:49 +0200, Hans de Goede
<hdegoede@redhat.com> wrote:
> Hi,
>
> On 8/14/21 9:51 AM, Luke Jones wrote:
>>
>>
>> On Sat, Aug 14 2021 at 16:31:02 +1200, Luke D. Jones
>> <luke@ljones.dev> wrote:
>>> Changelog:
>>> - V2
>>> + Correctly unregister from platform_profile if
>>> throttle_thermal_policy fails
>>> + Do platform_profile_notify() in both
>>> throttle_thermal_policy_store()
>>> and in throttle_thermal_policy_switch_next()
>>> + Remove unnecessary prep for possible fan-boost modes as this
>>> doesn't match expected platform_profile behaviour
>>> - V3
>>> + Add missing declaration for err in
>>> throttle_thermal_policy_switch_next
>>>
>>> Luke D. Jones (1):
>>> asus-wmi: Add support for platform_profile
>>>
>>> drivers/platform/x86/asus-wmi.c | 139
>>> +++++++++++++++++++++++++++++++-
>>> 1 file changed, 135 insertions(+), 4 deletions(-)
>>>
>>> --
>>> 2.31.1
>>
>> Hi,
>>
>> I teested the patch again and it appears that the
>> platform_profile_notify() in both throttle_thermal_policy_store()
>> and throttle_thermal_policy_switch_next() updates the
>> /sys/firmware/acpi/platform_profile sysfs path fine, but userspace
>> isn't updated?
>>
>> The way I'm checking is:
>> 1. echo 1 |sudo tee
>> /sys/devices/platform/asus-nb-wmi/throttle_thermal_policy
>> 2. cat -p /sys/firmware/acpi/platform_profile
>> - performance (updated correctly by platform_profile_notify)
>> 3. Check gnome-settings, not updated.
>>
>> Doing `echo "performance" |sudo tee
>> /sys/firmware/acpi/platform_profile` updates both
>> throttle_thermal_policy and userspace as expected. I'm wondering if
>> I've missed something?
>
> If you add a printk where you call platform_profile_notify() and you
> see that
> happening, then you are likely seeing a userspace bug. Possibly your
> power-profile-daemon is simply a bit old and therefor does not support
> the combination of profiles which asus-wmi offers, IIRC it falls back
> to
> using intel-pstate in that case.
It's possible that it's a userspace bug then. The power-profile-daemon
I'm using is fresh from git (0.9+). To be clear updating via
/sys/firmware/acpi/platform_profile works perfectly fine and
power-profile-daemon updates etc. But if I do platform_profile_notify()
then it doesn't seem to be updated. Nevertheless I will finalise the
patch as it is and submit for merging and we can go from there.
>
> You could try building the latest power-profile-daemon from git and
> run
> it in verbose mode. If it sees the changes and the control-panel
> applet is
> still not updating then I would not worry about that. The userspace
> code
> is still somewhat new and I'm not sure which version your distro is
> running and how well it is keeping up with gnome-updates.
>
> Regards,
>
> Hans
>
next prev parent reply other threads:[~2021-08-15 23:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 4:31 [PATCH v3 0/1] asus-wmi: add platform_profile support Luke D. Jones
2021-08-14 4:31 ` [PATCH v3 1/1] asus-wmi: Add support for platform_profile Luke D. Jones
2021-08-14 9:40 ` Andy Shevchenko
2021-08-14 11:46 ` Luke Jones
2021-08-14 12:47 ` Luke Jones
2021-08-14 19:51 ` Andy Shevchenko
2021-08-15 13:45 ` Hans de Goede
2021-08-14 19:49 ` Andy Shevchenko
2021-08-14 7:51 ` [PATCH v3 0/1] asus-wmi: add platform_profile support Luke Jones
2021-08-15 13:48 ` Hans de Goede
2021-08-15 14:10 ` Bastien Nocera
2021-08-15 23:00 ` Luke Jones [this message]
2021-08-16 8:09 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18LWXQ.AIB2DGCZUVMW@ljones.dev \
--to=luke@ljones.dev \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).