From: Hans de Goede <hdegoede@redhat.com>
To: Mark Gross <mgross@linux.intel.com>,
Andy Shevchenko <andy@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mario Limonciello <mario.limonciello@dell.com>,
Divya Bharathi <Divya_Bharathi@dell.com>,
Alexander Naumann <alexandernaumann@gmx.de>,
platform-driver-x86@vger.kernel.org
Subject: [PATCH 0/7] platform/x86: dell-wmi-sysman: Various error-handling and robustness fixes
Date: Sat, 20 Mar 2021 15:34:22 +0100 [thread overview]
Message-ID: <20210320143429.76047-1-hdegoede@redhat.com> (raw)
Hi All,
There have been several bug-reports about crashes related to the
dell-wmi-sysman module:
https://bugzilla.redhat.com/show_bug.cgi?id=1936171
https://bugzilla.kernel.org/show_bug.cgi?id=211895
https://bugs.archlinux.org/task/69702
This patch series contains a bunch of fixes for NULL pointer derefs,
double-frees, etc. Which will hopefully fix this.
I don't have any hardware which actually exposes the used interface,
so I've only been able to verify that the driver now cleanly refuses
to load on Dell devices without the interface.
If someone from Dell can test this to ensure that it does not cause
regressions on devices with the interface that would be great.
Regards,
Hans
Hans de Goede (7):
platform/x86: dell-wmi-sysman: Fix possible NULL pointer deref on exit
platform/x86: dell-wmi-sysman: Make it safe to call
exit_foo_attributes() multiple times
platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting
called twice on init_bios_attributes() failure
platform/x86: dell-wmi-sysman: Cleanup sysman_init() error-exit
handling
platform/x86: dell-wmi-sysman: Make sysman_init() return -ENODEV of
the interfaces are not found
platform/x86: dell-wmi-sysman: Make init_bios_attributes() ACPI object
parsing more robust
platform/x86: dell-wmi-sysman: Cleanup
create_attributes_level_sysfs_files()
.../dell/dell-wmi-sysman/enum-attributes.c | 3 +
.../x86/dell/dell-wmi-sysman/int-attributes.c | 3 +
.../dell/dell-wmi-sysman/passobj-attributes.c | 3 +
.../dell/dell-wmi-sysman/string-attributes.c | 3 +
.../x86/dell/dell-wmi-sysman/sysman.c | 117 +++++++++---------
5 files changed, 71 insertions(+), 58 deletions(-)
--
2.30.2
next reply other threads:[~2021-03-20 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 14:34 Hans de Goede [this message]
2021-03-20 14:34 ` [PATCH 1/7] platform/x86: dell-wmi-sysman: Fix possible NULL pointer deref on exit Hans de Goede
2021-03-20 14:34 ` [PATCH 2/7] platform/x86: dell-wmi-sysman: Make it safe to call exit_foo_attributes() multiple times Hans de Goede
2021-03-20 14:34 ` [PATCH 3/7] platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called twice on init_bios_attributes() failure Hans de Goede
2021-03-20 14:34 ` [PATCH 4/7] platform/x86: dell-wmi-sysman: Cleanup sysman_init() error-exit handling Hans de Goede
2021-03-20 14:34 ` [PATCH 5/7] platform/x86: dell-wmi-sysman: Make sysman_init() return -ENODEV of the interfaces are not found Hans de Goede
2021-03-20 14:34 ` [PATCH 6/7] platform/x86: dell-wmi-sysman: Make init_bios_attributes() ACPI object parsing more robust Hans de Goede
2021-03-20 14:34 ` [PATCH 7/7] platform/x86: dell-wmi-sysman: Cleanup create_attributes_level_sysfs_files() Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210320143429.76047-1-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=Divya_Bharathi@dell.com \
--cc=alexandernaumann@gmx.de \
--cc=andy@infradead.org \
--cc=mario.limonciello@dell.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).