From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <aardelean@deviqon.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
coproscefalo@gmail.com, hdegoede@redhat.com,
mgross@linux.intel.com, linux@deviqon.com
Subject: Re: [PATCH 10/10] platform/x86: toshiba_acpi: bind proc entries creation to parent
Date: Mon, 29 Mar 2021 16:10:51 +0100 [thread overview]
Message-ID: <20210329161051.3bc500cf@jic23-huawei> (raw)
In-Reply-To: <20210324125548.45983-11-aardelean@deviqon.com>
On Wed, 24 Mar 2021 14:55:48 +0200
Alexandru Ardelean <aardelean@deviqon.com> wrote:
> This change binds the creation of the proc entries to the parent object,
> via the devm_add_action_or_reset() call.
> This way when the parent object's refcount goes to zero, the proc entries
> are removed in the reverse other in which they were created.
>
> This is the last bit of the toshiba_acpi_remove() function, so in this
> change this function is removed.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
I'm not 100% sure the series is worth the effort, but it does clean up
some of the ordering which definitely looks like a plus point.
Jonathan
> ---
> drivers/platform/x86/toshiba_acpi.c | 45 ++++++++++++++---------------
> 1 file changed, 21 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
> index 8e8917979047..56ee5cd1e90c 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -1671,7 +1671,23 @@ static int __maybe_unused version_proc_show(struct seq_file *m, void *v)
>
> #define PROC_TOSHIBA "toshiba"
>
> -static void create_toshiba_proc_entries(struct toshiba_acpi_dev *dev)
> +static void remove_toshiba_proc_entries(void *data)
> +{
> + struct toshiba_acpi_dev *dev = data;
> +
> + if (dev->backlight_dev)
> + remove_proc_entry("lcd", toshiba_proc_dir);
> + if (dev->video_supported)
> + remove_proc_entry("video", toshiba_proc_dir);
> + if (dev->fan_supported)
> + remove_proc_entry("fan", toshiba_proc_dir);
> + if (dev->hotkey_dev)
> + remove_proc_entry("keys", toshiba_proc_dir);
> + remove_proc_entry("version", toshiba_proc_dir);
> +}
> +
> +static int create_toshiba_proc_entries(struct device *parent,
> + struct toshiba_acpi_dev *dev)
> {
> if (dev->backlight_dev)
> proc_create_data("lcd", S_IRUGO | S_IWUSR, toshiba_proc_dir,
> @@ -1687,19 +1703,8 @@ static void create_toshiba_proc_entries(struct toshiba_acpi_dev *dev)
> &keys_proc_ops, dev);
> proc_create_single_data("version", S_IRUGO, toshiba_proc_dir,
> version_proc_show, dev);
> -}
>
> -static void remove_toshiba_proc_entries(struct toshiba_acpi_dev *dev)
> -{
> - if (dev->backlight_dev)
> - remove_proc_entry("lcd", toshiba_proc_dir);
> - if (dev->video_supported)
> - remove_proc_entry("video", toshiba_proc_dir);
> - if (dev->fan_supported)
> - remove_proc_entry("fan", toshiba_proc_dir);
> - if (dev->hotkey_dev)
> - remove_proc_entry("keys", toshiba_proc_dir);
> - remove_proc_entry("version", toshiba_proc_dir);
> + return devm_add_action_or_reset(parent, remove_toshiba_proc_entries, dev);
> }
>
> static const struct backlight_ops toshiba_backlight_data = {
> @@ -3012,15 +3017,6 @@ static void print_supported_features(struct toshiba_acpi_dev *dev)
> pr_cont("\n");
> }
>
> -static int toshiba_acpi_remove(struct acpi_device *acpi_dev)
> -{
> - struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev);
> -
> - remove_toshiba_proc_entries(dev);
> -
> - return 0;
> -}
> -
> static const char *find_hci_method(acpi_handle handle)
> {
> if (acpi_has_method(handle, "GHCI"))
> @@ -3230,7 +3226,9 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev)
> if (ret)
> return ret;
>
> - create_toshiba_proc_entries(dev);
> + ret = create_toshiba_proc_entries(parent, dev);
> + if (ret)
> + return ret;
>
> toshiba_acpi = dev;
>
> @@ -3340,7 +3338,6 @@ static struct acpi_driver toshiba_acpi_driver = {
> .flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
> .ops = {
> .add = toshiba_acpi_add,
> - .remove = toshiba_acpi_remove,
> .notify = toshiba_acpi_notify,
> },
> .drv.pm = &toshiba_acpi_pm,
next prev parent reply other threads:[~2021-03-29 15:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 12:55 [PATCH 00/10] platform/x86: toshiba_acpi: move acpi add/remove to device-managed routines Alexandru Ardelean
2021-03-24 12:55 ` [PATCH 01/10] platform/x86: toshiba_acpi: bind life-time of toshiba_acpi_dev to parent Alexandru Ardelean
2021-03-29 14:30 ` Jonathan Cameron
2021-03-30 6:49 ` Alexandru Ardelean
2021-03-24 12:55 ` [PATCH 02/10] platform/x86: toshiba_acpi: use devm_add_action_or_reset() for singleton clear Alexandru Ardelean
2021-03-29 14:27 ` Jonathan Cameron
2021-03-24 12:55 ` [PATCH 03/10] platform/x86: toshiba_acpi: bind registration of miscdev object to parent Alexandru Ardelean
2021-03-29 14:33 ` Jonathan Cameron
2021-03-24 12:55 ` [PATCH 04/10] platform/x86: toshiba_acpi: use device-managed functions for input device Alexandru Ardelean
2021-03-29 14:48 ` Jonathan Cameron
2021-03-24 12:55 ` [PATCH 05/10] platform/x86: toshiba_acpi: register backlight with device-managed variant Alexandru Ardelean
2021-03-29 14:50 ` Jonathan Cameron
2021-03-24 12:55 ` [PATCH 06/10] platform/x86: toshiba_acpi: use devm_led_classdev_register() for LEDs Alexandru Ardelean
2021-03-29 14:52 ` Jonathan Cameron
2021-03-24 12:55 ` [PATCH 07/10] platform/x86: toshiba_acpi: use device-managed functions for accelerometer Alexandru Ardelean
2021-03-29 14:54 ` Jonathan Cameron
2021-03-24 12:55 ` [PATCH 08/10] platform/x86: toshiba_acpi: use device-managed for wwan_rfkill management Alexandru Ardelean
2021-03-29 14:57 ` Jonathan Cameron
2021-03-24 12:55 ` [PATCH 09/10] platform/x86: toshiba_acpi: use device-managed for sysfs removal Alexandru Ardelean
2021-03-29 15:09 ` Jonathan Cameron
2021-03-24 12:55 ` [PATCH 10/10] platform/x86: toshiba_acpi: bind proc entries creation to parent Alexandru Ardelean
2021-03-29 15:10 ` Jonathan Cameron [this message]
2021-03-29 12:38 ` [PATCH 00/10] platform/x86: toshiba_acpi: move acpi add/remove to device-managed routines Jonathan Cameron
2021-03-29 14:01 ` Alexandru Ardelean
2021-03-30 8:20 ` Hans de Goede
2021-03-30 9:22 ` Alexandru Ardelean
2021-03-30 9:27 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329161051.3bc500cf@jic23-huawei \
--to=jic23@kernel.org \
--cc=aardelean@deviqon.com \
--cc=coproscefalo@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@deviqon.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).