From: Mark Brown <broonie@kernel.org>
To: Perry Yuan <Perry.Yuan@dell.com>
Cc: pobrn@protonmail.com, pierre-louis.bossart@linux.intel.com,
oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com,
hdegoede@redhat.com, mgross@linux.intel.com,
Mario.Limonciello@dell.com, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
mario.limonciello@outlook.com, Dell.Client.Kernel@dell.com
Subject: Re: [PATCH v6 2/2] ASoC: rt715:add micmute led state control supports
Date: Wed, 7 Apr 2021 16:15:34 +0100 [thread overview]
Message-ID: <20210407151534.GE5510@sirena.org.uk> (raw)
In-Reply-To: <20210404083159.1620-1-Perry_Yuan@Dell.com>
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
On Sun, Apr 04, 2021 at 04:31:59PM +0800, Perry Yuan wrote:
> +static bool micmute_led_set;
> +static int dmi_matched(const struct dmi_system_id *dmi)
> +{
> + micmute_led_set = 1;
> + return 1;
> +}
This isn't how we usually record DMI quirks, usually we'd query once on
probe and store the data in the driver data struct - see other users for
examples.
> @@ -358,6 +388,7 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol,
> unsigned int mask = (1 << fls(max)) - 1;
> + dmi_check_system(micmute_led_dmi_table);
> + if (invert && micmute_led_set) {
This check for invert is odd and could probably use a comment.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-07 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-04 8:31 [PATCH v6 2/2] ASoC: rt715:add micmute led state control supports Perry Yuan
2021-04-07 15:15 ` Mark Brown [this message]
2021-04-12 9:30 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407151534.GE5510@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@outlook.com \
--cc=mgross@linux.intel.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).