From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B667BC433B4 for ; Sat, 10 Apr 2021 04:13:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C6A9611AE for ; Sat, 10 Apr 2021 04:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233707AbhDJENM (ORCPT ); Sat, 10 Apr 2021 00:13:12 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:17302 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbhDJENM (ORCPT ); Sat, 10 Apr 2021 00:13:12 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FHM431h0Lz9xVG; Sat, 10 Apr 2021 12:10:43 +0800 (CST) Received: from DESKTOP-EFRLNPK.china.huawei.com (10.174.176.196) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Sat, 10 Apr 2021 12:12:49 +0800 From: Qiheng Lin To: , Maximilian Luz , Sebastian Reichel CC: , , , Hulk Robot Subject: [PATCH -next] power: supply: Make symbol 'surface_ac_pm_ops' static Date: Sat, 10 Apr 2021 12:12:49 +0800 Message-ID: <20210410041249.12846-1-linqiheng@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.196] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org The sparse tool complains as follows: drivers/power/supply/surface_charger.c:229:1: warning: symbol 'surface_ac_pm_ops' was not declared. Should it be static? This symbol is not used outside of surface_charger.c, so this commit marks it static. Reported-by: Hulk Robot Signed-off-by: Qiheng Lin --- drivers/power/supply/surface_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c index c2dd7e604d14..81a5b79822c9 100644 --- a/drivers/power/supply/surface_charger.c +++ b/drivers/power/supply/surface_charger.c @@ -226,7 +226,7 @@ static int __maybe_unused surface_ac_resume(struct device *dev) { return spwr_ac_recheck(dev_get_drvdata(dev)); } -SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume); +static SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume); static int surface_ac_probe(struct ssam_device *sdev) {