From: Imre Deak <imre.deak@intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification
Date: Tue, 4 May 2021 15:53:35 +0300 [thread overview]
Message-ID: <20210504125335.GA30246@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <YI+tlE35i+6F/WUO@kuha.fi.intel.com>
On Mon, May 03, 2021 at 11:00:20AM +0300, Heikki Krogerus wrote:
> Hi Hans,
>
> On Wed, Apr 28, 2021 at 11:52:52PM +0200, Hans de Goede wrote:
> > +/**
> > + * struct drm_connector_oob_hotplug_event_data: OOB hotplug event data
> > + *
> > + * Contains data about out-of-band hotplug events, signalled through
> > + * drm_connector_oob_hotplug_event().
> > + */
> > +struct drm_connector_oob_hotplug_event_data {
> > + /**
> > + * @connected: New connected status for the connector.
> > + */
> > + bool connected;
> > + /**
> > + * @dp_lanes: Number of available displayport lanes, 0 if unknown.
> > + */
> > + int dp_lanes;
> > + /**
> > + * @orientation: Connector orientation.
> > + */
> > + enum typec_orientation orientation;
> > +};
>
> I don't think the orientation is relevant. It will always be "normal"
> from DP PoW after muxing, no?
>
> I'm also not sure those deatils are enough in the long run. Based on
> what I've understood from our graphics team guys, for example knowing
> if multi-function is preferred may be important in some cases.
Combo PHY ports - which is what this patchset is adding the notification
for - can only reverse the lane assignment. TypeC PHY ports (on ICL+)
have a more C-type aware mux in the SoC (FIA) as well, so in theory we
could have a system based on such platforms with an external mux only
switching between the USB, DP, USB+DP (MFD) modes, but leaving the plug
orientation specific muxing up to the FIA. The graphics driver is not
involved in programming the FIA though, it's done by a firmware
component, so I don't think this configuration needs to get passed.
Yes, the driver needs to know if the PD controller configured the sink
in the MFD mode (DP+USB) or in the DP-only mode. For that the number of
lanes assigned to DP is enough.
> +Imre.
>
> All of that, and more, is already available in the Configuration VDO
> Status VDO that the we have negotiated with the DP partner. Both those
> VDOs are part of struct typec_displayport_data. I think we should
> simply supply that structure to the DRM code instead of picking those
> details out of it...
>
> > /**
> > * struct drm_tv_connector_state - TV connector related states
> > * @subconnector: selected subconnector
> > @@ -1110,6 +1132,15 @@ struct drm_connector_funcs {
> > */
> > void (*atomic_print_state)(struct drm_printer *p,
> > const struct drm_connector_state *state);
> > +
> > + /**
> > + * @oob_hotplug_event:
> > + *
> > + * This will get called when a hotplug-event for a drm-connector
> > + * has been received from a source outside the display driver / device.
> > + */
> > + void (*oob_hotplug_event)(struct drm_connector *connector,
> > + struct drm_connector_oob_hotplug_event_data *data);
>
> So I would not try to generalise this like that. This callback should
> be USB Type-C DP altmode specific:
>
> void (*oob_hotplug_event)(struct drm_connector *connector,
> struct typec_displayport_data *data);
>
> Or like this if the orientation can really be reversed after muxing:
>
> void (*oob_hotplug_event)(struct drm_connector *connector,
> struct typec_altmode *altmode,
> struct typec_displayport_data *data);
>
> You can now check the orientation separately with
> typec_altmode_get_orientation() if necessary.
>
>
> thanks,
>
> --
> heikki
next prev parent reply other threads:[~2021-05-04 12:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 21:52 [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification Hans de Goede
2021-04-28 21:52 ` [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector Hans de Goede
2021-04-29 11:40 ` Daniel Vetter
2021-04-29 11:54 ` Greg Kroah-Hartman
2021-04-29 12:04 ` Daniel Vetter
2021-04-29 12:33 ` Hans de Goede
2021-04-29 19:09 ` Daniel Vetter
2021-04-30 11:28 ` Hans de Goede
2021-04-30 11:38 ` Daniel Vetter
2021-04-30 13:32 ` Hans de Goede
2021-04-30 14:30 ` Daniel Vetter
2021-04-30 13:45 ` Hans de Goede
2021-04-29 12:30 ` Hans de Goede
2021-04-28 21:52 ` [PATCH 2/9] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI Hans de Goede
2021-04-28 21:52 ` [PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function Hans de Goede
2021-04-28 21:52 ` [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification Hans de Goede
2021-05-03 8:00 ` Heikki Krogerus
2021-05-03 14:35 ` Hans de Goede
2021-05-04 14:52 ` Heikki Krogerus
2021-05-04 15:34 ` Hans de Goede
2021-05-04 12:53 ` Imre Deak [this message]
2021-04-28 21:52 ` [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries Hans de Goede
2021-04-28 21:52 ` [PATCH 6/9] drm/i915/dp: Add support for out-of-bound hotplug events Hans de Goede
2021-04-28 21:52 ` [PATCH 7/9] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic Hans de Goede
2021-04-28 21:52 ` [PATCH 8/9] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events Hans de Goede
2021-04-28 21:52 ` [PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference Hans de Goede
2021-04-28 21:57 ` [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504125335.GA30246@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).