platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/9] Kconfig symbol clean-up on ./arch/x86/
@ 2021-08-03 11:35 Lukas Bulwahn
  2021-08-03 11:35 ` [PATCH 1/9] x86/entry: correct reference to intended CONFIG_64_BIT Lukas Bulwahn
                   ` (10 more replies)
  0 siblings, 11 replies; 17+ messages in thread
From: Lukas Bulwahn @ 2021-08-03 11:35 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86, Randy Dunlap
  Cc: H . Peter Anvin, Darren Hart, Andy Shevchenko, Lubomir Rintel,
	Pavel Machek, Lee Jones, Rafael J . Wysocki, Mika Westerberg,
	Linus Walleij, platform-driver-x86, kernel-janitors,
	linux-kernel, Lukas Bulwahn

Dear x86 maintainers,


Randy Dunlap pointed out that ./scripts/checkkconfigsymbols.py warns on
invalid references to Kconfig symbols (often, minor typos, name confusions
or outdated references): see Link below.

This is a first patch series addressing the issues reported by
./scripts/checkkconfigsymbols.py in the ./arch/x86/ directories, quickly
filtered down with:

  ./scripts/checkkconfigsymbols.py | grep "arch/x86" -B 1 -A 2

It addresses some issues I considered to be "true positives";
so, issues that should be addressed and cleaned up.

The patches on updating the comments might arguably be considered of low
value by itself, but as the other patches show, checkkconfigsymbols does
detect some relevant issues in the kernel tree otherwise being unnoticed.
So, it might be worth to clean up the kernel tree to have checkkconfigsymbols
produce a rather short list of issues and then continuously follow and check
what checkkconfigsymbols reports.

Some work from checkkconfigsymbols on arch/x86 is deferred:

  - OSNOISE_TRAECR typo in arch/x86/kernel/trace.c
    This will added to a separate janitor cleanup series with other topics
    on this file.

  - a reference to STRICT_IOMEM in arch/x86/mm/init.c
    unclear to me: which exact config this refers to

  - Given some updates of the minimal version for binutils (now >= 2.23),
    the whole special detection of binutils support for CONFIG_X86_X32 and
    its speciality with CONFIG_X86_X32_ABI might be unneeded. I might look
    into that in a separate task.

The remaining issues that checkkconfigsymbols reports are (as far as I
understand it now) "false positives" (the tool misinterprets the actual
content) or "intentional", e.g., they refer to historic configs for the
purpose of documentation (e.g., in changelogs) or are in various kernel
configs that are not continuously updated to match the current set of
kernel configs.

Please pick this series of minor clean-up patches on ./arch/x86/.

It applies cleanly on next-20210802.

Link: https://lore.kernel.org/linux-kernel-mentees/295b8f8c-4264-9f32-6723-9d2d574021ac@infradead.org/


Best regards,

Lukas


Lukas Bulwahn (9):
  x86/entry: correct reference to intended CONFIG_64_BIT
  x86, olpc: correct condition to intended CONFIG_OLPC_XO15_SCI
  x86/Kconfig: correct reference to MWINCHIP3D
  x86/Kconfig: remove reference to obsolete MFD_INTEL_MSIC config
  x86/Kconfig: remove reference to obsolete APB_TIMER config
  x86/irq: fix slightly wrong reference in comment
  x86/uaccess: adjust comment for endif of CONFIG_CC_HAS_ASM_GOTO_OUTPUT
  x86: page_32.h: adjust comment for endif of CONFIG_X86_USE_3DNOW
  x86: ia32.h: adjust comment for endif of CONFIG_IA32_EMULATION

 arch/x86/Kconfig                    | 4 +---
 arch/x86/include/asm/entry-common.h | 2 +-
 arch/x86/include/asm/ia32.h         | 2 +-
 arch/x86/include/asm/irq_stack.h    | 2 +-
 arch/x86/include/asm/page_32.h      | 2 +-
 arch/x86/include/asm/uaccess.h      | 2 +-
 arch/x86/platform/olpc/olpc.c       | 2 +-
 7 files changed, 7 insertions(+), 9 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2021-12-22 13:00 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03 11:35 [PATCH 0/9] Kconfig symbol clean-up on ./arch/x86/ Lukas Bulwahn
2021-08-03 11:35 ` [PATCH 1/9] x86/entry: correct reference to intended CONFIG_64_BIT Lukas Bulwahn
2021-08-03 11:35 ` [PATCH 2/9] x86, olpc: correct condition to intended CONFIG_OLPC_XO15_SCI Lukas Bulwahn
2021-08-03 11:35 ` [PATCH 3/9] x86/Kconfig: correct reference to MWINCHIP3D Lukas Bulwahn
2021-08-03 11:35 ` [PATCH 4/9] x86/Kconfig: remove reference to obsolete MFD_INTEL_MSIC config Lukas Bulwahn
2021-08-03 11:35 ` [PATCH 5/9] x86/Kconfig: remove reference to obsolete APB_TIMER config Lukas Bulwahn
2021-10-05 19:57   ` Borislav Petkov
2021-08-03 11:35 ` [PATCH 6/9] x86/irq: fix slightly wrong reference in comment Lukas Bulwahn
2021-08-03 11:35 ` [PATCH 7/9] x86/uaccess: adjust comment for endif of CONFIG_CC_HAS_ASM_GOTO_OUTPUT Lukas Bulwahn
2021-08-03 11:35 ` [PATCH 8/9] x86: page_32.h: adjust comment for endif of CONFIG_X86_USE_3DNOW Lukas Bulwahn
2021-08-03 11:35 ` [PATCH 9/9] x86: ia32.h: adjust comment for endif of CONFIG_IA32_EMULATION Lukas Bulwahn
2021-10-05 19:59   ` Borislav Petkov
2021-08-03 14:32 ` [PATCH 0/9] Kconfig symbol clean-up on ./arch/x86/ Dave Hansen
2021-08-03 15:12   ` Lukas Bulwahn
2021-08-03 15:40     ` Dave Hansen
2021-12-22 13:00       ` Lukas Bulwahn
2021-08-03 21:49 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).