Re: [PATCH v5] platform/x86: acer-wmi: Add Turbo Mode support for Acer PH315-53

From: kernel test robot <lkp@intel.com>
To: JafarAkhondali <jafar.akhoondali@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	jlee@suse.com, linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, mgross@linux.intel.com
Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
	JafarAkhondali <jafar.akhoondali@gmail.com>
Subject: Re: [PATCH v5] platform/x86: acer-wmi: Add Turbo Mode support for Acer PH315-53
Date: Fri, 13 Aug 2021 01:57:57 +0800	[thread overview]
Message-ID: <202108130159.FOdNZJfX-lkp@intel.com> (raw)
In-Reply-To: <20210812125307.1749207-1-jafar.akhoondali@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3095 bytes --]

Hi JafarAkhondali,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.14-rc5 next-20210812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/JafarAkhondali/platform-x86-acer-wmi-Add-Turbo-Mode-support-for-Acer-PH315-53/20210812-212347
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1746f4db513563bb22e0ba0c419d0c90912dfae1
config: x86_64-randconfig-a011-20210812 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 767496d19cb9a1fbba57ff08095faa161998ee36)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/292cfa3c9af2eb61b782c6d94d08d35300318ca3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review JafarAkhondali/platform-x86-acer-wmi-Add-Turbo-Mode-support-for-Acer-PH315-53/20210812-212347
        git checkout 292cfa3c9af2eb61b782c6d94d08d35300318ca3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/platform/x86/acer-wmi.c:1466:6: warning: no previous prototype for function 'WMID_gaming_set_fan_mode' [-Wmissing-prototypes]
   void WMID_gaming_set_fan_mode(u8 fan_mode)
        ^
   drivers/platform/x86/acer-wmi.c:1466:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void WMID_gaming_set_fan_mode(u8 fan_mode)
   ^
   static 
   1 warning generated.

vim +/WMID_gaming_set_fan_mode +1466 drivers/platform/x86/acer-wmi.c

  1465	
> 1466	void WMID_gaming_set_fan_mode(u8 fan_mode)
  1467	{
  1468		/* fan_mode = 1 is used for auto, fan_mode = 2 used for turbo*/
  1469		u64 gpu_fan_config1 = 0, gpu_fan_config2 = 0;
  1470		int i;
  1471	
  1472		if (quirks->cpu_fans > 0)
  1473			gpu_fan_config2 |= 1;
  1474		for (i = 0; i < (quirks->cpu_fans + quirks->gpu_fans); ++i)
  1475			gpu_fan_config2 |= 1 << (i + 1);
  1476		for (i = 0; i < quirks->gpu_fans; ++i)
  1477			gpu_fan_config2 |= 1 << (i + 3);
  1478		if (quirks->cpu_fans > 0)
  1479			gpu_fan_config1 |= fan_mode;
  1480		for (i = 0; i < (quirks->cpu_fans + quirks->gpu_fans); ++i)
  1481			gpu_fan_config1 |= fan_mode << (2 * i + 2);
  1482		for (i = 0; i < quirks->gpu_fans; ++i)
  1483			gpu_fan_config1 |= fan_mode << (2 * i + 6);
  1484		WMID_gaming_set_u64(gpu_fan_config2 | gpu_fan_config1 << 16, ACER_CAP_TURBO_FAN);
  1485	}
  1486	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41114 bytes --]