From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Nicolò Piazzalunga" <nicolopiazzalunga@gmail.com>,
linux-pm@vger.kernel.org,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"Thomas Koch" <linrunner@gmx.net>,
"smclt30p@gmail.com" <smclt30p@gmail.com>
Subject: Re: [RFC] add standardized attributes for force_discharge and inhibit_charge
Date: Wed, 6 Oct 2021 16:39:37 +0200 [thread overview]
Message-ID: <20211006143937.llr2ggbkqwhecxk3@earth.universe> (raw)
In-Reply-To: <8cbf7671-d9ee-6bfc-d8fd-d360ccb2c595@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]
Hi Hans,
On Wed, Oct 06, 2021 at 10:10:36AM +0200, Hans de Goede wrote:
> On 10/6/21 12:06 AM, Sebastian Reichel wrote:
> > On Tue, Oct 05, 2021 at 08:01:12PM +0200, Hans de Goede wrote:
> >> Right, force-discharge automatically implies charging is
> >> being inhibited, so putting this in one file makes sense.
> >>
> >> Any suggestion for the name of the file?
> >
> > Maybe like this?
> >
> > ---------------------------------------------------------------------
> > What: /sys/class/power_supply/<supply_name>/charge_behaviour
> > Date: October 2021
> > Contact: linux-pm@vger.kernel.org
> > Description:
> > Configure battery behaviour when a charger is being connected.
> >
> > Access: Read, Write
> >
> > Valid values:
> >
> > 0: auto / no override
> > When charger is connected battery should be charged
> > 1: force idle
> > When charger is connected the battery should neither be charged
> > nor discharged.
> > 2: force discharge
> > When charger is connected the battery should be discharged
> > anyways.
> > ---------------------------------------------------------------------
>
> That looks good to me. Although I just realized that some hw may
> only support 1. or 2. maybe explicitly document this and that
> EOPNOTSUPP will be reported when the value is not supported
> (vs EINVAL for plain invalid values)?
Sounds good to me.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-10-06 14:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 20:11 [RFC] add standardized attributes for force_discharge and inhibit_charge Nicolò Piazzalunga
2021-09-29 9:38 ` Hans de Goede
2021-10-05 16:23 ` Sebastian Reichel
2021-10-05 18:01 ` Hans de Goede
2021-10-05 22:06 ` Sebastian Reichel
2021-10-06 8:10 ` Hans de Goede
2021-10-06 14:39 ` Sebastian Reichel [this message]
2021-10-06 14:49 ` Thomas Weißschuh
2021-10-06 15:27 ` Hans de Goede
2021-10-06 16:28 ` Sebastian Reichel
2021-10-06 17:47 ` Hans de Goede
2021-10-06 19:24 ` Thomas Koch
2021-10-06 21:39 ` Thomas Weißschuh
2021-10-07 5:56 ` Thomas Koch
2021-10-07 11:28 ` Sebastian Reichel
2021-09-29 16:22 ` Nicolò Piazzalunga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006143937.llr2ggbkqwhecxk3@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=hdegoede@redhat.com \
--cc=linrunner@gmx.net \
--cc=linux-pm@vger.kernel.org \
--cc=nicolopiazzalunga@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=smclt30p@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).