platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Mark Gross <markgross@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 2/7] platform/x86: serial-multi-instantiate: Improve autodetection
Date: Sat,  9 Jul 2022 03:06:31 +0300	[thread overview]
Message-ID: <20220709000636.35550-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20220709000636.35550-1-andriy.shevchenko@linux.intel.com>

Instead of calling specific resource counter, let just probe each
of the type and see what it says. Also add a debug message when
none is found.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/platform/x86/serial-multi-instantiate.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/platform/x86/serial-multi-instantiate.c
index 97db23243018..e599058196bb 100644
--- a/drivers/platform/x86/serial-multi-instantiate.c
+++ b/drivers/platform/x86/serial-multi-instantiate.c
@@ -232,6 +232,7 @@ static int smi_probe(struct platform_device *pdev)
 	const struct smi_node *node;
 	struct acpi_device *adev;
 	struct smi *smi;
+	int ret;
 
 	adev = ACPI_COMPANION(dev);
 	if (!adev)
@@ -255,15 +256,20 @@ static int smi_probe(struct platform_device *pdev)
 	case SMI_SPI:
 		return smi_spi_probe(pdev, adev, smi, node->instances);
 	case SMI_AUTO_DETECT:
-		if (i2c_acpi_client_count(adev) > 0)
-			return smi_i2c_probe(pdev, adev, smi, node->instances);
-		else
-			return smi_spi_probe(pdev, adev, smi, node->instances);
+		ret = smi_i2c_probe(pdev, adev, smi, node->instances);
+		if (ret && ret != -ENOENT)
+			return ret;
+		ret = smi_spi_probe(pdev, adev, smi, node->instances);
+		if (ret && ret != -ENOENT)
+			return ret;
+		if (ret)
+			return dev_err_probe(dev, ret, "Error No resources found\n");
+		break;
 	default:
 		return -EINVAL;
 	}
 
-	return 0; /* never reached */
+	return 0;
 }
 
 static int smi_remove(struct platform_device *pdev)
-- 
2.35.1


  reply	other threads:[~2022-07-09  0:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-09  0:06 [PATCH v1 1/7] platform/x86: serial-multi-instantiate: return -ENOENT when no resources found Andy Shevchenko
2022-07-09  0:06 ` Andy Shevchenko [this message]
2022-07-09  9:47   ` [PATCH v1 2/7] platform/x86: serial-multi-instantiate: Improve autodetection Hans de Goede
     [not found]     ` <CAHp75VfVoTcZD7vXxXckxu-crsXr7m4bx8F9D9cs2TtBbyeYqQ@mail.gmail.com>
2022-07-09 11:00       ` Hans de Goede
2022-07-09 11:34         ` Andy Shevchenko
2022-07-09 14:46           ` Hans de Goede
2022-07-09  9:48   ` Hans de Goede
2022-07-09  0:06 ` [PATCH v1 3/7] platform/x86: serial-multi-instantiate: Drop duplicate check Andy Shevchenko
2022-07-09  9:50   ` Hans de Goede
2022-07-09  0:06 ` [PATCH v1 4/7] platform/x86: serial-multi-instantiate: Improve dev_err_probe() messaging Andy Shevchenko
2022-07-09  0:06 ` [PATCH v1 5/7] platform/x86: serial-multi-instantiate: Use while (i--) pattern to clean up Andy Shevchenko
2022-07-09  0:06 ` [PATCH v1 6/7] platform/x86: serial-multi-instantiate: Get rid of redundant 'else' Andy Shevchenko
2022-07-09  0:06 ` [PATCH v1 7/7] platform/x86: serial-multi-instantiate: Sort ACPI IDs by HID Andy Shevchenko
2022-07-09  9:45 ` [PATCH v1 1/7] platform/x86: serial-multi-instantiate: return -ENOENT when no resources found Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220709000636.35550-2-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).