From: Grzegorz Jaszczyk <jaz@semihalf.com>
To: linux-kernel@vger.kernel.org, rafael@kernel.org
Cc: dmy@semihalf.com, tn@semihalf.com, dbehr@google.com,
zide.chen@intel.corp-partner.google.com, seanjc@google.com,
upstream@semihalf.com, hdegoede@redhat.com, markgross@kernel.org,
dtor@google.com, mario.limonciello@amd.com,
linux-pm@vger.kernel.org, x86@kernel.org,
platform-driver-x86@vger.kernel.org,
Grzegorz Jaszczyk <jaz@semihalf.com>
Subject: [RFCv3 1/1] platform/x86: Add virtual PMC driver used for S2Idle
Date: Mon, 13 Feb 2023 10:09:21 +0000 [thread overview]
Message-ID: <20230213100921.268770-2-jaz@semihalf.com> (raw)
In-Reply-To: <20230213100921.268770-1-jaz@semihalf.com>
Virtual PMC driver is meant for the guest VMs for the S2Idle
notification. Its purpose is to register S2Idle dev ops check handler,
which will evaluate ACPI _DSM just before the guest enters S2Idle power
state.
This allows to trap on MMIO access done as a consequence of _DSM
evaluation and therefore notify the VMM about the guest entering S2Idle
state.
Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
Changelog v1..v2:
- Take advantage of acpi_s2idle_dev_ops's check() instead of notify()
Changelog v2..v3:
- Add MODULE_LICENSE
- Remove "amd" prefixes
- Be more verbose in VIRT_PMC config description and make it
HYPERVISOR_GUEST dependent
- Add extra check ensuring that DSM method supports ACPI_VIRT_PMC_NOTIFY function
---
drivers/platform/x86/Kconfig | 7 +++
drivers/platform/x86/Makefile | 3 ++
drivers/platform/x86/virt_pmc.c | 83 +++++++++++++++++++++++++++++++++
3 files changed, 93 insertions(+)
create mode 100644 drivers/platform/x86/virt_pmc.c
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 5692385e2d26..837ce201b68b 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1099,6 +1099,13 @@ config WINMATE_FM07_KEYS
buttons below the display. This module adds an input device
that delivers key events when these buttons are pressed.
+config VIRT_PMC
+ tristate "Virtual Power Management Controller"
+ depends on ACPI && SUSPEND && HYPERVISOR_GUEST
+ help
+ The Virtual PMC driver is meant for the guest VMs and its main
+ purpose is to notify about guest entering s2idle state.
+
endif # X86_PLATFORM_DEVICES
config P2SB
diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
index 1d3d1b02541b..c4d3056cf4ea 100644
--- a/drivers/platform/x86/Makefile
+++ b/drivers/platform/x86/Makefile
@@ -129,6 +129,9 @@ obj-$(CONFIG_INTEL_SCU_WDT) += intel_scu_wdt.o
obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += intel_scu_ipcutil.o
obj-$(CONFIG_X86_INTEL_LPSS) += pmc_atom.o
+# Virtual PMC
+obj-$(CONFIG_VIRT_PMC) += virt_pmc.o
+
# Siemens Simatic Industrial PCs
obj-$(CONFIG_SIEMENS_SIMATIC_IPC) += simatic-ipc.o
diff --git a/drivers/platform/x86/virt_pmc.c b/drivers/platform/x86/virt_pmc.c
new file mode 100644
index 000000000000..a5966bb9048f
--- /dev/null
+++ b/drivers/platform/x86/virt_pmc.c
@@ -0,0 +1,83 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Virtual Power Management Controller Driver
+ *
+ * Author: Grzegorz Jaszczyk <jaz@semihalf.com>
+ */
+
+#include <linux/acpi.h>
+#include <linux/platform_device.h>
+
+#define ACPI_VIRT_PMC_DSM_UUID "9ea49ba3-434a-49a6-be30-37cc55c4d397"
+#define ACPI_VIRT_PMC_NOTIFY 1
+
+static acpi_handle virt_pmc_handle;
+
+static void virt_pmc_s2idle_notify(void)
+{
+ union acpi_object *out_obj;
+ guid_t dsm_guid;
+
+ guid_parse(ACPI_VIRT_PMC_DSM_UUID, &dsm_guid);
+
+ out_obj = acpi_evaluate_dsm(virt_pmc_handle, &dsm_guid,
+ 0, ACPI_VIRT_PMC_NOTIFY, NULL);
+
+ acpi_handle_debug(virt_pmc_handle, "_DSM function %u evaluation %s\n",
+ ACPI_VIRT_PMC_NOTIFY, out_obj ? "successful" : "failed");
+
+ ACPI_FREE(out_obj);
+}
+
+static struct acpi_s2idle_dev_ops pmc_s2idle_dev_ops = {
+ .check = virt_pmc_s2idle_notify,
+};
+
+static int virt_pmc_probe(struct platform_device *pdev)
+{
+ int err = 0;
+ guid_t dsm_guid;
+
+ virt_pmc_handle = ACPI_HANDLE(&pdev->dev);
+
+ guid_parse(ACPI_VIRT_PMC_DSM_UUID, &dsm_guid);
+
+ if (!acpi_check_dsm(virt_pmc_handle, &dsm_guid, 0,
+ 1 << ACPI_VIRT_PMC_NOTIFY)) {
+ dev_err(&pdev->dev, "DSM method doesn't support ACPI_VIRT_PMC_NOTIFY\n");
+ return -ENODEV;
+ }
+
+ err = acpi_register_lps0_dev(&pmc_s2idle_dev_ops);
+ if (err)
+ dev_err(&pdev->dev, "failed to register LPS0 sleep handler\n");
+
+ return err;
+}
+
+static int virt_pmc_remove(struct platform_device *pdev)
+{
+ acpi_unregister_lps0_dev(&pmc_s2idle_dev_ops);
+
+ return 0;
+}
+
+static const struct acpi_device_id virt_pmc_acpi_ids[] = {
+ {"HYPE0001", 0}, /* _HID for XXX Power Engine, _CID PNP0D80*/
+ { }
+};
+MODULE_DEVICE_TABLE(acpi, virt_pmc_acpi_ids);
+
+static struct platform_driver virt_pmc_driver = {
+ .driver = {
+ .name = "virtual_pmc",
+ .acpi_match_table = ACPI_PTR(virt_pmc_acpi_ids),
+ },
+ .probe = virt_pmc_probe,
+ .remove = virt_pmc_remove,
+};
+
+module_platform_driver(virt_pmc_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Virtual PMC Driver");
--
2.39.1.581.gbfd45094c4-goog
next prev parent reply other threads:[~2023-02-13 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 10:09 [RFCv3 0/1] x86: allow to notify host about guest entering s2idle Grzegorz Jaszczyk
2023-02-13 10:09 ` Grzegorz Jaszczyk [this message]
2023-03-29 12:33 ` [RFCv3 1/1] platform/x86: Add virtual PMC driver used for S2Idle Grzegorz Jaszczyk
2023-04-06 10:53 ` Hans de Goede
2023-04-06 13:59 ` Grzegorz Jaszczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213100921.268770-2-jaz@semihalf.com \
--to=jaz@semihalf.com \
--cc=dbehr@google.com \
--cc=dmy@semihalf.com \
--cc=dtor@google.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=seanjc@google.com \
--cc=tn@semihalf.com \
--cc=upstream@semihalf.com \
--cc=x86@kernel.org \
--cc=zide.chen@intel.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).