From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301BDC4338F for ; Wed, 18 Aug 2021 07:51:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14F3A6108E for ; Wed, 18 Aug 2021 07:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239131AbhHRHwZ (ORCPT ); Wed, 18 Aug 2021 03:52:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41779 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239115AbhHRHwY (ORCPT ); Wed, 18 Aug 2021 03:52:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629273110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PsxIbByc4MeeA9mh65w0Ji9CgAEac75Emzhzuys71nU=; b=EGr+bKQ3gMnODMk3faMARyrz27tfcuhW42G5W7KKa9SkOqlXoy/w8//avTX/2Y82rwWtH/ p1nvQfq0IajaTtPcYYTZBXF/eBaQGBCc3aflOQksv1EtY5p2kB//W07dk/NCSQbZswIOH8 cdVfRjIybUTdQYBw1TlM0AnsRFnxi14= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-561-0LPopINENFqQ_TDogjBbgw-1; Wed, 18 Aug 2021 03:51:49 -0400 X-MC-Unique: 0LPopINENFqQ_TDogjBbgw-1 Received: by mail-ed1-f69.google.com with SMTP id v20-20020aa7d9d40000b02903be68450bf3so594189eds.23 for ; Wed, 18 Aug 2021 00:51:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PsxIbByc4MeeA9mh65w0Ji9CgAEac75Emzhzuys71nU=; b=m/rCenwzwhmcYpkE5jJbHtut4c+3lLljGnS7wYDjd/xrZUsJl9qAGmAJVO7OYfUTOA x4hfZVgwQjnriIu/pqohNNhYMkVi2hfDQqpUcUU12lpT2TutTxvLHYSM6/61QmNzpKgN 1G4FpR532O4xJmTWug+V64f39n+zytyPMPdljnjYJZrloMYewJgWF3il8v9XMy3Kporb cF8PfMS9KdVQ/Kk3UCJAbnpLFRxcjvc7CfpsP396wvrXq6EMzWWdpf5i6ts31nZLcshw 2pWBrxA35KThoWNvU5VMLvT4rX1v2kh8cobWwyDPOJQbiRv8/s6lwSPzo6L0UpUNbfNQ zCvg== X-Gm-Message-State: AOAM532SxiG13fafiQ1ce7+E2LXHxwTWWig82bKsTopHhT9UAPHDRIdn NC6HSRXAdeVdImmML2VCAya24zJXqAMHb4K7TxKRa/1kqyXiVaNUwdzGFSpLTlACYz3X8Vl7XUl NETIqy5JqlR9VSdHPuqlm1crCUuebkbZciw== X-Received: by 2002:a50:d68e:: with SMTP id r14mr8766737edi.136.1629273106578; Wed, 18 Aug 2021 00:51:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzq4bdN4/sZhvMzrI99gJ/UuBSRKuLfjrHyCXV6VEehTVciR93QOuMDBXhi00XCU33E70OJwA== X-Received: by 2002:a50:d68e:: with SMTP id r14mr8766723edi.136.1629273106446; Wed, 18 Aug 2021 00:51:46 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id be23sm2154520edb.68.2021.08.18.00.51.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 00:51:46 -0700 (PDT) Subject: Re: [PATCH v2 0/5] MFD: intel_pmt: Add general DVSEC/VSEC support To: "David E. Box" , lee.jones@linaro.org, mgross@linux.intel.com, bhelgaas@google.com, srinivas.pandruvada@intel.com, andy.shevchenko@gmail.com Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org References: <20210817224018.1013192-1-david.e.box@linux.intel.com> From: Hans de Goede Message-ID: <21f59d91-c9b9-2a7e-e5d9-a7697979b4bf@redhat.com> Date: Wed, 18 Aug 2021 09:51:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210817224018.1013192-1-david.e.box@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 8/18/21 12:40 AM, David E. Box wrote: > This patch enables general support for Intel defined PCIe VSEC and DVSEC > capabilities in the Intel Platform Monitoring Technology (PMT) driver. > Though the driver was written exclusively for PMT capabilities, newer DVSEC > and VSEC IDs for other capabilities can exist on the same device requiring > that the driver handle them. > > This 2nd revision drops the creation of a separate OOBMSM driver. Instead, > all cell drivers will have a dependency on CONFIG_MFD_INTEL_PMT, whether or > not they are PMT. Changes in this patchset to the current cell drivers > located in platform/x86 are based on Hans for-next branch where they have > been moved to the intel/pmt subfolder. > > David E. Box (5): > PCI: Add #defines for accessing PCIE DVSEC fields > MFD: intel_pmt: Support non-PMT capabilities > MFD: intel_pmt: Add support for PCIe VSEC structures > platform/x86: intel_pmt_telemetry: Ignore zero sized entries Since this patch is pretty much a stand alone patch I've picked this one (4/5) up now. The rest of the patches touch both MFD and pdx86 files, so these should be picked up by Lee. But they rely on the patch moving the pdx86 pmt code into the drivers/platform/x86/intel/pmt dir which is currently only available in my for-next branch. I think it is probably best to wait for 5.15-rc1 and then Lee can merge the rest. Here is my ack for Lee picking up the pdx86 bits: Acked-by: Hans de Goede Lee, alternatively you could also merge commit e184b1e589a7fbb80bfdd0364c11422999a17a26 from the pdx86 tree, that is only 1 commit ahead of my latest fixes pull-req to Linus for 5.14, so in essence that is 5.14-rc? (?=5 I think) + just the commit which you need as base, then you could still merge these this cycle. If you wish I can put a signed tag on that for you (I will treat it as immutable either way). Regards, Hans > MFD: intel_pmt: Add DG2 support > > drivers/mfd/intel_pmt.c | 256 +++++++++++++++------ > drivers/platform/x86/intel/pmt/class.c | 2 + > drivers/platform/x86/intel/pmt/crashlog.c | 2 +- > drivers/platform/x86/intel/pmt/telemetry.c | 10 +- > include/uapi/linux/pci_regs.h | 4 + > 5 files changed, 197 insertions(+), 77 deletions(-) > > > base-commit: ca42c119fc6746e65423257e7eddf5fc9e96edc2 >