* [PATCH] leds: simatic-ipc-leds-gpio: Make simatic_ipc_led_gpio_table static
@ 2022-09-10 8:58 Hans de Goede
2022-09-10 12:18 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2022-09-10 8:58 UTC (permalink / raw)
To: Pavel Machek, Henning Schild
Cc: Hans de Goede, platform-driver-x86, linux-leds, kernel test robot
simatic_ipc_led_gpio_table is only used inside simatic-ipc-leds-gpio.c,
make it static.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Note since this is a fix to a patch which I merged through the pdx86
tree I plan to merge this today through the pdx86 tree as well.
---
drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c b/drivers/leds/simple/simatic-ipc-leds-gpio.c
index 0d73dcbeec2d..b9eeb8702df0 100644
--- a/drivers/leds/simple/simatic-ipc-leds-gpio.c
+++ b/drivers/leds/simple/simatic-ipc-leds-gpio.c
@@ -15,7 +15,7 @@
#include <linux/platform_device.h>
#include <linux/platform_data/x86/simatic-ipc-base.h>
-struct gpiod_lookup_table *simatic_ipc_led_gpio_table;
+static struct gpiod_lookup_table *simatic_ipc_led_gpio_table;
static struct gpiod_lookup_table simatic_ipc_led_gpio_table_127e = {
.dev_id = "leds-gpio",
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: simatic-ipc-leds-gpio: Make simatic_ipc_led_gpio_table static
2022-09-10 8:58 [PATCH] leds: simatic-ipc-leds-gpio: Make simatic_ipc_led_gpio_table static Hans de Goede
@ 2022-09-10 12:18 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2022-09-10 12:18 UTC (permalink / raw)
To: Pavel Machek, Henning Schild
Cc: platform-driver-x86, linux-leds, kernel test robot
Hi all,
On 9/10/22 10:58, Hans de Goede wrote:
> simatic_ipc_led_gpio_table is only used inside simatic-ipc-leds-gpio.c,
> make it static.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Note since this is a fix to a patch which I merged through the pdx86
> tree I plan to merge this today through the pdx86 tree as well.
I've added this to my review-hans (soon to be for-next) branch now.
Regards,
Hans
> ---
> drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c b/drivers/leds/simple/simatic-ipc-leds-gpio.c
> index 0d73dcbeec2d..b9eeb8702df0 100644
> --- a/drivers/leds/simple/simatic-ipc-leds-gpio.c
> +++ b/drivers/leds/simple/simatic-ipc-leds-gpio.c
> @@ -15,7 +15,7 @@
> #include <linux/platform_device.h>
> #include <linux/platform_data/x86/simatic-ipc-base.h>
>
> -struct gpiod_lookup_table *simatic_ipc_led_gpio_table;
> +static struct gpiod_lookup_table *simatic_ipc_led_gpio_table;
>
> static struct gpiod_lookup_table simatic_ipc_led_gpio_table_127e = {
> .dev_id = "leds-gpio",
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-10 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-10 8:58 [PATCH] leds: simatic-ipc-leds-gpio: Make simatic_ipc_led_gpio_table static Hans de Goede
2022-09-10 12:18 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).