From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0AE4C43334 for ; Thu, 14 Jul 2022 19:43:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240653AbiGNTn2 (ORCPT ); Thu, 14 Jul 2022 15:43:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232580AbiGNTn2 (ORCPT ); Thu, 14 Jul 2022 15:43:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 680E76BC19 for ; Thu, 14 Jul 2022 12:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657827806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dg9+JDWes1KzSSyj81sTXIcE5x2fJUI/Oun+MFc1PXQ=; b=hRaRZLjPyRe+yGORB95OtHBtDlhmp0bliQGuNwz/Tfv8u5qCv+wn5bk/c6J6Cn+0MTrdo4 L0dkHwYHvzX20VZfyTO4QXKspIN/e2ECp47cHO3lWpeMRFxu+4enTri148YBVS9conaOJe U+OViUdAjFyZSnj2u6b6zPs3611xdUY= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-310-BWj2GZ_EMFeRVGXfMW_0dw-1; Thu, 14 Jul 2022 15:43:18 -0400 X-MC-Unique: BWj2GZ_EMFeRVGXfMW_0dw-1 Received: by mail-ed1-f70.google.com with SMTP id w13-20020a05640234cd00b0043a991fb3f3so2082308edc.3 for ; Thu, 14 Jul 2022 12:43:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dg9+JDWes1KzSSyj81sTXIcE5x2fJUI/Oun+MFc1PXQ=; b=MiFf4EHUecUyxwnL41ecJCpxja1yyMRb0pT0DfyFqdLSc0OSyNuwxgbqUMSZC+I0aq L/uyqDRZDGlM+u5RvXQmNtW5eWg4RsiBBfCRRQesEmKuz4voOinIW4f6YOJ/Aet9RqBP j0JEz1fUmPt3EvYUsCKg4Oc1HIPo91oPgvMlP7ANIpKUktdUQcej/pMz1F6NrFSlbFcf PUaQ2z8ey89OL+oUslGm4KyRnnZRC9cTGvoOUCCUmuhI/oEw8nBQI/nM3O1vkGk1DU6E ydKBOduxd8uSiQk1I/IUpvwdMpfL0/ljagGWFM/rO6KF2vSXioEZxoAjeHyAZgZhRoze ELug== X-Gm-Message-State: AJIora8GpWZRXpiT0caGI0nyYQCFYs+wnllvNB5GVd4LsbDqP1w3t3rJ 5tfz0ZXDnUPs8B+iyJR4dB8ov1yAmRyhyW9G2hbGRIxgxbZ6OI+L16FxaAzGZK15v/VqSyOz8v7 9Xb4K+U4oTT+HtQI34ZiABQ/ZWkdwFCgbnA== X-Received: by 2002:aa7:cd0a:0:b0:43a:8ffd:d8de with SMTP id b10-20020aa7cd0a000000b0043a8ffdd8demr14293304edw.5.1657827797361; Thu, 14 Jul 2022 12:43:17 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sjzFwGcCzuqBNOwrF/HzJhG/eH+kbiODMOpHqQTx4Vp9DVXAhl6LxC4caqJ/zuahqUSYSUfQ== X-Received: by 2002:aa7:cd0a:0:b0:43a:8ffd:d8de with SMTP id b10-20020aa7cd0a000000b0043a8ffdd8demr14293272edw.5.1657827797138; Thu, 14 Jul 2022 12:43:17 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id a9-20020a05640213c900b0043b0951f7b1sm1609186edx.41.2022.07.14.12.43.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 12:43:16 -0700 (PDT) Message-ID: <286b0209-ea8d-b3f0-9759-e3a4a86c34cb@redhat.com> Date: Thu, 14 Jul 2022 21:43:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native quirks Content-Language: en-US To: "Limonciello, Mario" , Werner Sembach , Ben Skeggs , Karol Herbst , Lyude , Daniel Dadap , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , "Deucher, Alexander" , "Koenig, Christian" , "Pan@vger.kernel.org" , "Pan, Xinhui" , "Rafael J . Wysocki" , Mika Westerberg , Lukas Wunner , Mark Gross , Andy Shevchenko Cc: "nouveau@lists.freedesktop.org" , Daniel Vetter , David Airlie , intel-gfx , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , Len Brown , "linux-acpi@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" References: <20220712193910.439171-1-hdegoede@redhat.com> <20220712193910.439171-28-hdegoede@redhat.com> <82521ebc-3f14-8d3b-5601-6b4a36ef19af@tuxedocomputers.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 7/13/22 19:21, Limonciello, Mario wrote: > [Public] > > > >> -----Original Message----- >> From: Werner Sembach >> Sent: Wednesday, July 13, 2022 12:08 >> To: Hans de Goede ; Ben Skeggs >> ; Karol Herbst ; Lyude >> ; Daniel Dadap ; Maarten >> Lankhorst ; Maxime Ripard >> ; Thomas Zimmermann ; >> Jani Nikula ; Joonas Lahtinen >> ; Rodrigo Vivi ; >> Tvrtko Ursulin ; Deucher, Alexander >> ; Koenig, Christian >> ; Pan@vger.kernel.org; Pan, Xinhui >> ; Rafael J . Wysocki ; Mika >> Westerberg ; Lukas Wunner >> ; Mark Gross ; Andy >> Shevchenko >> Cc: nouveau@lists.freedesktop.org; Daniel Vetter ; David >> Airlie ; intel-gfx ; dri- >> devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Len Brown >> ; linux-acpi@vger.kernel.org; platform-driver- >> x86@vger.kernel.org >> Subject: Re: [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and >> NL5xNU acpi_backlight=native quirks >> >> Hi, >> >> On 7/12/22 21:39, Hans de Goede wrote: >>> acpi_backlight=native is the default for these, but as the comment >>> explains the quirk was still necessary because even briefly registering >>> the acpi_video0 backlight; and then unregistering it once the native >>> driver showed up, was leading to issues. >>> >>> After the "ACPI: video: Make backlight class device registration >>> a separate step" patch from earlier in this patch-series, we no >>> longer briefly register the acpi_video0 backlight on systems where >>> the native driver should be used. >>> >>> So this is no longer an issue an the quirks are no longer needed. >>> >>> Cc: Werner Sembach >>> Signed-off-by: Hans de Goede >> >> Tested and can confirm: The quirks are no longer needed with this Patchset. >> >> Tested-by: Werner Sembach > > Probably should include this link tag in this commit too then as it fixes > the Tong Fang systems too. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215683 Good point, I've added this to the version in my personal tree. Regards, Hans > >> >> Kind Regards, >> >> Werner Sembach >> >>> --- >>> drivers/acpi/video_detect.c | 75 ------------------------------------- >>> 1 file changed, 75 deletions(-) >>> >>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c >>> index 2a4d376a703e..4b9395d1bda7 100644 >>> --- a/drivers/acpi/video_detect.c >>> +++ b/drivers/acpi/video_detect.c >>> @@ -599,81 +599,6 @@ static const struct dmi_system_id >> video_detect_dmi_table[] = { >>> DMI_MATCH(DMI_BOARD_NAME, "N250P"), >>> }, >>> }, >>> - /* >>> - * Clevo NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2 have >> both a >>> - * working native and video interface. However the default detection >>> - * mechanism first registers the video interface before unregistering >>> - * it again and switching to the native interface during boot. This >>> - * results in a dangling SBIOS request for backlight change for some >>> - * reason, causing the backlight to switch to ~2% once per boot on >> the >>> - * first power cord connect or disconnect event. Setting the native >>> - * interface explicitly circumvents this buggy behaviour, by avoiding >>> - * the unregistering process. >>> - */ >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, >> "SchenkerTechnologiesGmbH"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), >>> - DMI_MATCH(DMI_BOARD_NAME, "AURA1501"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), >>> - DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xNU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xNU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, >> "SchenkerTechnologiesGmbH"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xNU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), >>> - }, >>> - }, >>> >>> /* >>> * Desktops which falsely report a backlight and which our heuristics