platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Kate Hsuan <hpa@redhat.com>, Mark Gross <mgross@linux.intel.com>,
	Alex Hung <alex.hung@canonical.com>,
	Sujith Thomas <sujith.thomas@intel.com>,
	Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
	David E Box <david.e.box@intel.com>,
	Zha Qipeng <qipeng.zha@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	AceLan Kao <acelan.kao@canonical.com>,
	Jithu Joseph <jithu.joseph@intel.com>,
	Maurice Ma <maurice.ma@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Daniel Scally <djrscally@gmail.com>,
	linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 18/20] Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability.
Date: Sun, 15 Aug 2021 16:08:15 +0200	[thread overview]
Message-ID: <2cc45082-692d-1a0e-cb44-7e2393c95152@redhat.com> (raw)
In-Reply-To: <95801e67-f09e-64f3-abd6-f38a8f1f1d51@linaro.org>

Hi,

On 8/14/21 12:39 PM, Daniel Lezcano wrote:
> On 10/08/2021 11:58, Kate Hsuan wrote:
> 
> 
> Why not move it into drivers/thermal/intel ?

This cleanup is really something which Intel should have been doing
itself, but they have not done that, so now Kate has stepped up to
do this.

Figuring out if there is a better home for each of these drivers
really falls outside of the scope of this. If Intel and specifically
Sujith Thomas, the maintainer for that driver who is in the Cc,
believe that drivers/thermal/intel is a better place then they
can submit a patch for this themselves.

If Intel does that right away, then this patch can be dropped from
Kate's patch-set. Otherwise this can be moved a second time once
someone from Intel gets around to it.

Regards,

Hans




> 
> 
>> Signed-off-by: Kate Hsuan <hpa@redhat.com>
>> ---
>>  drivers/platform/x86/Kconfig                       |  8 --------
>>  drivers/platform/x86/Makefile                      |  2 +-
>>  drivers/platform/x86/intel/Kconfig                 |  1 +
>>  drivers/platform/x86/intel/Makefile                |  2 ++
>>  drivers/platform/x86/intel/menlow/Kconfig          | 14 ++++++++++++++
>>  drivers/platform/x86/intel/menlow/Makefile         |  6 ++++++
>>  .../platform/x86/{ => intel/menlow}/intel_menlow.c |  0
>>  7 files changed, 24 insertions(+), 9 deletions(-)
>>  create mode 100644 drivers/platform/x86/intel/menlow/Kconfig
>>  create mode 100644 drivers/platform/x86/intel/menlow/Makefile
>>  rename drivers/platform/x86/{ => intel/menlow}/intel_menlow.c (100%)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index b9c0d2d97793..50ded236a841 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -632,15 +632,7 @@ config THINKPAD_LMI
>>  
>>  source "drivers/platform/x86/intel/Kconfig"
>>  
>> -config INTEL_MENLOW
>> -	tristate "Thermal Management driver for Intel menlow platform"
>> -	depends on ACPI_THERMAL
>> -	select THERMAL
>> -	help
>> -	  ACPI thermal management enhancement driver on
>> -	  Intel Menlow platform.
>>  
>> -	  If unsure, say N.
>>  
>>  config INTEL_OAKTRAIL
>>  	tristate "Intel Oaktrail Platform Extras"
>> diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
>> index f4c6ced59da1..ea5f5dd3f78a 100644
>> --- a/drivers/platform/x86/Makefile
>> +++ b/drivers/platform/x86/Makefile
>> @@ -67,7 +67,7 @@ obj-$(CONFIG_THINKPAD_LMI)	+= think-lmi.o
>>  obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL)		+= intel/
>>  
>>  
>> -obj-$(CONFIG_INTEL_MENLOW)		+= intel_menlow.o
>> +
>>  obj-$(CONFIG_INTEL_OAKTRAIL)		+= intel_oaktrail.o
>>  obj-$(CONFIG_INTEL_VBTN)		+= intel-vbtn.o
>>  
>> diff --git a/drivers/platform/x86/intel/Kconfig b/drivers/platform/x86/intel/Kconfig
>> index 4efb5ad3e3e1..59c9b602c784 100644
>> --- a/drivers/platform/x86/intel/Kconfig
>> +++ b/drivers/platform/x86/intel/Kconfig
>> @@ -36,6 +36,7 @@ source "drivers/platform/x86/intel/intel_speed_select_if/Kconfig"
>>  source "drivers/platform/x86/intel/turbo_max_3/Kconfig"
>>  source "drivers/platform/x86/intel/uncore_freq/Kconfig"
>>  source "drivers/platform/x86/intel/int0002/Kconfig"
>> +source "drivers/platform/x86/intel/menlow/Kconfig"
>>  
>>  
>>  endif # X86_PLATFORM_DRIVERS_INTEL
>> diff --git a/drivers/platform/x86/intel/Makefile b/drivers/platform/x86/intel/Makefile
>> index fe5058c3af18..b2326554bd84 100644
>> --- a/drivers/platform/x86/intel/Makefile
>> +++ b/drivers/platform/x86/intel/Makefile
>> @@ -12,6 +12,7 @@ obj-$(CONFIG_INTEL_HID_EVENT)		+= hid/
>>  obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE)	+= wmi/
>>  obj-$(CONFIG_INTEL_WMI_THUNDERBOLT)	+= wmi/
>>  obj-$(CONFIG_INTEL_INT0002_VGPIO)	+= int0002/
>> +obj-$(CONFIG_INTEL_MENLOW)		+= menlow/
>>  
>>  
>>  # Intel PMIC / PMC / P-Unit devices
>> @@ -38,3 +39,4 @@ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE)	+= intel_speed_select_if/
>>  obj-$(CONFIG_INTEL_TURBO_MAX_3)			+= turbo_max_3/
>>  obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL)		+= uncore_freq/
>>  
>> +
>> diff --git a/drivers/platform/x86/intel/menlow/Kconfig b/drivers/platform/x86/intel/menlow/Kconfig
>> new file mode 100644
>> index 000000000000..b2920d259ff7
>> --- /dev/null
>> +++ b/drivers/platform/x86/intel/menlow/Kconfig
>> @@ -0,0 +1,14 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +#
>> +# Intel x86 Platform Specific Drivers
>> +#
>> +
>> +config INTEL_MENLOW
>> +	tristate "Thermal Management driver for Intel menlow platform"
>> +	depends on ACPI_THERMAL
>> +	select THERMAL
>> +	help
>> +	  ACPI thermal management enhancement driver on
>> +	  Intel Menlow platform.
>> +
>> +	  If unsure, say N.
>> diff --git a/drivers/platform/x86/intel/menlow/Makefile b/drivers/platform/x86/intel/menlow/Makefile
>> new file mode 100644
>> index 000000000000..0e9fda9bff98
>> --- /dev/null
>> +++ b/drivers/platform/x86/intel/menlow/Makefile
>> @@ -0,0 +1,6 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +#
>> +# Intel x86 Platform Specific Drivers
>> +#
>> +
>> +obj-$(CONFIG_INTEL_MENLOW)		+= intel_menlow.o
>> diff --git a/drivers/platform/x86/intel_menlow.c b/drivers/platform/x86/intel/menlow/intel_menlow.c
>> similarity index 100%
>> rename from drivers/platform/x86/intel_menlow.c
>> rename to drivers/platform/x86/intel/menlow/intel_menlow.c
>>
> 
> 


  reply	other threads:[~2021-08-15 14:08 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  9:58 [PATCH 00/20] Move Intel platform drivers to intel directory to improve readability Kate Hsuan
2021-08-10  9:58 ` [PATCH 01/20] Move Intel hid of pdx86 " Kate Hsuan
2021-08-10  9:58 ` [PATCH 02/20] Move Intel WMI driver of pdx86 to intel/ " Kate Hsuan
2021-08-10  9:58 ` [PATCH 03/20] Move Intel bxtwc " Kate Hsuan
2021-08-10  9:58 ` [PATCH 04/20] Move Intel chtdc_ti driver of pdx86 " Kate Hsuan
2021-08-10  9:58 ` [PATCH 05/20] Move MRFLD power button driver of pdx86 to intel directory " Kate Hsuan
2021-08-10  9:58 ` [PATCH 06/20] Move Intel PMC core of pdx86 to intel/ " Kate Hsuan
2021-08-10  9:58 ` [PATCH 07/20] Move Intel PMT driver of pdx86 to intel/ " Kate Hsuan
2021-08-10 16:51   ` David E. Box
2021-08-10  9:58 ` [PATCH 08/20] Move Intel P-Unit of pdx86 to intel/ directory " Kate Hsuan
2021-08-10 16:55   ` David E. Box
2021-08-11  5:43     ` Kate Hsuan
2021-08-10  9:58 ` [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to increase readability Kate Hsuan
2021-08-10 10:05   ` Mika Westerberg
2021-08-10 11:43     ` Kate Hsuan
2021-08-10 13:27       ` Andy Shevchenko
2021-08-10  9:58 ` [PATCH 10/20] Move Intel SoC telemetry driver to intel directory to improve readability Kate Hsuan
2021-08-10  9:58 ` [PATCH 11/20] Move Intel IPS driver of pdx86 " Kate Hsuan
2021-08-10  9:58 ` [PATCH 12/20] Move Intel RST driver of pdx86 to intel directory " Kate Hsuan
2021-08-10  9:58 ` [PATCH 13/20] Move Intel smartconnect driver of pdx86 to intel/ " Kate Hsuan
2021-08-10  9:58 ` [PATCH 14/20] Move Intel SST driver " Kate Hsuan
2021-08-10  9:58 ` [PATCH 15/20] Move Intel turbo max 3 " Kate Hsuan
2021-08-10  9:58 ` [PATCH 16/20] Move Intel uncore freq " Kate Hsuan
2021-08-10  9:58 ` [PATCH 17/20] Move Intel int0002 vgpio driver to intel/ directory to inprove readability Kate Hsuan
2021-08-10  9:58 ` [PATCH 18/20] Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability Kate Hsuan
2021-08-14 10:39   ` Daniel Lezcano
2021-08-15 14:08     ` Hans de Goede [this message]
2021-08-16  3:11       ` Pandruvada, Srinivas
2021-08-16  7:40         ` Hans de Goede
2021-08-16  7:43           ` Kate Hsuan
2021-08-10  9:58 ` [PATCH 19/20] Move OakTrail driver to the " Kate Hsuan
2021-08-10  9:58 ` [PATCH 20/20] Move Intel virtual botton driver to " Kate Hsuan
2021-08-10 13:23 ` [PATCH 00/20] Move Intel platform drivers to intel " Andy Shevchenko
2021-08-11 12:41   ` Andy Shevchenko
2021-08-10 14:05 ` Hans de Goede
2021-08-11  9:06   ` Kate Hsuan
2021-08-10 17:03 ` David E. Box
2021-08-10 17:28   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cc45082-692d-1a0e-cb44-7e2393c95152@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=acelan.kao@canonical.com \
    --cc=alex.hung@canonical.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=david.e.box@intel.com \
    --cc=djrscally@gmail.com \
    --cc=hpa@redhat.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=jithu.joseph@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maurice.ma@intel.com \
    --cc=mgross@linux.intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=qipeng.zha@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=sujith.thomas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).