From: Hans de Goede <hdegoede@redhat.com>
To: Dongliang Mu <dzm91@hust.edu.cn>,
"David E. Box" <david.e.box@linux.intel.com>,
Mark Gross <markgross@kernel.org>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next v2 3/3] drivers/platform/x86/intel: fix a memory leak in intel_vsec_add_aux
Date: Mon, 20 Mar 2023 11:31:34 +0100 [thread overview]
Message-ID: <2ce0b1cc-f595-1fab-3f4d-d0891d04347b@redhat.com> (raw)
In-Reply-To: <20230309040107.534716-4-dzm91@hust.edu.cn>
Hi,
On 3/9/23 05:01, Dongliang Mu wrote:
> The first error handling code in intel_vsec_add_aux misses the
> deallocation of intel_vsec_dev->resource.
>
> Fix this by adding kfree(intel_vsec_dev->resource) in the error handling
> code.
>
> Reviewed-by: David E. Box <david.e.box@linux.intel.com>
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
Thank you for your patch, I've applied this patch (as first patch
in the series) to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/intel/vsec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
> index 13decf36c6de..2311c16cb975 100644
> --- a/drivers/platform/x86/intel/vsec.c
> +++ b/drivers/platform/x86/intel/vsec.c
> @@ -154,6 +154,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
> ret = ida_alloc(intel_vsec_dev->ida, GFP_KERNEL);
> mutex_unlock(&vsec_ida_lock);
> if (ret < 0) {
> + kfree(intel_vsec_dev->resource);
> kfree(intel_vsec_dev);
> return ret;
> }
prev parent reply other threads:[~2023-03-20 10:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230309040107.534716-1-dzm91@hust.edu.cn>
2023-03-09 4:01 ` [PATCH linux-next v2 1/3] platform/x86/intel/tpmi: Fix double free in tpmi_create_device() Dongliang Mu
2023-03-14 14:22 ` Dan Carpenter
2023-03-16 14:25 ` Hans de Goede
2023-03-16 18:18 ` srinivas pandruvada
2023-03-17 1:28 ` Dongliang Mu
2023-03-17 8:51 ` Hans de Goede
2023-03-17 10:23 ` srinivas pandruvada
2023-03-17 11:57 ` Dongliang Mu
2023-03-17 10:27 ` srinivas pandruvada
2023-03-20 2:43 ` Dongliang Mu
2023-03-20 6:32 ` srinivas pandruvada
2023-03-20 10:32 ` Hans de Goede
2023-03-09 4:01 ` [PATCH linux-next v2 2/3] drivers/platform/x86/intel/tpmi: revise the comment of intel_vsec_add_aux Dongliang Mu
2023-03-20 10:33 ` Hans de Goede
2023-03-20 10:57 ` Dongliang Mu
2023-03-20 13:40 ` Hans de Goede
2023-03-09 4:01 ` [PATCH linux-next v2 3/3] drivers/platform/x86/intel: fix a memory leak in intel_vsec_add_aux Dongliang Mu
2023-03-20 10:31 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ce0b1cc-f595-1fab-3f4d-d0891d04347b@redhat.com \
--to=hdegoede@redhat.com \
--cc=david.e.box@linux.intel.com \
--cc=dzm91@hust.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).