From: "Slark Xiao" <slark_xiao@163.com>
To: hmh@hmh.eng.br, hdegoede@redhat.com, mgross@linux.intel.com
Cc: markpearson@lenovo.com, njoshi1@lenovo.com,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86 <platform-driver-x86@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re:[PATCH v3] Fix WWAN device disabled issue after S3 deep
Date: Mon, 8 Nov 2021 14:13:06 +0800 (CST) [thread overview]
Message-ID: <2fba6bb0.1aad.17cfe2dcd36.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <20211108060648.8212-1-slark_xiao@163.com>
Correct address for platform-driver-x86.
At 2021-11-08 14:06:48, "Slark Xiao" <slark_xiao@163.com> wrote:
>When WWAN device wake from S3 deep, under thinkpad platform,
>WWAN would be disabled. This disable status could be checked
>by command 'nmcli r wwan' or 'rfkill list'.
>
>Issue analysis as below:
> When host resume from S3 deep, thinkpad_acpi driver would
>call hotkey_resume() function. Finnaly, it will use
>wan_get_status to check the current status of WWAN device.
>During this resume progress, wan_get_status would always
>return off even WWAN boot up completely.
> In patch V2, Hans said 'sw_state should be unchanged
>after a suspend/resume. It's better to drop the
>tpacpi_rfk_update_swstate call all together from the
>resume path'.
> And it's confimed by Lenovo that GWAN is no longer
> available from WHL generation because the design does not
> match with current pin control.
>
>Signed-off-by: Slark Xiao <slark_xiao@163.com>
>---
> drivers/platform/x86/thinkpad_acpi.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
>diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
>index 50ff04c84650..f1cbd27282e1 100644
>--- a/drivers/platform/x86/thinkpad_acpi.c
>+++ b/drivers/platform/x86/thinkpad_acpi.c
>@@ -1178,15 +1178,6 @@ static int tpacpi_rfk_update_swstate(const struct tpacpi_rfk *tp_rfk)
> return status;
> }
>
>-/* Query FW and update rfkill sw state for all rfkill switches */
>-static void tpacpi_rfk_update_swstate_all(void)
>-{
>- unsigned int i;
>-
>- for (i = 0; i < TPACPI_RFK_SW_MAX; i++)
>- tpacpi_rfk_update_swstate(tpacpi_rfkill_switches[i]);
>-}
>-
> /*
> * Sync the HW-blocking state of all rfkill switches,
> * do notice it causes the rfkill core to schedule uevents
>@@ -3129,9 +3120,6 @@ static void tpacpi_send_radiosw_update(void)
> if (wlsw == TPACPI_RFK_RADIO_OFF)
> tpacpi_rfk_update_hwblock_state(true);
>
>- /* Sync sw blocking state */
>- tpacpi_rfk_update_swstate_all();
>-
> /* Sync hw blocking state last if it is hw-unblocked */
> if (wlsw == TPACPI_RFK_RADIO_ON)
> tpacpi_rfk_update_hwblock_state(false);
>--
>2.25.1
next parent reply other threads:[~2021-11-08 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211108060648.8212-1-slark_xiao@163.com>
2021-11-08 6:13 ` Slark Xiao [this message]
[not found] ` <b3523a57-a21e-80ca-561d-23f6ee89913d@redhat.com>
[not found] ` <7821731c.1990.17d02723fb6.Coremail.slark_xiao@163.com>
2021-11-16 6:40 ` Re:Re:Re: [PATCH v3] Fix WWAN device disabled issue after S3 deep Slark Xiao
2021-11-16 10:02 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fba6bb0.1aad.17cfe2dcd36.Coremail.slark_xiao@163.com \
--to=slark_xiao@163.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=markpearson@lenovo.com \
--cc=mgross@linux.intel.com \
--cc=njoshi1@lenovo.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).