From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEB5DC433ED for ; Fri, 21 May 2021 10:24:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C093D60FD9 for ; Fri, 21 May 2021 10:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232930AbhEUKZl (ORCPT ); Fri, 21 May 2021 06:25:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53821 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhEUKZk (ORCPT ); Fri, 21 May 2021 06:25:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621592657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qQf/Hh2l4u5gnRu5DSKsYeaXSP/3LChq3DuXAPax/WQ=; b=e24ZireIHFg8XW1RvdIcI4xkUnadGbp6HZs7MS0nn22twLQO3Ol3lY3eVG2UXYuZ18bVki Qr9kGigPG1iuXmipBE0kAjmma67mXXoVNg4j5b7HuRT+kgf2iaF2ta5fkLAl5uo0pf+1ad 0kwxGLZOao5EzJ8qYcvV9M+jkAFlytA= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45--3GrwncaNreY1PLWlDPxJA-1; Fri, 21 May 2021 06:24:15 -0400 X-MC-Unique: -3GrwncaNreY1PLWlDPxJA-1 Received: by mail-ej1-f69.google.com with SMTP id j16-20020a1709062a10b02903ba544485d0so6019003eje.3 for ; Fri, 21 May 2021 03:24:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qQf/Hh2l4u5gnRu5DSKsYeaXSP/3LChq3DuXAPax/WQ=; b=L4EnCiShWnI+LTehQKiBAdFzpXfD4+t3RTN0DE0BIEB8ZwLPYjXyrgncAq77dHlq3d bmxK+SvmmnQjd2W/1BuxZU+z67nzEWEfU0HLhEzycSZRY2FGnPIX1rS5JVPbyTJWBeqx hDjBbkSNmcQ4ljx/rLGOYQ/8QVzitogmf9I5WLpWb5HJWD4m7ITnNn/NOuZ4zpZX9ece f3QAjV6XAopihLp7qz3LSG1FvCbZdbnwLTfE/W2ke7VUDcZsmvFLuuAd7KKQFvTHo0As 5gaUUxOz0oGDCf6uO1a47YCpWRCigbuqcblR2o7g2ks0mpVwA6gqwz4HBlencw3fExcS pz3w== X-Gm-Message-State: AOAM532Gn9/QhuSRjHalMJGghaEn5b6DvKRh9amO1GPdFTsDIARiQvPc as9rLOy6YMJvKNm1qSeofH26faX2xZUgm7ZDbI8IGsRdCVraagzj5Yxe01W4GTFFtBsvzByH3T/ hGhLDs0z4ZyoLV0YqoW13wMXZYfnFfzGdgg== X-Received: by 2002:a50:fe8c:: with SMTP id d12mr10444294edt.336.1621592654263; Fri, 21 May 2021 03:24:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbNzpuYFAHecQ+LXIx6j20OJOBqJXyR+Z5LZNynWWpMjm/IYwUm8EET6Q8qgoiCvrvsN7N/A== X-Received: by 2002:a50:fe8c:: with SMTP id d12mr10444283edt.336.1621592654118; Fri, 21 May 2021 03:24:14 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id t19sm3779587eds.4.2021.05.21.03.24.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 May 2021 03:24:13 -0700 (PDT) Subject: Re: [PATCH 0/2] Remove GA14/15 quirks to acpi/video_detect To: "Luke D. Jones" Cc: corentin.chary@gmail.com, acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210419074915.393433-1-luke@ljones.dev> From: Hans de Goede Message-ID: <3559f449-7d43-bf6f-0047-3138fd303db8@redhat.com> Date: Fri, 21 May 2021 12:24:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210419074915.393433-1-luke@ljones.dev> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi Luke, On 4/19/21 9:49 AM, Luke D. Jones wrote: > Revert two commits to allow a patch to acpi/video_detect to correctly > set the backlight control as native. > > Luke D. Jones (2): > Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk > structures" > Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG Zephyrus > G14 and G15" Thank you, since the matching drivers/acpi/video_detect.c have been merged by Rafael, I've added these to my review-hans branch now. But there is one problem, these miss a: Signed-off-by: Luke D. Jones In their commit message, I assume this was an oversight, so I've added this. If you can let me know if this is ok, then I can push these to for-next. I've also rewritten the commit messages to explain why things are being reverted, see: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Regards, Hans