From: Hans de Goede <hdegoede@redhat.com>
To: Tian Tao <tiantao6@hisilicon.com>,
mgross@linux.intel.com, vadimp@nvidia.com
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag
Date: Wed, 7 Apr 2021 20:05:37 +0200 [thread overview]
Message-ID: <40909c51-da6b-d43a-f4fc-5d0455d9b7c2@redhat.com> (raw)
In-Reply-To: <1617785983-28878-1-git-send-email-tiantao6@hisilicon.com>
Hi,
On 4/7/21 10:59 AM, Tian Tao wrote:
> disable_irq() after request_irq() still has a time gap in which
> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> disable IRQ auto-enable because of requesting.
>
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/mellanox/mlxreg-hotplug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
> index b013445..a9db2f3 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -683,13 +683,13 @@ static int mlxreg_hotplug_probe(struct platform_device *pdev)
>
> err = devm_request_irq(&pdev->dev, priv->irq,
> mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING
> - | IRQF_SHARED, "mlxreg-hotplug", priv);
> + | IRQF_SHARED | IRQF_NO_AUTOEN,
> + "mlxreg-hotplug", priv);
> if (err) {
> dev_err(&pdev->dev, "Failed to request irq: %d\n", err);
> return err;
> }
>
> - disable_irq(priv->irq);
> spin_lock_init(&priv->lock);
> INIT_DELAYED_WORK(&priv->dwork_irq, mlxreg_hotplug_work_handler);
> dev_set_drvdata(&pdev->dev, priv);
>
prev parent reply other threads:[~2021-04-07 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 8:59 [PATCH] platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-04-07 9:02 ` Vadim Pasternak
2021-04-07 18:05 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40909c51-da6b-d43a-f4fc-5d0455d9b7c2@redhat.com \
--to=hdegoede@redhat.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).