From: "Box, David E" <david.e.box@intel.com>
To: "jstultz@google.com" <jstultz@google.com>,
"mario.limonciello@amd.com" <mario.limonciello@amd.com>,
"svenva@chromium.org" <svenva@chromium.org>,
"irenic.rajneesh@gmail.com" <irenic.rajneesh@gmail.com>
Cc: "Shyam-sundar.S-k@amd.com" <Shyam-sundar.S-k@amd.com>,
"markgross@kernel.org" <markgross@kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"rrangel@chromium.org" <rrangel@chromium.org>,
"Jain, Rajat" <rajatja@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v5 3/4] platform/x86/intel/pmc: core: Always capture counters on suspend
Date: Mon, 3 Apr 2023 16:58:21 +0000 [thread overview]
Message-ID: <41b516903b7522ea618585dd854b4c5c6037da27.camel@intel.com> (raw)
In-Reply-To: <20230330194439.14361-4-mario.limonciello@amd.com>
On Thu, 2023-03-30 at 14:44 -0500, Mario Limonciello wrote:
> Currently counters are only captured during suspend when the
> warn_on_s0ix_failures module parameter is set.
>
> In order to relay this counter information to the kernel reporting
> infrastructure adjust it so that the counters are always captured.
>
> warn_on_s0ix_failures will be utilized solely for messaging by
> the driver instead.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
> ---
> v4->v5:
> * Squash patches together
> * Add extra pm_suspend_via_firmware() check for resume routine too
> ---
> drivers/platform/x86/intel/pmc/core.c | 13 +++++--------
> drivers/platform/x86/intel/pmc/core.h | 2 --
> 2 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmc/core.c
> b/drivers/platform/x86/intel/pmc/core.c
> index 3a15d32d7644..e2f171fac094 100644
> --- a/drivers/platform/x86/intel/pmc/core.c
> +++ b/drivers/platform/x86/intel/pmc/core.c
> @@ -1168,12 +1168,6 @@ static __maybe_unused int pmc_core_suspend(struct
> device *dev)
> {
> struct pmc_dev *pmcdev = dev_get_drvdata(dev);
>
> - pmcdev->check_counters = false;
> -
> - /* No warnings on S0ix failures */
> - if (!warn_on_s0ix_failures)
> - return 0;
> -
> /* Check if the syspend will actually use S0ix */
> if (pm_suspend_via_firmware())
> return 0;
> @@ -1186,7 +1180,6 @@ static __maybe_unused int pmc_core_suspend(struct device
> *dev)
> if (pmc_core_dev_state_get(pmcdev, &pmcdev->s0ix_counter))
> return -EIO;
>
> - pmcdev->check_counters = true;
> return 0;
> }
>
> @@ -1222,12 +1215,16 @@ static __maybe_unused int pmc_core_resume(struct
> device *dev)
> const struct pmc_bit_map **maps = pmcdev->map->lpm_sts;
> int offset = pmcdev->map->lpm_status_offset;
>
> - if (!pmcdev->check_counters)
> + /* Check if the syspend used S0ix */
> + if (pm_suspend_via_firmware())
> return 0;
>
> if (!pmc_core_is_s0ix_failed(pmcdev))
> return 0;
>
> + if (!warn_on_s0ix_failures)
> + return 0;
> +
> if (pmc_core_is_pc10_failed(pmcdev)) {
> /* S0ix failed because of PC10 entry failure */
> dev_info(dev, "CPU did not enter PC10!!! (PC10 cnt=0x%llx)\n",
> diff --git a/drivers/platform/x86/intel/pmc/core.h
> b/drivers/platform/x86/intel/pmc/core.h
> index 810204d758ab..51d73efceaf3 100644
> --- a/drivers/platform/x86/intel/pmc/core.h
> +++ b/drivers/platform/x86/intel/pmc/core.h
> @@ -319,7 +319,6 @@ struct pmc_reg_map {
> * @pmc_xram_read_bit: flag to indicate whether PMC XRAM shadow registers
> * used to read MPHY PG and PLL status are available
> * @mutex_lock: mutex to complete one transcation
> - * @check_counters: On resume, check if counters are getting incremented
> * @pc10_counter: PC10 residency counter
> * @s0ix_counter: S0ix residency (step adjusted)
> * @num_lpm_modes: Count of enabled modes
> @@ -338,7 +337,6 @@ struct pmc_dev {
> int pmc_xram_read_bit;
> struct mutex lock; /* generic mutex lock for PMC Core */
>
> - bool check_counters; /* Check for counter increments on resume */
> u64 pc10_counter;
> u64 s0ix_counter;
> int num_lpm_modes;
next prev parent reply other threads:[~2023-04-03 16:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 19:44 [PATCH v5 0/4] Add vendor agnostic mechanism to report hardware sleep Mario Limonciello
2023-03-30 19:44 ` [PATCH v5 1/4] PM: Add a sysfs file to represent time spent in hardware sleep state Mario Limonciello
2023-03-31 18:01 ` Rafael J. Wysocki
2023-03-31 18:05 ` Limonciello, Mario
2023-03-31 18:07 ` Rafael J. Wysocki
2023-03-31 18:13 ` Limonciello, Mario
2023-03-31 18:25 ` Rafael J. Wysocki
2023-03-30 19:44 ` [PATCH v5 2/4] platform/x86/amd: pmc: Report duration of time in hw " Mario Limonciello
2023-03-30 19:44 ` [PATCH v5 3/4] platform/x86/intel/pmc: core: Always capture counters on suspend Mario Limonciello
2023-04-03 16:58 ` Box, David E [this message]
2023-03-30 19:44 ` [PATCH v5 4/4] platform/x86/intel/pmc: core: Report duration of time in HW sleep state Mario Limonciello
2023-03-31 3:02 ` kernel test robot
2023-03-31 18:05 ` Rafael J. Wysocki
2023-04-03 18:00 ` Box, David E
2023-04-03 18:07 ` Limonciello, Mario
2023-04-03 18:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41b516903b7522ea618585dd854b4c5c6037da27.camel@intel.com \
--to=david.e.box@intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=hdegoede@redhat.com \
--cc=irenic.rajneesh@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rajatja@google.com \
--cc=rrangel@chromium.org \
--cc=svenva@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).