platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Joseph, Jithu" <jithu.joseph@intel.com>
To: Dave Hansen <dave.hansen@intel.com>, <hdegoede@redhat.com>,
	<markgross@kernel.org>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
	<gregkh@linuxfoundation.org>, <rostedt@goodmis.org>,
	<ashok.raj@intel.com>, <tony.luck@intel.com>,
	<linux-kernel@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
	<ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
	<athenas.jimenez.gonzalez@intel.com>, <sohil.mehta@intel.com>
Subject: Re: [PATCH v2 4/7] platform/x86/intel/ifs: Implement Array BIST test
Date: Wed, 22 Feb 2023 14:07:35 -0800	[thread overview]
Message-ID: <42ac85ea-0ffe-55fc-57c2-6f4555e8dc5b@intel.com> (raw)
In-Reply-To: <9c55a34b-c17e-2a62-9989-902ce940dde5@intel.com>



On 2/22/2023 12:12 PM, Dave Hansen wrote:
> 
> I actually really think this tracing should go away, *ESPECIALLY* if you
> insist on dumping out raw, non-human-readable MSR values.
> 
> I say NAK on the tracing.  You haven't convinced me that it's necessary
> on top of what we have today (MSR tracing).


Thanks for the pointer on MSR trace. I agree that setting the appropriate filter ("msr == 0x105") would generate the read and write values (snip2 below).

The primary value addition for the custom trace added by this driver was readability / convenience (snip1 below).  The format it is dumping today is most convenient for tracking  the progress of this test  from start to completion. (Two formatted input fields (wrmsr) and one output field (rdmsr) on the same line ).
Another convenience is that, by enabling the high-level intel_ifs trace,  we can see all  activity related to all IFS tests (and not having to explicitly remember and enable the MSRs corresponding to each of the IFS tests)

Since the trace has to be explicitly enabled (I thought it is okay to add a more convenient custom one only to be enabled for detailed analysis when required).

<Snip 1 added by driver>
     bash-9411    [123] ..... 423555.355664: ifs_array: cpu: 10, array_list: ffffffff, array_bank: 0000, status: 0000010000007ff2
     bash-9411    [123] ..... 423555.355858: ifs_array: cpu: 10, array_list: 00007ff2, array_bank: 0100, status: 0000000000007fe0
     bash-9411    [123] ..... 423555.355891: ifs_array: cpu: 10, array_list: 00007fe0, array_bank: 0000, status: 0000010000007fe0
     bash-9411    [123] ..... 423555.355923: ifs_array: cpu: 10, array_list: 00007fe0, array_bank: 0100, status: 0000000100007fe0
</snip1>


<snip2 using msr trace>
   migration/10-76      [010] d..1. 423672.955522: write_msr: 105, value ffffffff
   migration/10-76      [010] d..1. 423672.955525: read_msr: 105, value 10000007ff2
   migration/10-76      [010] d..1. 423672.955733: write_msr: 105, value 10000007ff2
   migration/10-76      [010] d..1. 423672.955736: read_msr: 105, value 7fe0
   migration/10-76      [010] d..1. 423672.955783: write_msr: 105, value 7fe0
   migration/10-76      [010] d..1. 423672.955786: read_msr: 105, value 10000007fe0
   migration/10-76      [010] d..1. 423672.955819: write_msr: 105, value 10000007fe0
   migration/10-76      [010] d..1. 423672.955822: read_msr: 105, value 100007fe0
</snip2 msr trace>


Jithu

  reply	other threads:[~2023-02-22 22:07 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 23:42 [PATCH 0/5] Add Array BIST test support to IFS Jithu Joseph
2023-01-31 23:42 ` [PATCH 1/5] x86/include/asm/msr-index.h: Add IFS Array test bits Jithu Joseph
2023-01-31 23:42 ` [PATCH 2/5] platform/x86/intel/ifs: Introduce Array Scan test to IFS Jithu Joseph
2023-01-31 23:43 ` [PATCH 3/5] platform/x86/intel/ifs: Sysfs interface for Array BIST Jithu Joseph
2023-02-01  5:04   ` Greg KH
2023-02-01 20:55     ` Joseph, Jithu
2023-01-31 23:43 ` [PATCH 4/5] platform/x86/intel/ifs: Implement Array BIST test Jithu Joseph
2023-02-01  5:02   ` Greg KH
2023-02-01 17:22     ` Luck, Tony
2023-02-01 18:19       ` Greg KH
2023-02-01 19:22         ` Tony Luck
2023-02-01 19:35   ` Dave Hansen
2023-02-01 19:43     ` Luck, Tony
2023-02-01 19:53       ` Dave Hansen
2023-02-01 19:45   ` Dave Hansen
2023-02-01 19:56     ` Joseph, Jithu
2023-02-01 20:49       ` Dave Hansen
2023-02-01 21:34         ` Luck, Tony
2023-01-31 23:43 ` [PATCH 5/5] platform/x86/intel/ifs: Trace support for array test Jithu Joseph
2023-02-06 16:40   ` Steven Rostedt
2023-02-06 19:50     ` Joseph, Jithu
2023-02-14 23:44 ` [PATCH v2 0/7] Add Array BIST test support to IFS Jithu Joseph
2023-02-14 23:44   ` [PATCH v2 1/7] x86/include/asm/msr-index.h: Add IFS Array test bits Jithu Joseph
2023-02-14 23:44   ` [PATCH v2 2/7] platform/x86/intel/ifs: Introduce Array Scan test to IFS Jithu Joseph
2023-02-16 12:40     ` Greg KH
2023-02-16 18:46       ` Luck, Tony
2023-02-16 22:57       ` Joseph, Jithu
2023-02-17  9:25         ` Greg KH
2023-02-14 23:44   ` [PATCH v2 3/7] platform/x86/intel/ifs: Sysfs interface for Array BIST Jithu Joseph
2023-02-14 23:44   ` [PATCH v2 4/7] platform/x86/intel/ifs: Implement Array BIST test Jithu Joseph
2023-02-15 16:58     ` Dave Hansen
2023-02-15 17:11       ` Dave Hansen
2023-02-15 20:22         ` Joseph, Jithu
2023-02-15 20:26           ` Dave Hansen
2023-02-15 21:13             ` Joseph, Jithu
2023-02-15 21:18               ` Dave Hansen
2023-02-22 20:12               ` Dave Hansen
2023-02-22 22:07                 ` Joseph, Jithu [this message]
2023-02-22 22:28                   ` Dave Hansen
2023-02-22 22:36                     ` Steven Rostedt
2023-02-22 23:32                     ` Joseph, Jithu
2023-02-22 23:59                       ` Dave Hansen
2023-02-15 17:44       ` Joseph, Jithu
2023-02-14 23:44   ` [PATCH v2 5/7] platform/x86/intel/ifs: Trace support for array test Jithu Joseph
2023-02-16  0:56     ` Steven Rostedt
2023-02-14 23:44   ` [PATCH v2 6/7] platform/x86/intel/ifs: Update IFS doc Jithu Joseph
2023-02-14 23:44   ` [PATCH v2 7/7] Documentation/ABI: Update IFS ABI doc Jithu Joseph
2023-03-01  1:59   ` [PATCH v3 0/8] Add Array BIST test support to IFS Jithu Joseph
2023-03-01  1:59     ` [PATCH v3 1/8] platform/x86/intel/ifs: Reorganize driver data Jithu Joseph
2023-03-13 14:46       ` Hans de Goede
2023-03-13 21:34         ` Joseph, Jithu
2023-03-16  9:43           ` Hans de Goede
2023-03-01  1:59     ` [PATCH v3 2/8] platform/x86/intel/ifs: IFS cleanup Jithu Joseph
2023-03-13 15:02       ` Hans de Goede
2023-03-01  1:59     ` [PATCH v3 3/8] x86/include/asm/msr-index.h: Add IFS Array test bits Jithu Joseph
2023-03-13 15:03       ` Hans de Goede
2023-03-01  1:59     ` [PATCH v3 4/8] platform/x86/intel/ifs: Introduce Array Scan test to IFS Jithu Joseph
2023-03-13 16:10       ` Hans de Goede
2023-03-13 16:29         ` Hans de Goede
2023-03-13 17:21           ` Luck, Tony
2023-03-15 19:29             ` Joseph, Jithu
2023-03-16  9:50               ` Hans de Goede
2023-03-16 19:44                 ` Joseph, Jithu
2023-03-01  1:59     ` [PATCH v3 5/8] platform/x86/intel/ifs: Sysfs interface for Array BIST Jithu Joseph
2023-03-13 16:14       ` Hans de Goede
2023-03-01  1:59     ` [PATCH v3 6/8] platform/x86/intel/ifs: Implement Array BIST test Jithu Joseph
2023-03-13 16:24       ` Hans de Goede
2023-03-13 16:37         ` Joseph, Jithu
2023-03-16  9:59           ` Hans de Goede
2023-03-16 17:40             ` Joseph, Jithu
2023-03-16 18:11             ` Joseph, Jithu
2023-03-16 19:38               ` Hans de Goede
2023-03-01  1:59     ` [PATCH v3 7/8] platform/x86/intel/ifs: Update IFS doc Jithu Joseph
2023-03-01  1:59     ` [PATCH v3 8/8] Documentation/ABI: Update IFS ABI doc Jithu Joseph
2023-03-07 11:02     ` [PATCH v3 0/8] Add Array BIST test support to IFS Hans de Goede
2023-03-22  0:33     ` [PATCH v4 0/9] " Jithu Joseph
2023-03-22  0:33       ` [PATCH v4 1/9] platform/x86/intel/ifs: Separate ifs_pkg_auth from ifs_data Jithu Joseph
2023-03-22  0:33       ` [PATCH v4 2/9] platform/x86/intel/ifs: Reorganize driver data Jithu Joseph
2023-03-22  0:33       ` [PATCH v4 3/9] platform/x86/intel/ifs: IFS cleanup Jithu Joseph
2023-03-22  0:33       ` [PATCH v4 4/9] x86/include/asm/msr-index.h: Add IFS Array test bits Jithu Joseph
2023-03-22  0:33       ` [PATCH v4 5/9] platform/x86/intel/ifs: Introduce Array Scan test to IFS Jithu Joseph
2023-03-22  0:33       ` [PATCH v4 6/9] platform/x86/intel/ifs: Sysfs interface for Array BIST Jithu Joseph
2023-03-22  0:33       ` [PATCH v4 7/9] platform/x86/intel/ifs: Implement Array BIST test Jithu Joseph
2023-03-22  0:33       ` [PATCH v4 8/9] platform/x86/intel/ifs: Update IFS doc Jithu Joseph
2023-03-22  0:33       ` [PATCH v4 9/9] Documentation/ABI: Update IFS ABI doc Jithu Joseph
2023-03-27 13:10       ` [PATCH v4 0/9] Add Array BIST test support to IFS Hans de Goede
2023-04-07  1:49         ` Pengfei Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42ac85ea-0ffe-55fc-57c2-6f4555e8dc5b@intel.com \
    --to=jithu.joseph@intel.com \
    --cc=ashok.raj@intel.com \
    --cc=athenas.jimenez.gonzalez@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=mingo@redhat.com \
    --cc=patches@lists.linux.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@linutronix.de \
    --cc=thiago.macieira@intel.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).