From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C048C43460 for ; Thu, 6 May 2021 08:47:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 121A361177 for ; Thu, 6 May 2021 08:47:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233837AbhEFIsZ (ORCPT ); Thu, 6 May 2021 04:48:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34850 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233820AbhEFIsY (ORCPT ); Thu, 6 May 2021 04:48:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620290846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KRIn6MQisNyLZZ3un1MN0Pyrf/x2u4ROIjZCBtc/1Es=; b=cpT0KYZlT0tyjUJO1k9T33xbS8ds1nFFZBEbDr+iBwfLdTM4XaTAfGI0WIadDSMGvBlAxm RP28vYEU0lvEkUEkJOgS+RotrLpmPMct2rXm73xjiJY3sQUuaH1QCwq/HZ+v2lWCoRo5S4 rSp2yHIZ5ZpY/r+DPjqKWbFW8gZgRO0= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-a5f-RGppNYy1uQoX99vM-g-1; Thu, 06 May 2021 04:47:24 -0400 X-MC-Unique: a5f-RGppNYy1uQoX99vM-g-1 Received: by mail-ed1-f71.google.com with SMTP id c15-20020a056402100fb029038518e5afc5so2270715edu.18 for ; Thu, 06 May 2021 01:47:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KRIn6MQisNyLZZ3un1MN0Pyrf/x2u4ROIjZCBtc/1Es=; b=lBYvFF1gNkSy7uCv6AsQof5F30QEwWTha1qVrDnZ3r1cEQipl0U4rEs3V8WyFRLs5g UjCH04v+6nEsWEOhcGZtNNaYXTqSjnrQNI31lRfjl/GYjRPY14O8TV/np0mVXpNcnAA/ 49P5y1MFQlq2izk7RXryZJtDCRKB5lNyf2HRx0UCP663enWAISgMK0bugMqMo6XGSTPA qmmbcSZms9sgMyonwIquBOkFEFldmv39bERk2EZt+cS5W9QRtRB/yq7ef3BH9CbakLEA ul6rLJ3HaLT28FlZ/c5p9Zgst7mG6Ux0kXq4ZLAr4bDSMxVNekqNzQ5hNZp2mO7y+1mS PzbA== X-Gm-Message-State: AOAM531K0wWs/GC93uDR69QJve6apFr9vEyn3RwAGOkfP3RAkyKkNXd0 N75mMXPlm1ZSpMwRbfLr6dx/ySchbwwlBbapjsDXb7lnz4OJnSMH8sipUYQnJ7YqBxCKCC69Ho2 JY6qvlENc3HGvqJvo9Z0O1NHi88eTlBGGWQ== X-Received: by 2002:a17:906:b1cc:: with SMTP id bv12mr3139440ejb.407.1620290843608; Thu, 06 May 2021 01:47:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5WRJKGPMKVmDFF5BwJVdGJUqxr4ZQ+H+x9+d7+GGOMWKY0RO66B9rNI18XTyDb9a6RlsqdQ== X-Received: by 2002:a17:906:b1cc:: with SMTP id bv12mr3139419ejb.407.1620290843387; Thu, 06 May 2021 01:47:23 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id v16sm1092562edt.53.2021.05.06.01.47.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 May 2021 01:47:23 -0700 (PDT) Subject: Re: [PATCH v7 1/7] MAINTAINERS: Add Advantech AHC1EC0 embedded controller entry To: Campion Kang , Lee Jones , Rob Herring , Mark Gross , Wim Van Sebroeck , Guenter Roeck , Jean Delvare , Jonathan Corbet , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, platform-driver-x86@vger.kernel.org, AceLan Kao References: <20210506081619.2443-1-campion.kang@advantech.com.tw> From: Hans de Goede Message-ID: <6b86bd36-b934-c204-9e56-079ab8cd4b54@redhat.com> Date: Thu, 6 May 2021 10:47:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210506081619.2443-1-campion.kang@advantech.com.tw> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, I'm replying here since this series has no cover-letter, for the next version for a series touching so many different sub-systems it would be good to start with a cover-letter providing some background info on the series. I see this is binding to an ACPI device, yet it is also using devicetree bindings and properties. So I take it this means that your ACPI tables are using the optional capability of embedded device-tree blobs inside the ACPI tables ? That is an unusual combination on a x86 device, note it is not wrong but AFAIK you are the first to do this on x86. Other then that question, for the next version please give all commits a proper commit message and not just a short 1 line Subject and put the changelog after a scissors line after your Signed-off-by like this: Signed-off-by: Campion Kang --- Changed in V7: 1. According to the reviewer's comment, add two files: Documentation/hwmon/ahc1ec0-hwmon.rst and drivers/platform/x86/ahc1ec0-core.c And please also include older changelog entries. Regards, Hans On 5/6/21 10:16 AM, Campion Kang wrote: > Changed in V7: > 1. According to the reviewer's comment, add two files: > Documentation/hwmon/ahc1ec0-hwmon.rst and > drivers/platform/x86/ahc1ec0-core.c > > Signed-off-by: Campion Kang > --- > MAINTAINERS | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 83c2b1867586..984795eb6b5d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -572,6 +572,19 @@ S: Maintained > F: Documentation/scsi/advansys.rst > F: drivers/scsi/advansys.c > > +ADVANTECH AHC1EC0 EMBEDDED CONTROLLER DRIVER > +M: Campion Kang > +L: linux-kernel@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/mfd/ahc1ec0.yaml > +F: Documentation/hwmon/ahc1ec0-hwmon.rst > +F: drivers/hwmon/ahc1ec0-hwmon.c > +F: drivers/mfd/ahc1ec0.c > +F: drivers/platform/x86/ahc1ec0-core.c > +F: drivers/watchdog/ahc1ec0-wdt.c > +F: include/dt-bindings/mfd/ahc1ec0-dt.h > +F: include/linux/platform_data/ahc1ec0.h > + > ADVANTECH SWBTN DRIVER > M: Andrea Ho > L: platform-driver-x86@vger.kernel.org >