From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0442C19F28 for ; Wed, 27 Jul 2022 04:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240270AbiG0Eff (ORCPT ); Wed, 27 Jul 2022 00:35:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240209AbiG0Efd (ORCPT ); Wed, 27 Jul 2022 00:35:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 98325BF73 for ; Tue, 26 Jul 2022 21:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658896531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Nhmdd76VxuZywcj4ABrLti2+JKOVAikxn2IN6L8acM=; b=dgRTNSxhuFkV7YNGzVBVDTQKwFbBAV/jaFluy71WagnQS8IaRLJYgs3CA1NRb7X7q6wk62 1NwdA91oL99Ezay9+Yo8dKObFk17QPtPoW+oc9Kf0VJK6zDFh/6wRZaGg3e0bmZU3K/s5A miArsWOBOoUjN+rhqJcWAmcXvTrSQoo= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-213-vMuHludUPsOJrRUlfOSbjg-1; Wed, 27 Jul 2022 00:35:30 -0400 X-MC-Unique: vMuHludUPsOJrRUlfOSbjg-1 Received: by mail-pj1-f71.google.com with SMTP id t19-20020a17090a5d9300b001f2f3223d17so1590073pji.9 for ; Tue, 26 Jul 2022 21:35:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4Nhmdd76VxuZywcj4ABrLti2+JKOVAikxn2IN6L8acM=; b=Qz90zRfPjJ+463gWLTJs+w7AbJjEeDkshMKYwOyAvG/24H50TTImLrwN0L/DOqALIS Xgmw15/dSe2ECFhe/wu5Mi5a+r1IDY05h7zgrBgsozCuQmMNAdFUZ1H9Py2SlKvmLAem oDRAJli2MLHP31eGBHmAAaZfac2h7OKGSI2eIzZcFhqBIQn1jHsQLJLjCzFYQroh1TwK ThP4KtjELQxRHzf/Bve4xQYlghziN+gGPnGQIiPctqXiHUy6x4ORavRjNXBJYq5ydcnp pSEi6gP7sSxOz7hq23BNucmxAXfTr6oLIv1K292MyvUim3IBfIhxpLkVzsEuzTv2nOo/ AWKg== X-Gm-Message-State: AJIora/vB7PVnd83WeWNp7KWdvQXsKUHn/9rPKkjCaa9InxqJKt/IE/o rNC7gfqWGt77TTBhJEydiGVHAvARt2SxLN3BeJYRZcxWEpq/tYCQLZn6KHxI7FRjm9wqmVlmmpL MvVEuAIORjtvNa63yMt6vYaQ6/sSp4LKc1w== X-Received: by 2002:a17:90b:1d90:b0:1f2:5f47:ca6c with SMTP id pf16-20020a17090b1d9000b001f25f47ca6cmr2521231pjb.162.1658896528719; Tue, 26 Jul 2022 21:35:28 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sv66YMuYLn2D/TECwlGvVrDyp85rujIUbxh1LnRrYj8nx/VinuiyLNA/hwGDceqmYNtwAlaQ== X-Received: by 2002:a17:90b:1d90:b0:1f2:5f47:ca6c with SMTP id pf16-20020a17090b1d9000b001f25f47ca6cmr2521196pjb.162.1658896528457; Tue, 26 Jul 2022 21:35:28 -0700 (PDT) Received: from [10.72.12.96] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id i17-20020a170902c95100b0016d9d729f0bsm2843421pla.135.2022.07.26.21.35.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 21:35:26 -0700 (PDT) Message-ID: <7b33b166-785f-ef8a-153f-e0b1c3b7e23d@redhat.com> Date: Wed, 27 Jul 2022 12:35:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v13 22/42] virtio_ring: packed: introduce virtqueue_reinit_packed() Content-Language: en-US To: Xuan Zhuo , virtualization@lists.linux-foundation.org Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , "Michael S. Tsirkin" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com References: <20220726072225.19884-1-xuanzhuo@linux.alibaba.com> <20220726072225.19884-23-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220726072225.19884-23-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org 在 2022/7/26 15:22, Xuan Zhuo 写道: > Introduce a function to initialize vq without allocating new ring, > desc_state, desc_extra. > > Subsequent patches will call this function after reset vq to > reinitialize vq. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang > --- > drivers/virtio/virtio_ring.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 00b18cf3b4d9..7d4c444b5a9d 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -1957,6 +1957,27 @@ static void virtqueue_vring_attach_packed(struct vring_virtqueue *vq, > vq->packed = *vring_packed; > } > > +static void virtqueue_reinit_packed(struct vring_virtqueue *vq) > +{ > + int size, i; > + > + memset(vq->packed.vring.device, 0, vq->packed.event_size_in_bytes); > + memset(vq->packed.vring.driver, 0, vq->packed.event_size_in_bytes); > + memset(vq->packed.vring.desc, 0, vq->packed.ring_size_in_bytes); > + > + size = sizeof(struct vring_desc_state_packed) * vq->packed.vring.num; > + memset(vq->packed.desc_state, 0, size); > + > + size = sizeof(struct vring_desc_extra) * vq->packed.vring.num; > + memset(vq->packed.desc_extra, 0, size); > + > + for (i = 0; i < vq->packed.vring.num - 1; i++) > + vq->packed.desc_extra[i].next = i + 1; > + > + virtqueue_init(vq, vq->packed.vring.num); > + virtqueue_vring_init_packed(&vq->packed, !!vq->vq.callback); > +} > + > static struct virtqueue *vring_create_virtqueue_packed( > unsigned int index, > unsigned int num,