platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "yuechao.zhao(赵越超)" <yuechao.zhao@advantech.com.cn>
To: Pavel Machek <pavel@ucw.cz>
Cc: "345351830@qq.com" <345351830@qq.com>,
	"Rainbow.Zhang(張玉)" <Rainbow.Zhang@advantech.com.cn>,
	"yunxia.li(李云霞)" <yunxia.li@advantech.com.cn>,
	"Jia.Sui(贾睢)" <Jia.Sui@advantech.com.cn>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Mark Gross" <mgross@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>
Subject: RE: [v2,1/1] adv_mix955x is a scheme that multiplexes PCA9554/PCA9555 into LED and GPIO
Date: Wed, 28 Apr 2021 01:51:04 +0000	[thread overview]
Message-ID: <859d8fcef654414c9ba55993adc93104@ACNMB2.ACN.ADVANTECH.CORP> (raw)
In-Reply-To: <20210427135356.GA2426@duo.ucw.cz>

Hi Pavel
As for " Please Cc LED drivers to the LED maintainers...", does it mean that I only need to Cc LED drivers to LED maintainers?
Or do I need to send this driver to linux-leds@vger.kernel.org instead of platform-driver-x86@vger.kernel.org.

Best regards
Yuechao Zhao

-----Original Message-----
From: Pavel Machek [mailto:pavel@ucw.cz] 
Sent: Tuesday, April 27, 2021 9:54 PM
To: yuechao.zhao(赵越超) <yuechao.zhao@advantech.com.cn>
Cc: 345351830@qq.com; Rainbow.Zhang(張玉) <Rainbow.Zhang@advantech.com.cn>; yunxia.li(李云霞) <yunxia.li@advantech.com.cn>; Jia.Sui(贾睢) <Jia.Sui@advantech.com.cn>; Hans de Goede <hdegoede@redhat.com>; Mark Gross <mgross@linux.intel.com>; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org
Subject: Re: [v2,1/1] adv_mix955x is a scheme that multiplexes PCA9554/PCA9555 into LED and GPIO

On Tue 2021-04-27 08:32:05, yuechao.zhao(赵越超) wrote:
> From: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
> 
> With this driver, we can multiplex PCA9554/PCA9555 into LED and GPIO based on the ACPI data of BIOS.
> 
> Signed-off-by: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
> Signed-off-by: Sui Jia <jia.sui@advantech.com.cn>

Please Cc LED drivers to the LED maintainers...

> +
> +static inline u8 amix955x_set_bit(u8 val, int led_id, enum 
> +AMIX955X_LED
> +state) {
> +	led_id %= BANK_SIZE;
> +
> +	switch (state) {
> +	case AMIX955X_LED_ON:
> +		val &= ~(1 << led_id); //Clear bit
> +		break;
> +	case AMIX955X_LED_OFF:
> +		val |= 1 << led_id; //Set bit
> +		break;
> +	}
> +
> +	return val;

Please check CodingStyle, avoid useless comments and check word wrapping in your email settings.

Best regards,
								Pavel

--
http://www.livejournal.com/~pavelmachek

  reply	other threads:[~2021-04-28  1:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_17A7BBC4D15D331C1A25B4075294E5D67706@qq.com>
2021-04-27  8:32 ` [v2,1/1] adv_mix955x is a scheme that multiplexes PCA9554/PCA9555 into LED and GPIO yuechao.zhao(赵越超)
2021-04-27 13:53   ` Pavel Machek
2021-04-28  1:51     ` yuechao.zhao(赵越超) [this message]
2021-08-04 16:10       ` Pavel Machek
2021-05-02 10:48   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=859d8fcef654414c9ba55993adc93104@ACNMB2.ACN.ADVANTECH.CORP \
    --to=yuechao.zhao@advantech.com.cn \
    --cc=345351830@qq.com \
    --cc=Jia.Sui@advantech.com.cn \
    --cc=Rainbow.Zhang@advantech.com.cn \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=yunxia.li@advantech.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).