From: Hans de Goede <hdegoede@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: rafael@kernel.org, Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 04/36] platform/x86: ibm_rtl: move to use bus_get_dev_root()
Date: Wed, 15 Mar 2023 13:46:03 +0100 [thread overview]
Message-ID: <8dde2c71-0c79-50af-e5aa-de3c9ee2955d@redhat.com> (raw)
In-Reply-To: <20230313182918.1312597-4-gregkh@linuxfoundation.org>
Hi,
On 3/13/23 19:28, Greg Kroah-Hartman wrote:
> Direct access to the struct bus_type dev_root pointer is going away soon
> so replace that with a call to bus_get_dev_root() instead, which is what
> it is there for.
>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mark Gross <markgross@kernel.org>
> Cc: platform-driver-x86@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Note, this is a patch that is a prepatory cleanup as part of a larger
> series of patches that is working on resolving some old driver core
> design mistakes. It will build and apply cleanly on top of 6.3-rc2 on
> its own, but I'd prefer if I could take it through my driver-core tree
> so that the driver core changes can be taken through there for 6.4-rc1.
Taking this upstream through the driver-core tree is fine by me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> drivers/platform/x86/ibm_rtl.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/ibm_rtl.c b/drivers/platform/x86/ibm_rtl.c
> index 5fc665f7d9b3..2ab7d9ac542d 100644
> --- a/drivers/platform/x86/ibm_rtl.c
> +++ b/drivers/platform/x86/ibm_rtl.c
> @@ -199,16 +199,26 @@ static int rtl_setup_sysfs(void) {
>
> ret = subsys_system_register(&rtl_subsys, NULL);
> if (!ret) {
> - for (i = 0; rtl_attributes[i]; i ++)
> - device_create_file(rtl_subsys.dev_root, rtl_attributes[i]);
> + struct device *dev_root = bus_get_dev_root(&rtl_subsys);
> +
> + if (dev_root) {
> + for (i = 0; rtl_attributes[i]; i ++)
> + device_create_file(dev_root, rtl_attributes[i]);
> + put_device(dev_root);
> + }
> }
> return ret;
> }
>
> static void rtl_teardown_sysfs(void) {
> + struct device *dev_root = bus_get_dev_root(&rtl_subsys);
> int i;
> - for (i = 0; rtl_attributes[i]; i ++)
> - device_remove_file(rtl_subsys.dev_root, rtl_attributes[i]);
> +
> + if (dev_root) {
> + for (i = 0; rtl_attributes[i]; i ++)
> + device_remove_file(dev_root, rtl_attributes[i]);
> + put_device(dev_root);
> + }
> bus_unregister(&rtl_subsys);
> }
>
next prev parent reply other threads:[~2023-03-15 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230313182918.1312597-1-gregkh@linuxfoundation.org>
2023-03-13 18:28 ` [PATCH 04/36] platform/x86: ibm_rtl: move to use bus_get_dev_root() Greg Kroah-Hartman
2023-03-15 12:46 ` Hans de Goede [this message]
2023-03-13 18:28 ` [PATCH 05/36] platform/x86: intel-uncore-freq: " Greg Kroah-Hartman
2023-03-13 19:14 ` srinivas pandruvada
2023-03-15 12:46 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dde2c71-0c79-50af-e5aa-de3c9ee2955d@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).