From: Hans de Goede <hdegoede@redhat.com>
To: Khalil Blaiech <kblaiech@nvidia.com>,
markgross@kernel.org, vadimp@nvidia.com
Cc: platform-driver-x86@vger.kernel.org, davthompson@nvidia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support
Date: Wed, 5 Apr 2023 16:34:08 +0200 [thread overview]
Message-ID: <8f33b1af-ffcb-9eb2-9294-9b3c5e4fee33@redhat.com> (raw)
In-Reply-To: <7ec19101-0288-71e1-cdca-cfe7acbbe0e9@redhat.com>
Hi,
On 4/5/23 16:33, Hans de Goede wrote:
> Hi Khalil,
>
> On 4/5/23 15:16, Khalil Blaiech wrote:
>> Add a new sysfs to initiate firmware reset in isolation mode.
>>
>> Reviewed-by: David Thompson <davthompson@nvidia.com>
>> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
>
> Why are you resending this less then 24 hours after the initial submission ?
Never mind, I see you added a missing Cc: platform-driver-x86@vger.kernel.org
which is good.
Next time please add a little note to the resend explaining why you
are resending it though.
Regards,
Hans
>> ---
>> drivers/platform/mellanox/mlxbf-bootctl.c | 19 +++++++++++++++++++
>> drivers/platform/mellanox/mlxbf-bootctl.h | 6 ++++++
>> 2 files changed, 25 insertions(+)
>>
>> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c b/drivers/platform/mellanox/mlxbf-bootctl.c
>> index 1c7a288b59a5..5e41c270195c 100644
>> --- a/drivers/platform/mellanox/mlxbf-bootctl.c
>> +++ b/drivers/platform/mellanox/mlxbf-bootctl.c
>> @@ -244,11 +244,29 @@ static ssize_t secure_boot_fuse_state_show(struct device *dev,
>> return buf_len;
>> }
>>
>> +static ssize_t fw_reset_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf, size_t count)
>> +{
>> + unsigned long key;
>> + int err;
>> +
>> + err = kstrtoul(buf, 16, &key);
>> + if (err)
>> + return err;
>> +
>> + if (mlxbf_bootctl_smc(MLXBF_BOOTCTL_FW_RESET, key) < 0)
>> + return -EINVAL;
>> +
>> + return count;
>> +}
>> +
>> static DEVICE_ATTR_RW(post_reset_wdog);
>> static DEVICE_ATTR_RW(reset_action);
>> static DEVICE_ATTR_RW(second_reset_action);
>> static DEVICE_ATTR_RO(lifecycle_state);
>> static DEVICE_ATTR_RO(secure_boot_fuse_state);
>> +static DEVICE_ATTR_WO(fw_reset);
>>
>> static struct attribute *mlxbf_bootctl_attrs[] = {
>> &dev_attr_post_reset_wdog.attr,
>> @@ -256,6 +274,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
>> &dev_attr_second_reset_action.attr,
>> &dev_attr_lifecycle_state.attr,
>> &dev_attr_secure_boot_fuse_state.attr,
>> + &dev_attr_fw_reset.attr,
>> NULL
>> };
>>
>> diff --git a/drivers/platform/mellanox/mlxbf-bootctl.h b/drivers/platform/mellanox/mlxbf-bootctl.h
>> index 148fdb43b435..b48243f60a59 100644
>> --- a/drivers/platform/mellanox/mlxbf-bootctl.h
>> +++ b/drivers/platform/mellanox/mlxbf-bootctl.h
>> @@ -75,6 +75,12 @@
>>
>> #define MLXBF_BOOTCTL_GET_DIMM_INFO 0x82000008
>>
>> +/*
>> + * Initiate Firmware Reset via TYU. This might be invoked during the reset
>> + * flow in isolation mode.
>> + */
>> +#define MLXBF_BOOTCTL_FW_RESET 0x8200000D
>> +
>> /* SMC function IDs for SiP Service queries */
>> #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT 0x8200ff00
>> #define MLXBF_BOOTCTL_SIP_SVC_UID 0x8200ff01
>
next prev parent reply other threads:[~2023-04-05 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 13:16 [PATCH v1 1/1 RESEND] platform/mellanox: add firmware reset support Khalil Blaiech
2023-04-05 14:33 ` Hans de Goede
2023-04-05 14:34 ` Hans de Goede [this message]
2023-04-05 14:40 ` Khalil Blaiech
2023-04-05 14:39 ` Khalil Blaiech
2023-04-06 12:28 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f33b1af-ffcb-9eb2-9294-9b3c5e4fee33@redhat.com \
--to=hdegoede@redhat.com \
--cc=davthompson@nvidia.com \
--cc=kblaiech@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).