From: Mark Pearson <markpearson@lenovo.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: <mgross@linux.intel.com>, <platform-driver-x86@vger.kernel.org>
Subject: Re: [External] Re: [PATCH] platform/x86: thinkpad_acpi: Correct thermal sensor allocation
Date: Tue, 13 Apr 2021 07:30:44 -0400 [thread overview]
Message-ID: <92846990-bc3f-fd1c-b854-d03a258e93c1@lenovo.com> (raw)
In-Reply-To: <1f0e16b9-ab78-881b-1918-7b8cf61bc546@redhat.com>
Thanks Hans
On 13/04/2021 02:28, Hans de Goede wrote:
> Hi,
>
> On 4/7/21 11:20 PM, Mark Pearson wrote:
>> On recent Thinkpad platforms it was reported that temp sensor 11 was
>> always incorrectly displaying 66C. It turns out the reason for this is
>> that this location in EC RAM is not a temperature sensor but is the
>> power supply ID (offset 0xC2).
>>
>> Based on feedback from the Lenovo firmware team the EC RAM version can
>> be determined and for the current version (3) only the 0x78 to 0x7F
>> range is used for temp sensors. I don't have any details for earlier
>> versions so I have left the implementation unaltered there.
>>
>> Note - in this block only 0x78 and 0x79 are officially designated (CPU &
>> GPU sensors). The use of the other locations in the block will vary from
>> platform to platform; but the existing logic to detect a sensor presence
>> holds.
>>
>> Signed-off-by: Mark Pearson <markpearson@lenovo.com>
>
> I've merged this, note I've added one small fixup to initialize ver to
> 0 when it is declared, also see a remark inline below.
>
Agreed on setting ver to zero - thanks for adding that
Mark
prev parent reply other threads:[~2021-04-13 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 21:20 [PATCH] platform/x86: thinkpad_acpi: Correct thermal sensor allocation Mark Pearson
2021-04-13 6:28 ` Hans de Goede
2021-04-13 11:30 ` Mark Pearson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92846990-bc3f-fd1c-b854-d03a258e93c1@lenovo.com \
--to=markpearson@lenovo.com \
--cc=hdegoede@redhat.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).