From: Kate Hsuan <hpa@redhat.com>
To: Dan Scally <dan.scally@ideasonboard.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Daniel Scally <djrscally@gmail.com>,
Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH v2 3/4] leds: tps68470: Add LED control for tps68470
Date: Tue, 21 Mar 2023 17:36:41 +0800 [thread overview]
Message-ID: <CAEth8oF1SLhxBOvUK6=P7Pjof9F5cRRenQJ45D2cQ3k6N6tjQw@mail.gmail.com> (raw)
In-Reply-To: <82eaa100-c334-fb02-f956-5515e9b3d79d@ideasonboard.com>
On Mon, Mar 20, 2023 at 10:24 PM Dan Scally <dan.scally@ideasonboard.com> wrote:
>
> Hi Kate - sorry just noticed one more thing...
>
> On 10/03/2023 09:56, Kate Hsuan wrote:
> > There are two LED controllers, LEDA indicator LED and LEDB flash LED for
> > tps68470. LEDA can be enabled by setting TPS68470_ILEDCTL_ENA. Moreover,
> > tps68470 provides four levels of power status for LEDB. If the
> > properties called "ti,ledb-current" can be found, the current will be
> > set according to the property values. These two LEDs can be controlled
> > through the LED class of sysfs (tps68470-leda and tps68470-ledb).
> >
> > Signed-off-by: Kate Hsuan <hpa@redhat.com>
> > ---
> > drivers/leds/Kconfig | 12 +++
> > drivers/leds/Makefile | 1 +
> > drivers/leds/leds-tps68470.c | 182 +++++++++++++++++++++++++++++++++++
> > 3 files changed, 195 insertions(+)
> > create mode 100644 drivers/leds/leds-tps68470.c
> >
> > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> > index 9dbce09eabac..fd26036b3c61 100644
> > --- a/drivers/leds/Kconfig
> > +++ b/drivers/leds/Kconfig
> > @@ -827,6 +827,18 @@ config LEDS_TPS6105X
> > It is a single boost converter primarily for white LEDs and
> > audio amplifiers.
> >
> > +config LEDS_TPS68470
> > + tristate "LED support for TI TPS68470"
> > + depends on LEDS_CLASS
> > + depends on INTEL_SKL_INT3472
> > + help
> > + This driver supports TPS68470 PMIC with LED chip.
> > + It provide two LED controllers, including an indicator LED
> > + and a flash LED.
> > +
> > + To compile this driver as a module, choose M and it will be
> > + called leds-tps68470
> > +
> > config LEDS_IP30
> > tristate "LED support for SGI Octane machines"
> > depends on LEDS_CLASS
> > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
> > index d30395d11fd8..b284bc0daa98 100644
> > --- a/drivers/leds/Makefile
> > +++ b/drivers/leds/Makefile
> > @@ -84,6 +84,7 @@ obj-$(CONFIG_LEDS_TURRIS_OMNIA) += leds-turris-omnia.o
> > obj-$(CONFIG_LEDS_WM831X_STATUS) += leds-wm831x-status.o
> > obj-$(CONFIG_LEDS_WM8350) += leds-wm8350.o
> > obj-$(CONFIG_LEDS_WRAP) += leds-wrap.o
> > +obj-$(CONFIG_LEDS_TPS68470) += leds-tps68470.o
>
>
> Alphabetical order here too please :)
>
Thank you. I updated this. :)
--
BR,
Kate
next prev parent reply other threads:[~2023-03-21 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 9:56 [PATCH v2 0/4] leds: tps68470: LED driver for TPS68470 Kate Hsuan
2023-03-10 9:56 ` [PATCH v2 1/4] platform: x86: int3472: Add MFD cell for tps68470 LED Kate Hsuan
2023-03-10 11:13 ` Dan Scally
2023-03-10 9:56 ` [PATCH v2 2/4] include: mfd: tps68470: Add masks for LEDA and LEDB Kate Hsuan
2023-03-10 9:56 ` [PATCH v2 3/4] leds: tps68470: Add LED control for tps68470 Kate Hsuan
2023-03-10 10:43 ` Dan Scally
2023-03-13 3:21 ` Kate Hsuan
2023-03-20 14:23 ` Dan Scally
2023-03-21 9:36 ` Kate Hsuan [this message]
2023-03-10 9:56 ` [PATCH v2 4/4] platform: x86: int3472: Register a LED lookup table entry for the privacy LED Kate Hsuan
2023-03-10 11:23 ` Dan Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEth8oF1SLhxBOvUK6=P7Pjof9F5cRRenQJ45D2cQ3k6N6tjQw@mail.gmail.com' \
--to=hpa@redhat.com \
--cc=dan.scally@ideasonboard.com \
--cc=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).