From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
linux-watchdog@vger.kernel.org,
Srikanth Krishnakar <skrishnakar@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Mark Gross <mgross@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>, Pavel Machek <pavel@ucw.cz>,
Enrico Weigelt <lkml@metux.net>
Subject: Re: [PATCH v4 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs
Date: Fri, 26 Nov 2021 17:02:00 +0200 [thread overview]
Message-ID: <CAHp75VcD0FQuG_AToNkVHHD9e6WV6=18P4U0cSi0qzD3FL=ssw@mail.gmail.com> (raw)
In-Reply-To: <20211126141027.16161-3-henning.schild@siemens.com>
On Fri, Nov 26, 2021 at 4:10 PM Henning Schild
<henning.schild@siemens.com> wrote:
>
> This driver adds initial support for several devices from Siemens. It is
> based on a platform driver introduced in an earlier commit.
...
> +static struct simatic_ipc_led simatic_ipc_leds_mem[] = {
> + {0x500 + 0x1A0, "red:" LED_FUNCTION_STATUS "-1"},
> + {0x500 + 0x1A8, "green:" LED_FUNCTION_STATUS "-1"},
> + {0x500 + 0x1C8, "red:" LED_FUNCTION_STATUS "-2"},
> + {0x500 + 0x1D0, "green:" LED_FUNCTION_STATUS "-2"},
> + {0x500 + 0x1E0, "red:" LED_FUNCTION_STATUS "-3"},
> + {0x500 + 0x198, "green:" LED_FUNCTION_STATUS "-3"},
> + { }
> +};
Like I said, this is not okay.
Why can't you simply enable the pinctrl driver and use it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-26 15:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 14:10 [PATCH v4 0/4] add device drivers for Siemens Industrial PCs Henning Schild
2021-11-26 14:10 ` [PATCH v4 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices Henning Schild
2021-11-26 14:10 ` [PATCH v4 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs Henning Schild
2021-11-26 15:02 ` Andy Shevchenko [this message]
2021-11-26 17:48 ` Henning Schild
2021-11-26 18:12 ` Henning Schild
2021-11-30 15:15 ` Andy Shevchenko
2021-12-03 19:35 ` Henning Schild
2021-11-26 14:10 ` [PATCH v4 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs Henning Schild
2021-11-26 14:10 ` [PATCH v4 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs Henning Schild
2021-11-26 14:51 ` Andy Shevchenko
2021-11-26 15:25 ` Henning Schild
2021-11-26 15:34 ` [PATCH v4 0/4] add device drivers for Siemens Industrial PCs Henning Schild
2021-11-26 16:02 ` Guenter Roeck
2021-11-26 17:28 ` Henning Schild
2021-12-03 19:44 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcD0FQuG_AToNkVHHD9e6WV6=18P4U0cSi0qzD3FL=ssw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=gerd.haeussler.ext@siemens.com \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkml@metux.net \
--cc=mgross@linux.intel.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=skrishnakar@gmail.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).